From: yangchenyuan <chenyuan0y@gmail.com>
To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, zijie98@gmail.com,
Chenyuan Yang <chenyuan0y@gmail.com>
Subject: [PATCH] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: fix race condition
Date: Fri, 10 Jan 2025 23:35:57 -0600 [thread overview]
Message-ID: <20250111053557.1803140-1-chenyuan0y@gmail.com> (raw)
From: Chenyuan Yang <chenyuan0y@gmail.com>
The yt2_1380_fc_serdev_probe() function calls devm_serdev_device_open()
before it calls serdev_device_set_client_ops(). This can trigger a NULL
pointer dereference.
This is similar to 5e700b384ec13f5bcac9855cb28fcc674f1d3593.
Fixes: b2ed33e8d486 ("platform/x86: Add lenovo-yoga-tab2-pro-1380-fastcharger driver")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
---
.../platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c b/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
index d2699ca24f34..1a4e66464a7e 100644
--- a/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
+++ b/drivers/platform/x86/lenovo-yoga-tab2-pro-1380-fastcharger.c
@@ -199,15 +199,15 @@ static int yt2_1380_fc_serdev_probe(struct serdev_device *serdev)
if (ret)
return ret;
- ret = devm_serdev_device_open(dev, serdev);
- if (ret)
- return dev_err_probe(dev, ret, "opening UART device\n");
-
serdev_device_set_baudrate(serdev, 600);
serdev_device_set_flow_control(serdev, false);
serdev_device_set_drvdata(serdev, fc);
serdev_device_set_client_ops(serdev, &yt2_1380_fc_serdev_ops);
+ ret = devm_serdev_device_open(dev, serdev);
+ if (ret)
+ return dev_err_probe(dev, ret, "opening UART device\n");
+
ret = devm_extcon_register_notifier_all(dev, fc->extcon, &fc->nb);
if (ret)
return dev_err_probe(dev, ret, "registering extcon notifier\n");
--
2.34.1
next reply other threads:[~2025-01-11 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 5:35 yangchenyuan [this message]
2025-01-11 9:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250111053557.1803140-1-chenyuan0y@gmail.com \
--to=chenyuan0y@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=zijie98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®