From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43C1A19922F for ; Sat, 11 Jan 2025 16:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736612153; cv=none; b=GbayOY1ICozxXEGbLJzoutoyDbOhFPsN/+lfhQyCsKD40NxBEir33/hgjLKmiqJ9yszrL2aGoO80bfZ8ST8wVimAwddE1jJtr4lklu+qZBUsibyAus2HATrGct738PM/Xfcfqshn9FKoaEmCItzG3IG2bDnB+bIpoqp1zLcU7e4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736612153; c=relaxed/simple; bh=OI68onKi6KoJtopdFkSsGF2khOUuq6xNaRWnaWzYi6g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GKIS1WQnPFJLfsHhalj7sgOTdspoJTam7x46Ugse1l9YKXYkGSrG+aKtBHEmFEQnnSMOxKckfWpS5vywgyDhU0K92Agvq6gt0MBKGXIyxoi1Gtm7Xm7h3HXYuzeDB8dvvXK+fiD2Pm+YCWqczc6tSqDHLuuoZtH1z6+lwOiy5cQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OIy+i7e6; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OIy+i7e6" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43618283dedso29125555e9.3 for ; Sat, 11 Jan 2025 08:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736612151; x=1737216951; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XLNrcx9cjynqqzuzB4NpWA0HHiIsSv6AxtzMCkQZk1s=; b=OIy+i7e639yw6QGV4rSBul/AVzQN3LYuCiO4CB8AOHcNHZ1JmQImXprhsgg/DxI7yu y2KZP+y4HSUO3fg1KuZVUH99+f6l1sbCZvjyXqb1VrS+d9iEuAAJY+x4cAOzv7fYv+ga zsCgp6BF18TpJSxV/rlh88g8/QRaHS8JDDdEfbUy+Y5Z9mK8YlV3jkDuwYDeX+qvFFYx xQKYgGFkfKTkYNa1cGkRQ3ZobSKf+yp5m9ZmpDmWlPzSeCZUB7HKKAzvvoTZBCPK2aAp NioqvA/6vYsBFVqDKhBJds8dY1X2btHLj8jpqu/mifQ/6d4mWqZn+7XaQqqrSD9cWnjy 3eUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736612151; x=1737216951; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XLNrcx9cjynqqzuzB4NpWA0HHiIsSv6AxtzMCkQZk1s=; b=WxunMzaaDgPv9eRMPQPQZVecr4qrBeFBHpu2WpNdhglQ1cBBCRteB7d4pz1GCTz8Z7 RLRceP6gDIdHc3+7ebU6hmMAaL7qczCl3Qm/fx5yMGpMGQQKFY+aJb5vOUJxbkudxBvr GZccerXnHBNHNbXhT3MZePAm+onieABxeIOQxjolyOovcLLA+T/InlliDlE3+eBQzsog JCk0pcyPV1HBz+pVpWTZRJPQECmjfjADNDO9bgtvw6TAafx7k3RNUMXVQHSA6MiB0mj4 JfB0Pt3/0DODXuzjK252wvpAfgl/dPk7UarfMhIpQl9MQbVxR9RDsUc29yXPRWfr2cOv Nw/g== X-Forwarded-Encrypted: i=1; AJvYcCWwifKrUE3ImhYniLx72rjARWCE6x5saOarat5WmWnAynl7TMGh9Hduuajj476K9Xc1FbYNk9eVBP6N7FQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxQujhGO5UY5+IOzU1QfTl/QY0XXYThX16KhQxG0Znih4obSbcx vor/yPxbSd/GYR+yB3OeFKomMKkyJTUEZ2Wo6iFHSr0OJHJqirM2 X-Gm-Gg: ASbGncvlvuZg39XCb3Tu9KFq7fulXZ3gD4Xe/mIFe/eoomp91kNdxyDq90rEd7LF66b Q336xIM2cgDbPovlwqA2blqVOwI8xTJScjBCafH3t0hEjRhMbiN3PEx58QaZ41+/cmKyUpbnINU YlBwaH8ZyRcIuBcPjkiwtRuf+Y8JETMTqqENNuqRz6NNo81rBFtsDefQUAgnamcLRullJOoi/a8 USBuP15FUPiXvnK0trpBJ+3kPlajBQ/UdA5wXD1qQkvEuq4N0xAbsWVPTNAUGM59sg0/j/nc7DT kwctO1XNAmpMAT6g X-Google-Smtp-Source: AGHT+IEUChZgtpBjDlM2swaLKM2R4wrNHUEikBNxyzZVL/fE7uEOs5QujBKNP/q4E4vMj0WslPyUEQ== X-Received: by 2002:a05:6000:401f:b0:385:f7d9:99f5 with SMTP id ffacd0b85a97d-38a87316b7emr13412096f8f.51.1736612150599; Sat, 11 Jan 2025 08:15:50 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38bf65sm7493122f8f.49.2025.01.11.08.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 08:15:50 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler , kernel test robot , Dan Carpenter Subject: [PATCH v3] staging: gpib: Add missing mutex unlock in ni usb driver Date: Sat, 11 Jan 2025 17:15:48 +0100 Message-ID: <20250111161548.27601-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the buffer allocation for return data in ni_usb_write() fails we were returning without unlocking the addressed_transfer_lock. Add the unlock call. This was detected by smatch: New smatch warnings: drivers/staging/gpib/ni_usb/ni_usb_gpib.c:837 ni_usb_write() warn: inconsistent returns '&ni_priv->addressed_transfer_lock'. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202412201550.9NCO57Ye-lkp@intel.com/ Signed-off-by: Dave Penkler --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c index 2c0a0d7e36c6..d0656dc520f5 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -783,8 +783,10 @@ static int ni_usb_write(gpib_board_t *board, uint8_t *buffer, size_t length, } in_data = kmalloc(in_data_length, GFP_KERNEL); - if (!in_data) + if (!in_data) { + mutex_unlock(&ni_priv->addressed_transfer_lock); return -ENOMEM; + } retval = ni_usb_receive_bulk_msg(ni_priv, in_data, in_data_length, &usb_bytes_read, ni_usb_timeout_msecs(board->usec_timeout), 1); -- 2.47.1