From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA17A634 for ; Sat, 11 Jan 2025 17:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736618304; cv=none; b=QRKCsG26d7Zx7A6uy2bHIB44hxabgY0p/OtotI/jGUBNS2C49PvEXGVCoOk1XF5JgYQtupyxxB8iYCzmvaTs/8IGxtn2/4Mk1+seymjfPXGkUCfoQRo9n/eXhnnyWQXKI5+8jO1UV6C0v9qnF9JutThGRGk4m0DR0blzZChwUiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736618304; c=relaxed/simple; bh=uPH34A5PeTGm2khoGXx5N2K2ad3YtvW3zlIXyzLlZ10=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=d4iP5RBvtzyCCmsZ4bXwJR16ysIygZJarxKX3Z1+B+PwLr/fEmzJ2oxwrmiuVyvISnoOsfI5MscVqxqALEs7ClDSq6NZ6ilhUqQHOZzSIEymUGoOTeNxVUs/lT81VPVBbymBFahEt1EyhdKMkCDVXdRGKW4iBMEDEwiHpB/RfG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UmHhATZJ; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UmHhATZJ" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2ef6c56032eso3910187a91.2 for ; Sat, 11 Jan 2025 09:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736618302; x=1737223102; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9tW9A5/McfQ9M3YrOzF/4GOdEHwjolAqdkI3F2CJpwo=; b=UmHhATZJQyLpWaYR7XPZnecB/UEZTUTxF6SMi9J+s6In90rmCy86CDpaDxlK6dhRr9 VTRWzYAB91/MwSVosKF8eotKoyKDzrc2vsZJYWZoAp38DIVHi6F5okEQhSqIHchgmED/ CVe6bqkLPClpOb4lqSU6NJ6adfjz5B9MyNLR7sElw7dJTQ9bI4TEkMJvt+HkNp+7QOOP uVqn2Yiy6yfi+WcWK2phqvLRXVuwUCO01CE/E6dPP2/yBWgezUVFo5f3ic9UT697qijo RTHP4nqxWrYloPa9PuRqGu35oNHXeENtmRqOhMUTf8lkDCbaKkzE2nXDLIFKtoelm7Qo SSxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736618302; x=1737223102; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9tW9A5/McfQ9M3YrOzF/4GOdEHwjolAqdkI3F2CJpwo=; b=wGHvhJu51Nd13YHgYELe8Rlbm+ZFclt2MGF2vhY1LLWSCbDbEeU+NaumV+IAxupD5v GI66qSaSsBzxupwCw/UrWRcEQxMoluV7Zn0Ckm2n4Mqy2iNZMccdL9Gu3kC5SLw+GZhP eTBBLAFU2ZoNiCKC4DAUYEd6etTWdWJNApAtY4lmxugMIBaNR0PUG1TmTvrQUWwJ2Xur 7s+f0O7/u9oMWYVHY5ZAvQfMKZjLVoE+7wYp9Wp73zWK4RFZzDpaPYMSOGwNBGtZcUvC NaYvoEETAh+RH9pph8xaavmtDTReAqASCvOnd7ZDhrZZuYWLhNc32rvaK3RnDSNRRBwl 534A== X-Forwarded-Encrypted: i=1; AJvYcCUP54gn6W3fcYbcoL4WFMwwlR5HfVqrxgDGOcUMXO+08VKlx+Wtqj4lGvAEJc74BV2Yifb7bH0LHv5Ck+c=@vger.kernel.org X-Gm-Message-State: AOJu0YxmAitcU2q0WwG+KtKORdn2E1FZb2M+WZyvv1AOLTT4wRnbnBdJ i6c9xX+57+x3UNhhESywSxc6DQSxjDgx06MS2aBvMfxao8n8c8yg X-Gm-Gg: ASbGncvmrIq24pbIojLyo8DzBku9fzKPKgtOAChLpxJEjM6wHcrVMD8yPE+/ZQ+zYKF z4STNX+/8LACWsf9wtK4o5oMXnqsOGrBUSO1PO1ReRsQy09gECF72zxD5xK6OQpoFmuVOjrzmiv MxOLLEjiu5t8GgnAvOhj+/J3BGg5t6XMI8lx/c8t2s5IqhfzD9BXhc632yU6qYBp1xp0rzzIDNz psLKEMMeRJrnctOa+4Iq/tOh7poOjvUjEjdeMX6iobFOic1ou77Yu4= X-Google-Smtp-Source: AGHT+IFtoTyJtowkwDOXDaJrkkKkDVnuz56XnXf1y37K7iQ8GtbIEE/AvYsAgaQttxc/nL8Zx4a/6w== X-Received: by 2002:a17:90b:520e:b0:2ef:67c2:4030 with SMTP id 98e67ed59e1d1-2f548f4ea90mr21032302a91.27.1736618302181; Sat, 11 Jan 2025 09:58:22 -0800 (PST) Received: from localhost.localdomain ([122.174.69.103]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2f559469fa0sm5091023a91.44.2025.01.11.09.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 09:58:21 -0800 (PST) From: Tanya Agarwal X-Google-Original-From: Tanya Agarwal X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tanya Agarwal The static code analysis tool "Coverity Scan" pointed the following details out for further development considerations: CID 1271215: Dereference null return value (NULL_RETURNS) dereference: Dereferencing pte, which is known to be NULL. Conclusion: Add WARN_ON_ONCE() and NULL check for pte before dereferencing it. Fixes: 8a235efad548 ("Hibernation: Handle DEBUG_PAGEALLOC on x86") Signed-off-by: Tanya Agarwal --- V2: add WARN_ON_ONCE() as suggested by Dave Coverity Link: https://scan5.scan.coverity.com/#/project-view/63683/10063?selectedIssue=1271215 arch/x86/mm/pat/set_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index 95bc50a8541c..8f9d418e6a8c 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -2495,6 +2495,9 @@ bool kernel_page_present(struct page *page) return false; pte = lookup_address((unsigned long)page_address(page), &level); + if (WARN_ON_ONCE(!pte)) + return false; + return (pte_val(*pte) & _PAGE_PRESENT); } -- 2.39.5