From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7C9B22083 for ; Sat, 11 Jan 2025 19:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736622122; cv=none; b=jCMuOfIb9k8vZ0O1JEkoZN//DxZlwyr69JXy1k6PDNtc4sG9QI2wpt6JTzsdblADD7s7PMXUjdUkASIqW37rvgvUBFeVlYqUFzYkvKyGZ0/iU05K0vyJ7UjNCjBFiQ0vo+b5B7TUIeKar4TE9gT2CCroycXIFc6FRevuAmSNBP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736622122; c=relaxed/simple; bh=HQI56t3Xk8Nax12U4SiUvZLhRcgZJYblQDi4Y8nSSCc=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=oIhE9g4r9Ohg3UpS2WwwpW+OwQrfBqSDxRjWSpoj3CP/NBmS/ooY6YQrCq+e6ucC7tx6COZvi3svXStPonhhXFKEHXDjkZxfioGHo3OQdWC2Mejek+ppTXpXR3JzEQviJIHdyMy/UnW2oQ34P9GxdE+CIdNrno1DY+eAVHiuJkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rIj02wUT; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rIj02wUT" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e3fea893dc5so9810540276.1 for ; Sat, 11 Jan 2025 11:02:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736622120; x=1737226920; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=d3A0USpCKcPm+oZI+s4cg9x83Pq7450iM+zG1Swbqbk=; b=rIj02wUTSrD4sjkgtRQoPj3DT8Tatmib/rMJjqxU3VMbZVKFTos4cSK7tzKyU9PsFC BgpUhFl5tHwI8FVHONGKjbU/3vcfxUPwf5z7RrEcTDTh0IYc2zZm8JItyujbcrAYll3D ofUvJT7QLJAnO/bpq9NsGmxat25wpAcVC9sirUq5g2S5HAHxk+l2xdJOS1nJMd1JGKpj Dh5TtBatRh7zTRLpIe2axZX8H0dkR1MRmIPvTgTZgsYw++ZqzoK+e0RWCh5WoDGjqkR9 AVpTQpB1PdEyvs//l1n+g5NNFa3KA7epLCGYsQYEnTJYbp38pjNjn6uCYu1fyE0ruDxH uYpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736622120; x=1737226920; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d3A0USpCKcPm+oZI+s4cg9x83Pq7450iM+zG1Swbqbk=; b=bshZECMCrvo1kLsCTVVhigZA9p4LS7e0f7MPVDYQ9ZF4/qXdocBe68ChfyJykveq9s ynsTaV7zqPdhuzNWSGy7jmSLta3NNtEIIRmtBAs7/982vr419r9ljL+cvJI6hvqYTwzS GzUnqiW/2RetIB3tez8aSZwNpOKOjwwYOQckjfVNBCoGevpnvDIKT1kuSnVqgPlIsV/E 6wHkPRM+PbfGMja5ai196PnSvfhWKdhrL2vvFHB96Qr/0+YKnYUaUy/H15C+JaDo7lDF gEOQfuBdrsQ/+7kv3yWLIoJ6dyMQlG1Y5Y5op6n8hdxeKorEaQYuPe3J2fuq5wRK4C0j JTUg== X-Forwarded-Encrypted: i=1; AJvYcCUVo51LhvAkQKuCwHoG6km7AzsWq8laNrZtgIIA5kU+R9IcrECc7Rn2Gx07dpCU0FMcFF8B7kpEuZ6IU9I=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9bb3lXapXUCTiTnAoDi3J8cLwEMX1BaQyECH9vfnSlVIrglhf pH3cGtJp53dZ7lFZRxeOnpG5kPKb1z4dCNBR4tTzrgY/SbvTnhv/6y/nOcc4ylqFCTmmHblSw6B w5V3GfA== X-Google-Smtp-Source: AGHT+IHLje0K1WCz/tc+8OQHrck+cCflLVO6F1nUn/pT2VCgo83pDFeyqJv+hHmPuifgoVC4IrBhJx2v3ZxQ X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:8807:d7c5:bb27:35fc]) (user=irogers job=sendgmr) by 2002:a0d:d282:0:b0:6ee:6f60:e564 with SMTP id 00721157ae682-6f543f586demr396197b3.3.1736622119780; Sat, 11 Jan 2025 11:01:59 -0800 (PST) Date: Sat, 11 Jan 2025 11:01:33 -0800 Message-Id: <20250111190143.1029906-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 00/10] Move uid filtering to BPF filters From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Hao Ge , James Clark , Howard Chu , Dominique Martinet , Levi Yun , Xu Yang , Tengda Wu , Yang Jihong , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Rather than scanning /proc and skipping PIDs based on their UIDs, use BPF filters for uid filtering. The /proc scanning in thread_map is racy as the PID may exit before the perf_event_open causing perf to abort. BPF UID filters are more robust as they avoid the race. Add a helper for commands that support UID filtering and wire up. Remove the non-BPF UID filtering support. Ian Rogers (10): perf bench evlist-open-close: Reduce scope of 2 variables perf parse-events filter: Use evsel__find_pmu perf target: Separate parse_uid into its own function perf parse-events: Add parse_uid_filter helper perf record: Switch user option to use BPF filter perf top: Switch user option to use BPF filter perf trace: Switch user option to use BPF filter perf bench evlist-open-close: Switch user option to use BPF filter perf target: Remove uid from target perf thread_map: Remove uid options tools/perf/bench/evlist-open-close.c | 76 ++++++++++++--------- tools/perf/builtin-ftrace.c | 1 - tools/perf/builtin-kvm.c | 2 - tools/perf/builtin-record.c | 26 +++---- tools/perf/builtin-stat.c | 4 +- tools/perf/builtin-top.c | 22 +++--- tools/perf/builtin-trace.c | 25 ++++--- tools/perf/tests/backward-ring-buffer.c | 1 - tools/perf/tests/event-times.c | 8 +-- tools/perf/tests/keep-tracking.c | 2 +- tools/perf/tests/mmap-basic.c | 2 +- tools/perf/tests/openat-syscall-all-cpus.c | 2 +- tools/perf/tests/openat-syscall-tp-fields.c | 1 - tools/perf/tests/openat-syscall.c | 2 +- tools/perf/tests/perf-record.c | 1 - tools/perf/tests/perf-time-to-tsc.c | 2 +- tools/perf/tests/switch-tracking.c | 2 +- tools/perf/tests/task-exit.c | 1 - tools/perf/tests/thread-map.c | 2 +- tools/perf/util/bpf-filter.c | 2 +- tools/perf/util/evlist.c | 3 +- tools/perf/util/parse-events.c | 25 ++++--- tools/perf/util/parse-events.h | 1 + tools/perf/util/python.c | 10 +-- tools/perf/util/target.c | 54 ++------------- tools/perf/util/target.h | 15 +--- tools/perf/util/thread_map.c | 32 +-------- tools/perf/util/thread_map.h | 6 +- tools/perf/util/top.c | 4 +- tools/perf/util/top.h | 1 + 30 files changed, 135 insertions(+), 200 deletions(-) -- 2.47.1.613.gc27f4b7a9f-goog