From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55215195B37 for ; Sun, 12 Jan 2025 09:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736675739; cv=none; b=NDSiGunu5ybmt/YmwNOd+5wrmfrFttIkedAVuMd6aX7GFF9GKlzgeN7+33FEZ903It8WiP5628QlE5mYm3YlgS/Tspx9BOsWzedmbRJE5rCl4q2OvjWCgUrq4TCCzUBI21dfSerqC3A5p/uY+KsMlwCLK7lfAKuA3bo5vLE2fSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736675739; c=relaxed/simple; bh=zXt8gel/yANsANDIs5B5Mdvh1QFGb9YfZgkI8pbrooQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N2XPGjF7mFZtlkit/6zOnzd5CKPvUmKidDKpHa8EpRqkeBgrLM80OYQOZYl9pZWZOXN3gyaGikWWZ8v2Wmgxg+ErWwNepwt/T0Pl8FjrHKHcufiAD7GohHJO5GP4jp/Lc4tIJG9VqZRgpMz91X1rjaGSlNFw7RlX0R3FD5KDuks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RSmymUF6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RSmymUF6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736675737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2g0sdh+W5glSkagx457PsA9cI+PMduPyER5qBCP9uo=; b=RSmymUF6Fcz/oWfvtl9yjTwXbKWIXTW3f7wtojem9ilXsmnSmdLlGXjKji/w0Tn0GwaSXA g93f1gjpKdzj96Tcxt+gQrgqwYW2ordQVhQqlZqFV9em7Io5uwOgyi277fn9U4CNTe1Kch q5fWDKeAPfcVXbVIwGHFM8AS9/U+IQU= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-wWzVC07oN3aN_LvY5dfTnQ-1; Sun, 12 Jan 2025 04:55:36 -0500 X-MC-Unique: wWzVC07oN3aN_LvY5dfTnQ-1 X-Mimecast-MFC-AGG-ID: wWzVC07oN3aN_LvY5dfTnQ Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-aa66f6ce6bfso268438966b.2 for ; Sun, 12 Jan 2025 01:55:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736675733; x=1737280533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q2g0sdh+W5glSkagx457PsA9cI+PMduPyER5qBCP9uo=; b=J4NeEO+uYTIloqK/le7muTSurUe2bsMVs7rXUX8hzyrgORB0wypuvxPJxOqAzjQbqd Ek/z+0wsoeqldX1fp4WFNEql4vefdk8uVpaHBCg0qFd/SUVhk6Hq3uflPCui8k9dQqxx YMnGBYCMzsVLJFHC4oXbvTRBhmehTW1gu51uF9GkrI3+z5yLsHEdvIw5NufBtvV+g4+V icggnw7n3DMeyhqXZOzivq61DSin9QlVCZfH0+yMB+LYVJP8NOAMfGbEXUvh5kR5pUNO z5IKWOTxdDlgWc8sTY7itmR9uv+jJrz0q/dahZpifZqk+/sKWkLoHpsN/U/snVPwxCau 8CfQ== X-Gm-Message-State: AOJu0YxSIzgyVBGDnz2j6XdzdUu+LWbu7p+DfG5xe0HxHgDijWigFuU4 pqWeTSpgy6g4zLSy5mg1llrUGZYhct8gfi3FDR9S5rZ+zOr2xgKmDYAiXeV2nBSW8CtJ+bKdfHN LscWjR/n7K/ocz7aVOFbH+sp9MpKuHVVBcOdjH2CJirgKKqzfM3ygrCtl//daiWVbODs+KeEwu2 /TJ0GRpurzd5ic2/l89JaeJNMSEvafNsReuQbxrLSzj+rbrDFA X-Gm-Gg: ASbGncuzczDKQNYItxRcnqa6JfZbanRSuhQq9zrVTjbmJo5Bi51FcT67h7bu4KK7zdB GoUlKZqZOyx+1u8q9wKfylfbnBPsFuRuyduVc/IZlRcfSlFJrVP5cxzKVQhfRBZwyW1HkLd2eEi Xht9iRvuiWNuVwQ/ZQ+xaMAKLUcHKHFYHUi/ArQ/1T6YacoBA49+XN16m+YPmJ2DB+gVOPtkUjg uuIv+LBl1TaEmUOcSHPnxnUVhHbI2NPQZ7iq+IacP59KJnU/TcdchuxyJo= X-Received: by 2002:a17:907:d1b:b0:aac:23f4:f971 with SMTP id a640c23a62f3a-ab2ab70a173mr1753855366b.33.1736675733607; Sun, 12 Jan 2025 01:55:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxwq3cSzmX3Sr/t/JxywDCCAqRMgXJsypEs7qUCiLJx2f+d/bQof+BQSWZDWOMCFQMp6aY9A== X-Received: by 2002:a17:907:d1b:b0:aac:23f4:f971 with SMTP id a640c23a62f3a-ab2ab70a173mr1753853166b.33.1736675733170; Sun, 12 Jan 2025 01:55:33 -0800 (PST) Received: from [192.168.10.3] ([151.62.105.73]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c95647absm352956366b.118.2025.01.12.01.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jan 2025 01:55:31 -0800 (PST) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, linuxppc-dev@lists.ozlabs.org, regressions@lists.linux.dev, Christian Zigotzky , stable@vger.kernel.org Subject: [PATCH 1/5] KVM: e500: always restore irqs Date: Sun, 12 Jan 2025 10:55:23 +0100 Message-ID: <20250112095527.434998-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250112095527.434998-1-pbonzini@redhat.com> References: <20250112095527.434998-1-pbonzini@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If find_linux_pte fails, IRQs will not be restored. This is unlikely to happen in practice since it would have been reported as hanging hosts, but it should of course be fixed anyway. Cc: stable@vger.kernel.org Reported-by: Sean Christopherson Signed-off-by: Paolo Bonzini --- arch/powerpc/kvm/e500_mmu_host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c index e5a145b578a4..6824e8139801 100644 --- a/arch/powerpc/kvm/e500_mmu_host.c +++ b/arch/powerpc/kvm/e500_mmu_host.c @@ -479,7 +479,6 @@ static inline int kvmppc_e500_shadow_map(struct kvmppc_vcpu_e500 *vcpu_e500, if (pte_present(pte)) { wimg = (pte_val(pte) >> PTE_WIMGE_SHIFT) & MAS2_WIMGE_MASK; - local_irq_restore(flags); } else { local_irq_restore(flags); pr_err_ratelimited("%s: pte not present: gfn %lx,pfn %lx\n", @@ -488,8 +487,9 @@ static inline int kvmppc_e500_shadow_map(struct kvmppc_vcpu_e500 *vcpu_e500, goto out; } } + local_irq_restore(flags); + writable = kvmppc_e500_ref_setup(ref, gtlbe, pfn, wimg); - kvmppc_e500_setup_stlbe(&vcpu_e500->vcpu, gtlbe, tsize, ref, gvaddr, stlbe); -- 2.47.1