mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hridesh MG <hridesh699@gmail.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Armin Wolf" <W_Armin@gmx.de>, "Kurt Borja" <kuurtb@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Shuah Khan <skhan@linuxfoundation.org>,
	Hridesh MG <hridesh699@gmail.com>
Subject: [PATCH v4 0/5] platform/x86 acer-wmi: Improve platform profile handling
Date: Mon, 13 Jan 2025 18:44:08 +0530	[thread overview]
Message-ID: <20250113-platform_profile-v4-0-23be0dff19f1@gmail.com> (raw)

This patch improves the platform profile handling for laptops using the
Acer Predator interface by making the following changes - 

1) Using WMI calls to fetch the current platform profile instead of
   directly accessing it from the EC. A new helper function is
   introduced for this purpose.
2) Simplifying the cycling of platform profiles by making use of
   platform_profile_cycle()
3) Using an ACPI bitmap to dynamically set platform_profile_choices to
   better reflect the supported profiles.

The last patch also adds support for the Acer Nitro AN515-58 by adding
it to the quirk list.

Signed-off-by: Hridesh MG <hridesh699@gmail.com>
---
v1->v2:
[1/3]
   - Fixed enum member alignment and reordered them

[2/3]
   - Made use of test_bit to check bitmap values
   - Replaced magic numbers with proper variables

Link to v1: https://lore.kernel.org/platform-driver-x86/20241231140442.10076-1-hridesh699@gmail.com/

v2->v3:
[1/5]
   - Removed a line which was supposed to be in another patch

[3/5] 
   - Moved checking of max performance profile to [4/5]
   - Restored code in profile_set which updates last_non_turbo_profile

Moved the supported profiles patch closer to the end of the series

Link to v2: https://lore.kernel.org/r/20250104-platform_profile-v2-0-b58164718903@gmail.com

---
Changes in v4:
[3/5]
   - last turbo profile is only updated after a successful WMI call

[4/5]
   - most performant profile is set during profile setup 

- Link to v3: https://lore.kernel.org/r/20250108-platform_profile-v3-0-ec3658d9be9c@gmail.com

---
Hridesh MG (5):
      platform/x86: acer-wmi: use WMI calls for platform profile handling
      platform/x86: acer-wmi: use new helper function for setting overclocks
      platform/x86: acer-wmi: simplify platform profile cycling
      platform/x86: acer-wmi: use an ACPI bitmap to set the platform profile choices
      platform/x86: acer-wmi: add support for Acer Nitro AN515-58

 drivers/platform/x86/acer-wmi.c | 315 ++++++++++++++++++++++++++--------------
 1 file changed, 203 insertions(+), 112 deletions(-)
---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250102-platform_profile-fc1e0aaf2900

Best regards,
-- 
Hridesh MG <hridesh699@gmail.com>


             reply	other threads:[~2025-01-13 13:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13 13:14 Hridesh MG [this message]
2025-01-13 13:14 ` [PATCH v4 1/5] platform/x86: acer-wmi: use WMI calls for " Hridesh MG
2025-01-13 13:14 ` [PATCH v4 2/5] platform/x86: acer-wmi: use new helper function for setting overclocks Hridesh MG
2025-01-13 13:14 ` [PATCH v4 3/5] platform/x86: acer-wmi: simplify platform profile cycling Hridesh MG
2025-01-14  3:52   ` Kurt Borja
2025-01-13 13:14 ` [PATCH v4 4/5] platform/x86: acer-wmi: use an ACPI bitmap to set the platform profile choices Hridesh MG
2025-01-14  3:53   ` Kurt Borja
2025-01-13 13:14 ` [PATCH v4 5/5] platform/x86: acer-wmi: add support for Acer Nitro AN515-58 Hridesh MG
2025-01-14  3:55   ` Kurt Borja
2025-01-15 14:37 ` [PATCH v4 0/5] platform/x86 acer-wmi: Improve platform profile handling Ilpo Järvinen
2025-01-15 15:23   ` Hridesh MG
2025-01-15 19:07     ` Armin Wolf
2025-01-15 21:54     ` Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113-platform_profile-v4-0-23be0dff19f1@gmail.com \
    --to=hridesh699@gmail.com \
    --cc=W_Armin@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kuurtb@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®