From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6986EAC6 for ; Mon, 13 Jan 2025 00:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736729802; cv=none; b=mby0E/U27bmh/BOv0o12ecNJ8b2MHc31f55nDwDh5RCIBKyMQ4+Prz4MgP3AbFMmtzYjkGuwZ70XFqw3MnZUf2q7DyB4SS8eibZZ1p5ebRtjf8YZKalnO/67O4197mh/XJOs9fXqGNRLQKxQ7YXN24A70gOpQ8eyTXIEmj5WL0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736729802; c=relaxed/simple; bh=yFdu13TPr6VNxPPYt5rhOWGeVPl9YcsHduFHWKozF2k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=mj/uIIZhBsxLCttI6rEgf3X9aQg33SoHQOVB2FXAgB6T/z27p77Kxpa52iqfpQltvtrxCWXa4WeUlP0ZyDDnlBltcbeVGTcvcZ7EzXuUkIu4UE3iWnIcvS2f65jo+S/6e9QeD55k+Rmy9VB3Rrdeg3m1PFjG7qG3fVRXEC8sOn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WGAW8bDo; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WGAW8bDo" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21628b3fe7dso61229305ad.3 for ; Sun, 12 Jan 2025 16:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736729800; x=1737334600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0V56Sb7sqNGix6HQ1QvO1EkN6QyGEMwBCv4yPDzPp8o=; b=WGAW8bDo9nn01VoYD+rVvhrLychoPKsHEfhHqyammILh5dEA89jD+bt8at2bV+49mT iHez2P7enRMT3x3KR5y2Jmy8qdm/3jYhxmPQQLFSIDHRR5DsnMSCifvx8fEJx4R+lD+F yNkNvujB0l+OLreQz4TkVFmGoFBNQPEdY5X7HRxGjMft8U5p16QVR+62/Sa7iRsU/zYD rTao/3Os0eggHAEFIkKnaC0GZCC1cX3eWRVecfysTELWPwd2poaw0K+bm52cyLuAVa2D CT/HXYT3fXMIUiVPhKbntFOC8Cfa7YgfJKv07Iw3OwsTpWpulos52ZS2FYGkvextIeMw HsFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736729800; x=1737334600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0V56Sb7sqNGix6HQ1QvO1EkN6QyGEMwBCv4yPDzPp8o=; b=UA8BCSOh8o8w9+LtqoXvdr5O+1vy6ZpH1PzOAAZIMlcNJjut6E9BuxygHnDirma042 oH2vyYVWNDVdueyHtYdnsaYJIUn2auMQMWMegkZE5JMgJyKjuIPFyiHAHD1LGCG6Xyth DaRVLS0G7plyeUJInHs3MCSYafaBjxmZOab18VrvgsDSCAVNeJjygql7btvEjeIIx5Al zLHIQbnFzLQyk56H0xt+VSSgUu2w7AQZl3TAJdPwj07mAxQPSl6aKnlPNeFoGH3OfbNo IP3LrCtqjRuLhFYz6DnXYhZaEWNInEuQevvMFEWcxqwL0Ld5P+5PqYGZEarloa4QdiaP px6A== X-Forwarded-Encrypted: i=1; AJvYcCWzDp9TGeSDtY6JMheDI76wtb8FVD0fwCpdsoLOMGrpg1d3tBkMVjMSZeYLWZKKagQHKuAbflaudHFlpfU=@vger.kernel.org X-Gm-Message-State: AOJu0YxiffIyTY/j//Xi6c409zZ2heoM1u2MFyW5BSMHINfzFFMd5UuU fbDrCvhUVChG+ZNjGAa/VKniEx4CMTEmCAL9/weOVXVhPox/X6r4 X-Gm-Gg: ASbGncuEUiPWNJ1e5dxyIrQXjaBtPCS60+J9j/vLlNE9sKlyRFD0mvWIh0vlpeZrft2 8M92vPIhPhAIIdv2nyiO9i1J4tMFG3ue6KCh7r21HVTRoUbDmjB9UThde0nuS7wHXSEOlZKipyL 6R94yICquNs7OOlfQ5OqYeoO471Qw1e9+MZye+TmsWR2JI9WGPbo3U9uXROoL6218WXgx87wkiI sQjdkmCfaSMOimOKtcQTH7l+4I/hJ0XFRxXgzJnzDc4nGc2vVHT7nFJ4lpnKKwUOcU= X-Google-Smtp-Source: AGHT+IGzxYWm0tbkwANQHKte1ZrD6ajm4Ul4JqKrWyhZ4nm01na6Fa/9M40NPrsrME9FDL8oyW0k+A== X-Received: by 2002:a17:902:cecd:b0:215:6995:1ef3 with SMTP id d9443c01a7336-21a83f3469cmr255885615ad.3.1736729800033; Sun, 12 Jan 2025 16:56:40 -0800 (PST) Received: from Barrys-MBP.hub ([118.92.30.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f22d134sm43087125ad.187.2025.01.12.16.56.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 12 Jan 2025 16:56:39 -0800 (PST) From: Barry Song <21cnbao@gmail.com> To: lkp@intel.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, baolin.wang@linux.alibaba.com, bp@alien8.de, catalin.marinas@arm.com, chrisl@kernel.org, dave.hansen@linux.intel.com, david@redhat.com, gshan@redhat.com, hpa@zytor.com, ioworker0@gmail.com, kasong@tencent.com, kirill.shutemov@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mark.rutland@arm.com, mingo@redhat.com, oe-kbuild-all@lists.linux.dev, ryan.roberts@arm.com, shahuang@redhat.com, tglx@linutronix.de, v-songbaohua@oppo.com, wangkefeng.wang@huawei.com, will@kernel.org, x86@kernel.org, ying.huang@intel.com, yosryahmed@google.com, zhengtangquan@oppo.com Subject: Re: [PATCH 2/3] mm: Support tlbbatch flush for a range of PTEs Date: Mon, 13 Jan 2025 13:56:26 +1300 Message-Id: <20250113005626.2290-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <202501061736.FoHcInHJ-lkp@intel.com> References: <202501061736.FoHcInHJ-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Mon, Jan 6, 2025 at 11:08 PM kernel test robot wrote: > > Hi Barry, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Barry-Song/mm-set-folio-swapbacked-iff-folios-are-dirty-in-try_to_unmap_one/20250106-112638 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20250106031711.82855-3-21cnbao%40gmail.com > patch subject: [PATCH 2/3] mm: Support tlbbatch flush for a range of PTEs > config: riscv-randconfig-001-20250106 (https://download.01.org/0day-ci/archive/20250106/202501061736.FoHcInHJ-lkp@intel.com/config) > compiler: riscv64-linux-gcc (GCC) 14.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501061736.FoHcInHJ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202501061736.FoHcInHJ-lkp@intel.com/ > Sorry. My bad, does the below diff fix the build? diff --git a/arch/riscv/include/asm/tlbflush.h b/arch/riscv/include/asm/tlbflush.h index 72e559934952..7f3ea687ce33 100644 --- a/arch/riscv/include/asm/tlbflush.h +++ b/arch/riscv/include/asm/tlbflush.h @@ -61,7 +61,8 @@ void flush_pmd_tlb_range(struct vm_area_struct *vma, unsigned long start, bool arch_tlbbatch_should_defer(struct mm_struct *mm); void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, struct mm_struct *mm, - unsigned long uaddr); + unsigned long uaddr, + unsigned long size); void arch_flush_tlb_batched_pending(struct mm_struct *mm); void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch); diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c index 9b6e86ce3867..aeda64a36d50 100644 --- a/arch/riscv/mm/tlbflush.c +++ b/arch/riscv/mm/tlbflush.c @@ -187,7 +187,8 @@ bool arch_tlbbatch_should_defer(struct mm_struct *mm) void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, struct mm_struct *mm, - unsigned long uaddr) + unsigned long uaddr, + unsigned long size) { cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm)); } > All errors (new ones prefixed by >>): > > mm/rmap.c: In function 'set_tlb_ubc_flush_pending': > >> mm/rmap.c:685:9: error: too many arguments to function 'arch_tlbbatch_add_pending' > 685 | arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from arch/riscv/include/asm/pgtable.h:113, > from include/linux/pgtable.h:6, > from include/linux/mm.h:30, > from mm/rmap.c:55: > arch/riscv/include/asm/tlbflush.h:62:6: note: declared here > 62 | void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +/arch_tlbbatch_add_pending +685 mm/rmap.c > > 663 > 664 /* > 665 * Bits 0-14 of mm->tlb_flush_batched record pending generations. > 666 * Bits 16-30 of mm->tlb_flush_batched bit record flushed generations. > 667 */ > 668 #define TLB_FLUSH_BATCH_FLUSHED_SHIFT 16 > 669 #define TLB_FLUSH_BATCH_PENDING_MASK \ > 670 ((1 << (TLB_FLUSH_BATCH_FLUSHED_SHIFT - 1)) - 1) > 671 #define TLB_FLUSH_BATCH_PENDING_LARGE \ > 672 (TLB_FLUSH_BATCH_PENDING_MASK / 2) > 673 > 674 static void set_tlb_ubc_flush_pending(struct mm_struct *mm, pte_t pteval, > 675 unsigned long uaddr, > 676 unsigned long size) > 677 { > 678 struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; > 679 int batch; > 680 bool writable = pte_dirty(pteval); > 681 > 682 if (!pte_accessible(mm, pteval)) > 683 return; > 684 > > 685 arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr, size); > 686 tlb_ubc->flush_required = true; > 687 > 688 /* > 689 * Ensure compiler does not re-order the setting of tlb_flush_batched > 690 * before the PTE is cleared. > 691 */ > 692 barrier(); > 693 batch = atomic_read(&mm->tlb_flush_batched); > 694 retry: > 695 if ((batch & TLB_FLUSH_BATCH_PENDING_MASK) > TLB_FLUSH_BATCH_PENDING_LARGE) { > 696 /* > 697 * Prevent `pending' from catching up with `flushed' because of > 698 * overflow. Reset `pending' and `flushed' to be 1 and 0 if > 699 * `pending' becomes large. > 700 */ > 701 if (!atomic_try_cmpxchg(&mm->tlb_flush_batched, &batch, 1)) > 702 goto retry; > 703 } else { > 704 atomic_inc(&mm->tlb_flush_batched); > 705 } > 706 > 707 /* > 708 * If the PTE was dirty then it's best to assume it's writable. The > 709 * caller must use try_to_unmap_flush_dirty() or try_to_unmap_flush() > 710 * before the page is queued for IO. > 711 */ > 712 if (writable) > 713 tlb_ubc->writable = true; > 714 } > 715 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki