From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93B7584A5B for ; Mon, 13 Jan 2025 16:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736784029; cv=none; b=ZWi6caSyv4YDENWwb1IYrfU/holSIivPjn98UtaO5aBWpmNV8K/Yg3pDShLA2BgGxwWnO2lgLSyp9Lg526sXD2mPf6GbQfhoHP3G1OjcYg8VTIQZLjxctRjnOsJEkSG7zzfM2A+zpBxNjgPJGtbiR5+DBjxlBDABDQJVuV5uJIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736784029; c=relaxed/simple; bh=a/uBemEj9PszXi3HK4tvKrfiV+5Lk8UXkW7mGrTPlz8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pRTPi5rCiaBoNtJ7fbTvlYVLH2CYGolxa4MLo/N7JR8j8kTYhRhymmtOeROBKw3KI6qxyuQmB+MoXee5nAJYTpLBWpGzLn0ReoD2cgWwbeUxrsIsllWvF8M9sGycdYW9FCY6C2e37rOAStaRXpwuh4hMdMveCCsZStge9RDX8g0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=njCx3jaO; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="njCx3jaO" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ab2e308a99bso602840566b.1 for ; Mon, 13 Jan 2025 08:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736784026; x=1737388826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MCZRk8F5oIr78QIJHIsQc5tZNTNUkD+BR9QkiJxVXFM=; b=njCx3jaOuxhpeepjPtC7dkqZuqxFobEeoH78k/NECoS5z0SOLfSFkkesEhWDqsr2M/ ItpYECG28Ehjorwp365pn6UtHnun9eNg5eP8HlzU5untlReg/8OMF75VT2S7kFwzL3aJ yePQ9YGjEcrqmAFky2YSrtxUnlDz5A3vZnGqkx5gkxfoy/s+8GNAiOnZ8wd2jC/cJMCL 96JUZpwy1cMBzyCV55imeJOhN36NUVPCXbnFmB/5uinjeud8N+gbHkd46Cd54Km9cqva PH4uutEFKmfA9NJMcQxZaiDrjcPDalp5C6kbVVCyj4fVrIq1Z1PwwR+eklhL5UiZ+N54 ZjCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736784026; x=1737388826; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MCZRk8F5oIr78QIJHIsQc5tZNTNUkD+BR9QkiJxVXFM=; b=Y7xjAt0BMcEd+LXu45hquPt+qp/UZ0bjhr0oB7wqxfwHfHGs9UyMyaV1QtMWo0M1Ei Ug/1Hm6trINnhAbRkVkD5Ajx+Ih63WzNCBdyvTGu/YTcIOvzbPwgSTu2JbFoOOhsHdGw SiE+jeVLdv4j8uUIKozJrhOzc7Ko8sVPh2LT1w6BgmpBlDLOKP3fW68RshuwWfx+y3rN BTiNcGHaglRraXo+I7G1Y3b4FPTPCJNPY/1vwU4In0S+QO0O1zjrOWMF26Ry3J0lNldy FemH+VF/hch0llqNb1g/U4Ty3ZI7KguRMsS734D7SlJAzzbF1fqh0pWJ5KI7I8AgnJnD IdXQ== X-Forwarded-Encrypted: i=1; AJvYcCXc3ccOc0sZXaoyP/KleCdHv0AXCE6zgSEipuTZy77fsZ2QWHnQNneVDD77D5Jpr/u8XPmkIk1afWs7PYQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn8nqrJNMnF9L3YlE4glsnCjE3Rv70vla1k2cJ0wnGi32YNn/e ahzEPEcy3yHS3eLT9IN5PTDesGFdzG0iCymUMFYk/Gzn+lfaGAT5 X-Gm-Gg: ASbGncs4FGeiM8NZk4j7ATfra81AznjMZcXxc//NWLtlr67UTW+0gJEBRBkZTZT/vj9 n/iym1GwvJksXiWptAkQsgDd/meHD6JuE0i12/xfTZMNF85id9DwDbewVnX7KoVQz0TYs3W4Ai+ rBhInXzR5rmYvbSRcEiD9IF4zCKyxNUcwbro2GaYQunE5yNiku6eFnU070udnxyy1K3DN1/Ie2g bI5lOv5c95bpdir0UcNv/kZsiDUk3XNXGlEv5jcZ3E8+b2zknryCNX5wzCK7So/hw== X-Google-Smtp-Source: AGHT+IFDO+ZRixaurSV/iVvKo0ypX+0BAPSjuVqMvAjxKSSRCFaUBi1bVJmJGDlKs47SyO7rITjjMQ== X-Received: by 2002:a17:907:1c1a:b0:aa6:bcc2:3f02 with SMTP id a640c23a62f3a-ab2c3d341b6mr1737149866b.29.1736784025431; Mon, 13 Jan 2025 08:00:25 -0800 (PST) Received: from localhost.localdomain ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c956472fsm515944166b.119.2025.01.13.08.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 08:00:24 -0800 (PST) From: Uros Bizjak To: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Dennis Zhou , Tejun Heo , Christoph Lameter , "Peter Zijlstra (Intel)" Subject: [PATCH 1/2] x86/locking: Use ALT_OUTPUT_SP() for percpu_{,try_}cmpxchg{64,128}_op() Date: Mon, 13 Jan 2025 16:59:35 +0100 Message-ID: <20250113160017.17668-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit percpu_{,try_}cmpxchg{64,128}() macros use CALL instruction inside asm statement in one of their alternatives. Use ALT_OUTPUT_SP() macro to add required dependence on %esp register. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: Dennis Zhou Cc: Tejun Heo Cc: Christoph Lameter Cc: "Peter Zijlstra (Intel)" --- arch/x86/include/asm/percpu.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h index e525cd85f999..0ab991fba7de 100644 --- a/arch/x86/include/asm/percpu.h +++ b/arch/x86/include/asm/percpu.h @@ -350,9 +350,9 @@ do { \ \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg8b_emu", \ "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \ - : [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -381,10 +381,10 @@ do { \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg8b_emu", \ "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \ CC_SET(z) \ - : CC_OUT(z) (success), \ - [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP(CC_OUT(z) (success), \ + [var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -421,9 +421,9 @@ do { \ \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg16b_emu", \ "cmpxchg16b " __percpu_arg([var]), X86_FEATURE_CX16) \ - : [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -452,10 +452,10 @@ do { \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg16b_emu", \ "cmpxchg16b " __percpu_arg([var]), X86_FEATURE_CX16) \ CC_SET(z) \ - : CC_OUT(z) (success), \ - [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP(CC_OUT(z) (success), \ + [var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ -- 2.42.0