From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B3C24022B for ; Mon, 13 Jan 2025 17:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790982; cv=none; b=A2LoFSwXjC3zexMOFD52flmE2iOl+VwmZF51PDg6Tng7uuHNP9Ix30Gzrbnb5ifHM0bZSoWoMI4oNtdKnESLq0Uy/0cwMJXYwHXV9Gg40Yi3S6mvD9ZYo258YaccIjoJs305lX7lxwvAEj9Tje4xi7Iq6Ientu0cSYI7ehJbGZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790982; c=relaxed/simple; bh=GH+Jeg4MtzMd45s+ZhdI+LRrChBOCIVGzTxoCHHJTO4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R3m6SOLvC3JqkGbYOV2LM71xK8LrAgNf2jPTzESIkj88oYlczNysmwJ5TSWONnBPWKUyLJQyIit04KWwDbOHvzJAJwgH1dxmDTjAmTOySANyctHif40r11GHjWuKezPK+np5Bbyogyxs/o3d00wtc3KYCxLoLIq6Jv8zwqU80xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=fail (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=D2FpLuy2 reason="signature verification failed"; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="D2FpLuy2" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 2069240E016C; Mon, 13 Jan 2025 17:56:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=fail (4096-bit key) reason="fail (body has been altered)" header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Zj35Ok60i1MX; Mon, 13 Jan 2025 17:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1736790971; bh=UgR0KiVRN7MQS9GGJXwvL6wDL8DE2ydGxJisgaJyguk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D2FpLuy2lUl8msHV1xaUNSbbaNZS5YoDJAQGFriSIeK+g0hw7cMC4EUBJk4ExwhKc vtBCtwQJYmVY/4vzB41RZxncXP55jNn6ZoAS/NUu7gBOgi7WbG4Rdgwe6ggWNc6Gly 0k4Pl9XEhbzbJTur6F54PyW9iHn87iA6G6vFXi6oOeDAoPFKzOagFNtfWsW5+QMEgp 0JacBq3dEagNTxDhqvPrdUFNwaat1IwqkV9hquXN7JTCbiYnL8oBGAPE+xBpjb3Tfv pl1JhiqvxdyHtZlc+PgDr/86+5+Az/p3pAtigmIvCLMP0g5oAgGgm++93sfFBE1FG3 PRstPw9Hw0QKU18WA2+7L6CaU+ZUhvQSKZSuWfmFuOZG07FJhf3HW6WvPZlBvFLE4V q2oU3DM0GQSHa/PjVPD0r4x9i1D47tuFHlD5OJpJCT6CPPXmoRX6/M2mxAd5YVxCfj 3grcg6P5g7iCwWlkxCae/F3FX34BRxnAFdWg2lTf4TeZAJVONWIE1QhEWSEJLzwpH9 L4TFWFxIZAyEmwM9rZCipO0MHDiLrV2DMvGVKEwdv8IWFd6fQWss2nNM7/Er4VLR8I XGZau8bo7Bnq9RnScflCbOxWnV2RnnlqOiAl8xVeNrhxI4YOZLjWETbzXzhYn9DUty 1ILzt+nI4581LBBkynQSp75M= Received: from zn.tnic (pd953008e.dip0.t-ipconnect.de [217.83.0.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BF5CC40E0169; Mon, 13 Jan 2025 17:55:58 +0000 (UTC) Date: Mon, 13 Jan 2025 18:55:52 +0100 From: Borislav Petkov To: Mike Rapoport , Andrew Morton , x86@kernel.org Cc: Juergen Gross , linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH] x86/execmem: fix ROX cache usage in Xen PV guests Message-ID: <20250113175552.GGZ4VTqHVuecaEhsax@fat_crate.local> References: <20250103065631.26459-1-jgross@suse.com> <20250103130044.GEZ3fffHPSmJ3ngPXn@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable On Fri, Jan 10, 2025 at 12:02:38PM +0200, Mike Rapoport wrote: > On Fri, Jan 03, 2025 at 02:00:44PM +0100, Borislav Petkov wrote: > > Adding the author in Fixes to Cc >=20 > Thanks, Boris! > =20 > > On Fri, Jan 03, 2025 at 07:56:31AM +0100, Juergen Gross wrote: > > > The recently introduced ROX cache for modules is assuming large pag= e > > > support in 64-bit mode without testing the related feature bit. Thi= s > > > results in breakage when running as a Xen PV guest, as in this mode > > > large pages are not supported. >=20 > The ROX cache does not assume support for large pages, it just had a bu= g > when dealing with base pages and the patch below should fix it. >=20 > Restricting ROX cache only for configurations that support large pages > makes sense on it's own because there's no real benefit from the cache = on > such systems, but it does not fix the issue but rather covers it up. >=20 > diff --git a/mm/execmem.c b/mm/execmem.c > index be6b234c032e..0090a6f422aa 100644 > --- a/mm/execmem.c > +++ b/mm/execmem.c > @@ -266,6 +266,7 @@ static int execmem_cache_populate(struct execmem_ra= nge *range, size_t size) > unsigned long vm_flags =3D VM_ALLOW_HUGE_VMAP; > struct execmem_area *area; > unsigned long start, end; > + unsigned int page_shift; > struct vm_struct *vm; > size_t alloc_size; > int err =3D -ENOMEM; > @@ -296,8 +297,9 @@ static int execmem_cache_populate(struct execmem_ra= nge *range, size_t size) > if (err) > goto err_free_mem; > =20 > + page_shift =3D get_vm_area_page_order(vm) + PAGE_SHIFT; > err =3D vmap_pages_range_noflush(start, end, range->pgprot, vm->pages= , > - PMD_SHIFT); > + page_shift); > if (err) > goto err_free_mem; > =20 > --=20 So this patch is still being discussed here. akpm has already picked up the original fix from J=C3=BCrgen: 59f59108475e ("x86/execmem: fix ROX cache usage in Xen PV guests") and the patch is already in Linus' tree. How much of a fiasco is this execmem thing going to become? Andrew, is there any chance we can synchronize on what you pick up for arch/x86/ or? --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette