From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFCC414A4CC for ; Tue, 14 Jan 2025 17:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736876901; cv=none; b=tdzPFBK9W5NEjMUjXFgvTzlRZc7NUyCCl6jBglmxxLT0SjgFi2xrtVDSsRCWqN/tQ/ssTcqS5+3MaGSqb8wMueXz/a2L9LT7Pn7V5PZXp34yCI6gDGFwf+I19vw8vEcz4AOP97skm4H4vccjw260Vs79bSbop3iT4AfqQM4pDFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736876901; c=relaxed/simple; bh=ReEvutLUNBrKUqbYwUgL4AaEgaDl+0Mo8nAOAWGVGQk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jSmiAtAe5WdqSp+greocGl35qdqRAIgxu+ksDCrUgRxPPxzHhtZf7mLa0bPNSQo7gx7o9Njr6fNftoSDRHdpMLvX1ymNzZ+RGsqFoh7m73Tb8/zwZkOaz/UDImkTNd46GxeX46S9P9ZyqqSWWJkb1LM4fVgI3DINgP9R/RfBHBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RR5ANG8W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RR5ANG8W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F322AC4CEDD; Tue, 14 Jan 2025 17:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736876901; bh=ReEvutLUNBrKUqbYwUgL4AaEgaDl+0Mo8nAOAWGVGQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RR5ANG8WOfVOM8zc7wSfqgfR/XxhjJyde/DAAb1oi5hOHP59HsLCEkJlxLT9sfYqo 6fL+kvvzAYTSV0zwx1OGskkvxGFrP80jPH3iJHDPy9yIx2kbvE0leO2utqRI0eA5dR ujfBlFocuM2lIrsSN8LyTenzmYvT6JiN8GEGJII16FAki+xF8u9JPlSq4nTC+kgX/r 8nx9KIeVFf2+PjEIal8zZE0OjVst8T9jxvt67KX/ikhioVT6ReuplIo20ebIMatko4 axqWWbw4tZu8pdfYvsG472M2tX6+zVDnb72c4lBA/tu9JNSlxY5zU2SObKpOeIQYFG 4hu9D7yyQWSVA== Date: Tue, 14 Jan 2025 18:48:18 +0100 From: Maxime Ripard To: Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.baryshkov@linaro.org Subject: Re: [PATCH v2 2/2] drm/tests: hdmi: Add connector disablement test Message-ID: <20250114-voracious-melodic-partridge-60aebd@houat> References: <20250110084821.3239518-1-victor.liu@nxp.com> <20250110084821.3239518-3-victor.liu@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="nn6bgf2xstftnujg" Content-Disposition: inline In-Reply-To: <20250110084821.3239518-3-victor.liu@nxp.com> --nn6bgf2xstftnujg Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 2/2] drm/tests: hdmi: Add connector disablement test MIME-Version: 1.0 On Fri, Jan 10, 2025 at 04:48:21PM +0800, Liu Ying wrote: > Atomic check should succeed when disabling a connector. Add a test > case drm_test_check_disabling_connector() to make sure of this. >=20 > Suggested-by: Dmitry Baryshkov > Signed-off-by: Liu Ying > --- > v2: > * New patch to add the test case. (Dmitry) >=20 > .../drm/tests/drm_hdmi_state_helper_test.c | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) >=20 > diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers= /gpu/drm/tests/drm_hdmi_state_helper_test.c > index c3b693bb966f..8f7a39c9a1bb 100644 > --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c > @@ -1568,6 +1568,57 @@ static void drm_test_check_output_bpc_format_displ= ay_8bpc_only(struct kunit *tes > KUNIT_EXPECT_EQ(test, conn_state->hdmi.output_format, HDMI_COLORSPACE_R= GB); > } > =20 > +/* Test that atomic check succeeds when disabling a connector. */ > +static void drm_test_check_disabling_connector(struct kunit *test) > +{ > + struct drm_atomic_helper_connector_hdmi_priv *priv; > + struct drm_modeset_acquire_ctx *ctx; > + struct drm_connector_state *conn_state; > + struct drm_crtc_state *crtc_state; > + struct drm_atomic_state *state; > + struct drm_display_mode *preferred; > + struct drm_connector *conn; > + struct drm_device *drm; > + struct drm_crtc *crtc; > + int ret; > + > + priv =3D drm_kunit_helper_connector_hdmi_init(test, > + BIT(HDMI_COLORSPACE_RGB), > + 8); > + KUNIT_ASSERT_NOT_NULL(test, priv); > + > + ctx =3D drm_kunit_helper_acquire_ctx_alloc(test); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); > + > + conn =3D &priv->connector; > + preferred =3D find_preferred_mode(conn); > + KUNIT_ASSERT_NOT_NULL(test, preferred); > + > + drm =3D &priv->drm; > + crtc =3D priv->crtc; > + ret =3D light_up_connector(test, drm, crtc, conn, preferred, ctx); > + KUNIT_ASSERT_EQ(test, ret, 0); > + > + state =3D drm_kunit_helper_atomic_state_alloc(test, drm, ctx); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state); > + > + crtc_state =3D drm_atomic_get_crtc_state(state, crtc); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state); > + > + crtc_state->active =3D false; > + ret =3D drm_atomic_set_mode_for_crtc(crtc_state, NULL); > + KUNIT_EXPECT_EQ(test, ret, 0); > + > + conn_state =3D drm_atomic_get_connector_state(state, conn); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state); > + > + ret =3D drm_atomic_set_crtc_for_connector(conn_state, NULL); > + KUNIT_EXPECT_EQ(test, ret, 0); > + > + ret =3D drm_atomic_check_only(state); > + KUNIT_ASSERT_EQ(test, ret, 0); > +} > + > static struct kunit_case drm_atomic_helper_connector_hdmi_check_tests[] = =3D { > KUNIT_CASE(drm_test_check_broadcast_rgb_auto_cea_mode), > KUNIT_CASE(drm_test_check_broadcast_rgb_auto_cea_mode_vic_1), > @@ -1605,6 +1656,7 @@ static struct kunit_case drm_atomic_helper_connecto= r_hdmi_check_tests[] =3D { > * picked up aside from changing the BPC or mode which would > * already trigger a mode change. > */ > + KUNIT_CASE(drm_test_check_disabling_connector), I've changed slightly that test name (s/disabling/disable/) to make it consistent with the rest when applying, and ordered it alphabetically. Thanks! Maxime --nn6bgf2xstftnujg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ4ajYgAKCRAnX84Zoj2+ dlKcAX4yYBJRr1MygPbb1tTv3FnEIhsIDeA8CXtTVPYu0zrgUxVZKPt5E0lFMslK f+WbU30BgLsW9m8Ez4uH+lBAsNtVHpTOVco/40WqSKVULimx0N4cJBHy9OPdYNpU lp+d+UgDJA== =5uFn -----END PGP SIGNATURE----- --nn6bgf2xstftnujg--