From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDBB71632FB for ; Wed, 15 Jan 2025 16:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736960149; cv=none; b=WG6kYPBjiSqRMWn+B7jXc9HD2cEcMMlj1h07sPZyw3iEJnCVgNIvao/BLpuQ8txAUFkEqu9r7gm1E57qq5e1oi2F9UkTY20u2a0f5vmbLHlVhDgistPtT11kt5EcRoBOjQMFvghkrMcaGyv0gnRVbny9Uua7HljTSd+IRVufBSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736960149; c=relaxed/simple; bh=s0RYUsI9GuIYcld2DxebLf3JpxuLGsW/B03O64UrCl4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zqj//sycOEoEpW5fggSafXdhAtSHzvqhB+c/XxnQbQ7q0e4op/u5ixNQjYkRH9Mp3UdXnrxOj/NPShqn38UeMBoKMVxxmamtTkuTGw6a+8WLrXO2lrRU/Gu1Jf+F+IN+6w5MK0GvchadALIUCh1gWSVRPGBFBjiK/OL3uNpum5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iMjHE87q; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iMjHE87q" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21631789fcdso14486445ad.1 for ; Wed, 15 Jan 2025 08:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736960147; x=1737564947; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iLEMpPTOfcGIE0TnoMMm2t6EP058ZQmyPf3B3ef9ims=; b=iMjHE87qcjMC1g9nbgSUIwmkio5PDNi43BylUDfs0fFT4JUinp5GUEfglICX6d1LRH iBVfKVJu/iojTA4uTFWay4UvsFob6U90cKMUloEObQNYQRkD51OMBsKIHspkI5ahXwzF q7QMQJJ+SENZEHI70//HMFArQ4x3+UBy+q/n4JMkWXvNYH5Ib/7Kl6+v3bnaYQclYqqO 7UPKCuH2RF3Rs5Il0wEPoEUVLpy0aJM1oi99XTjZ86cjI/WmNtz37X4nd75MwqwONT0/ xW3A7OuLj37xFDuRnrA7nNRyTYUVp+MSR5gPJL3GUJOCdNU02YChFXuX2TjwsRtFv+2T cgJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736960147; x=1737564947; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iLEMpPTOfcGIE0TnoMMm2t6EP058ZQmyPf3B3ef9ims=; b=jt0MpD1paVFkTp69giQl8Q+jk7IMQl7GiDwuJXJoZuSQaRpWqifOLwPvJ5cl49MQr+ IqktO+iJsoT/eyf4C5pQptzGuMVwBNLvP4z6yNWd1u3Kix8eceqjDfKDyquXpIaw7i4P 9EeT+aK81wIc+2vRH4fFv+7ybttM9JByPbTsiaJTHMxq6b/8r8Rc5HI0XbYalwxVv+Ye Y3XWRac0lBm0t6MsZ8WjwLQHH3KHYp0Nt2QnoXd2zOkt9qTXxQAumF5tzVKsWtT+3IxQ HbKO7VOjO9cEo+u/+nfGQnNC8E+Hk2/8ibXuBn9bBOlfC2cuEsIyE52CINS66E6ByChw TfOA== X-Forwarded-Encrypted: i=1; AJvYcCV/c3JccVWOb1kO+WI1I9IraBLPI4xEbVAcXqDcoUWb82bcITZJnlxzW/rICPnaF/PrC4r62iISyNQHR1Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzJNBphxUIQb/V5f/2u1fV2uBjbJxd6opCUOvSJeR0Vt+fp0xJc 6pQ7TMzbg38lyOubQ77kCMsChW+K5Sy7p1FWkvI2VPYHEkcN7+nR/lwaqWEoAg== X-Gm-Gg: ASbGnctqWs3pf2cpczRtpKBl5MUq6nRTy01ulCgzsbwCQXRdK3b/Z9elgkeQptu9TER FSo70LBxCksQ5zGNSw1uuN9NLIUzuZWJ9jEw8jL0X4aP8WR/jtXuDc/OIZqR2n8i7GqlgkE086B EZA2qER8QQw4/8AGYzE/BOoop7ZQorQdQvDd8bMkXE4dJNVn1CIlkz2FcUOTvy0N9zESg9P7H57 bf23z1EqpYZ8rDaehKqYPvip2CsMvDMVCXFdtm5/Qe8Vd7xu0OcaXMa99ECDIZzw0I= X-Google-Smtp-Source: AGHT+IH7JbYkc+q9KET2yNRSdVgBxZjaXkn6cyEXwedR9a4FGw68GsofruEhVKa2oHfSVEZNAWMULw== X-Received: by 2002:a05:6a20:d488:b0:1e1:f88a:3106 with SMTP id adf61e73a8af0-1eb0250632fmr5545770637.7.1736960146987; Wed, 15 Jan 2025 08:55:46 -0800 (PST) Received: from thinkpad ([120.60.139.68]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a31d4d6b477sm9940172a12.61.2025.01.15.08.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 08:55:44 -0800 (PST) Date: Wed, 15 Jan 2025 22:25:30 +0530 From: Manivannan Sadhasivam To: Shradha Todi Cc: 'Fan Ni' , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, Jonathan.Cameron@huawei.com, a.manzanares@samsung.com, pankaj.dubey@samsung.com, quic_nitegupt@quicinc.com, quic_krichai@quicinc.com, gost.dev@samsung.com Subject: Re: [PATCH v4 2/2] PCI: dwc: Add debugfs based RASDES support in DWC Message-ID: <20250115165530.kgzxax7fctguu5x2@thinkpad> References: <20241206074456.17401-1-shradha.t@samsung.com> <20241206074456.17401-3-shradha.t@samsung.com> <0d6001db4bbd$06de0f80$149a2e80$@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0d6001db4bbd$06de0f80$149a2e80$@samsung.com> On Wed, Dec 11, 2024 at 04:38:34PM +0530, Shradha Todi wrote: > > > > -----Original Message----- > > From: Fan Ni > > Sent: 10 December 2024 03:59 > > To: Shradha Todi > > Cc: linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org; manivannan.sadhasivam@linaro.org; lpieralisi@kernel.org; > > kw@linux.com; robh@kernel.org; bhelgaas@google.com; jingoohan1@gmail.com; Jonathan.Cameron@huawei.com; > > a.manzanares@samsung.com; pankaj.dubey@samsung.com; quic_nitegupt@quicinc.com; quic_krichai@quicinc.com; > > gost.dev@samsung.com > > Subject: Re: [PATCH v4 2/2] PCI: dwc: Add debugfs based RASDES support in DWC > > > > On Fri, Dec 06, 2024 at 01:14:56PM +0530, Shradha Todi wrote: > > > Add support to use the RASDES feature of DesignWare PCIe controller > > > using debugfs entries. > > > > > > RASDES is a vendor specific extended PCIe capability which reads the > > > current hardware internal state of PCIe device. Following primary > > > features are provided to userspace via debugfs: > > > - Debug registers > > > - Error injection > > > - Statistical counters > > > > I think this patch can break into several to make it easier to review. > > For example, it can be divided by the three features list above, with the documentation change coming last as a > separate > > patch. > > > > Sure Fan. I have no issues in breaking this into smaller patches. Though I think the documentation > should go along with the implementation rather than a separate patch? > Anyway, I'll wait for some time for further review comments or if anyone has any objection to > splitting the patches before going for the next revision. > I don't mind splitting the patches, but as you said, the documentation should go in the same patch that adds driver support. - Mani -- மணிவண்ணன் சதாசிவம்