From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DEC199EA3 for ; Wed, 15 Jan 2025 17:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736962823; cv=none; b=EJ47bG5wiPF4yTlqC+2CKZ+cfw4K9YVW+2esEzH6cOgl//giJJGZAdkBCsp8LJxNUFPePalkm//W/gdWIpTmOIdIUZF2YegW5RWJS4Q4ZDu0m2/4DU3Zlt4FtDrWqUfUl3XrEu2pP2y+I9ZxR4cNhDkm5QWxDPuygwF0LhoGj4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736962823; c=relaxed/simple; bh=hnJW2xxqvw9O1y9gRRJv7NL1EReH1KHCRWvku2UFNrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QihU8O8rcI9D8EcVAjjEeFsg9duegDm/ecfpQLUIVa6zizd6YetQtDjo2ewSOmwHSyQEPiqUval2Cn/yuSDB0Ir94Mp+SJ6hx7yQzBDLJV+hOrBU3lZ0/SlMjDWJxMtHCkx8vE/tnasTs1v0CtEH5VCNnSfdL1KrYh+QwNNVU00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uMPJMehh; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uMPJMehh" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2163b0c09afso132302315ad.0 for ; Wed, 15 Jan 2025 09:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736962820; x=1737567620; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RSM2HZluyONZrn3gXP7oqGlR+tWUwLkG4z/EG2USxK4=; b=uMPJMehh1YwBIvlT92ePO3aLrA8+UDNzmJhxd53UfHghpPd93+NOYZiDzgaXH6sTVR QSVG0k9ys0DFmObXkSTVeLHUgmDu6ys46MjrmOiMj7tH3AZHJ27UDdbZ7H2hsekUrD26 +h886wgyOT+8BkJFufUUvt+eNSI0Env67bdUJer099kK6jDqSldBbNWzAROL/c8pL3ua jstwh4YTKglrys8B2v8uqO1mtGKCrkmpc/aMvzjg1x56WbjA35P8ddECM/LnJgMNFTuH H6GHfBLg0AJicqkMECb6TTExQwQ1msxLIIwhpJVscFV71z4OGc90GilaVEA2EP8wN+nv S57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736962820; x=1737567620; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RSM2HZluyONZrn3gXP7oqGlR+tWUwLkG4z/EG2USxK4=; b=B22aGl5H+73CxlRVJD74dBRzjI0GeAMrYb3Weqi7Dwctzp7jMot25RyVVda991yYES b+0M5vbRnhyvdcyCwly0p6BUcznmmOUX2nZkng6J1HRlTaOu/ogh3nR52jL9IsXM5fnc O/P7FoRPIjXJ7Qy8E08rPf/XqzIWbozdHTYnFjpQcsfm8RvgBGZ2zaTVkMge3sdaOUVh 3uhDaSYq9xLUyr+dvZBxlL5pqoW5X12k5sfRkmGRIwq0nXlZRmuSqNDe2tp3Pc6z5975 PRDssON72o7q5znTUvQDuwwiZOQjHOQscvEozkZPfNOqpnkatlovpt6QDoWtINuwJEBr QTyA== X-Forwarded-Encrypted: i=1; AJvYcCWKE5A1YaK63qe0rlYgGrsckmMDrRTDDWUrwr3o0Qxlz4NUfEml+NqujycnZ/virprRklc1ww05kl8oeT0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1GOZyFTwsU1FIZXXgMNZWtworNsP+OpGDiMUwQxy/t9Q3jLSJ Rd1ij3C0yTs8MkZsiDKgROjlPea5AfN6h3vCKQOhuI6/kOoaW9+E9ZC9BfjLuw== X-Gm-Gg: ASbGncsG/z1GN1Fp0Sw89rT+pRQMXEhgouJpbRZfsEUw8YhEo+QJ/9uRagee8+TifOA lRs0iDd8zh5sBW/tHg7ICxHRGZoEUXnTcQuN0jE7qdZMIlweYDDFjC7Jxva0sVdYALNZQZrmYlA t5oCXn2pbsQQquKgJOEVYjgbC3DJvgeu9CFgrsgmFtH9ewSljvUyg5yJbNbrDUJ1QlGF2H5NuKk tRiTNoLSesyBFV1JgrFd3rcDP1dVBRqqpKl+W1Zkms/6NzQ5ZvqYWZnoJ7j7nEAGAw= X-Google-Smtp-Source: AGHT+IGd3FfUImkbuTIHualSl03iWhPCsK272UsBzIXbKjGtmziydc6ISX0oPJIXEIB8DvlCJBFtQw== X-Received: by 2002:a17:903:244d:b0:216:7175:41bd with SMTP id d9443c01a7336-21a83fb0b26mr432450835ad.39.1736962819934; Wed, 15 Jan 2025 09:40:19 -0800 (PST) Received: from thinkpad ([120.60.139.68]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f12eaadsm85327695ad.70.2025.01.15.09.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 09:40:16 -0800 (PST) Date: Wed, 15 Jan 2025 23:10:12 +0530 From: Manivannan Sadhasivam To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Dan Carpenter , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next v1] PCI: rockchip: Improve error handling in clock return value Message-ID: <20250115174012.bdny6nxxr4tuzyis@thinkpad> References: <20250106153041.55267-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250106153041.55267-1-linux.amoon@gmail.com> On Mon, Jan 06, 2025 at 09:00:38PM +0530, Anand Moon wrote: Subject should include the word 'fix' not 'improve' > Updates the error message to include the actual return value of s/Updates/Update (imperative form) > devm_clk_bulk_get_all, which provides more context for debugging > and troubleshooting the root cause of clock retrieval failures. > Btw, it is not just updating the error message, it also returns the actual error code. - Mani > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202501040409.SUV09R80-lkp@intel.com/ > Signed-off-by: Anand Moon > --- > drivers/pci/controller/pcie-rockchip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > index fea867c24f75..ca6163f9d2dd 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -99,7 +99,8 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) > > rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks); > if (rockchip->num_clks < 0) > - return dev_err_probe(dev, err, "failed to get clocks\n"); > + return dev_err_probe(dev, rockchip->num_clks, > + "failed to get clocks\n"); > > return 0; > } > -- > 2.47.1 > -- மணிவண்ணன் சதாசிவம்