From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B5961D8A0D; Thu, 16 Jan 2025 16:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737043268; cv=none; b=ihJ9BuD5GwAWRv1DjlnUMpHNw+eWOSW/vSJXqFHw/D8KJAC4fQpFvvECyxnZiyAbk7j2dIwLcu9ad4ncBSg/dVdueg/brexTAZhrBjuvHTyPLADDVMVaXkE3AxOZXjXfWUWoI9c3jtd7XUrYbT/GuwrXDc8vHDiVrN8VPa0Rbg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737043268; c=relaxed/simple; bh=K+O30vGF8jNEYQFXsYQnn3DPQMXPqVS7VsD/r8QKN1c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kV2FbwzOgjBqwoti+e/xIEXY0bO04B3NJSXq+2KA+1Lh1WbzHJ0u70HZWh1e1Y5xUGpTlc6/ZeHDepE4Uc/YQO1Qi+7y4uXzE4KOXfUWl6lDNHPuArphIoyvcGDI6JcCxWmvJeY98ehVSt8ide4V7xRyTQFevJboIwY5O07aStw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Lo485IKb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lo485IKb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 948C1C4CEE1; Thu, 16 Jan 2025 16:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737043267; bh=K+O30vGF8jNEYQFXsYQnn3DPQMXPqVS7VsD/r8QKN1c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lo485IKbw+eOWH9CJfq3RxyLfSDwWzOIGOafK7LwYcIRglHUpSCfZvcnHDLvL+bQU Ctt7NMCC3MWl1glyldYnSoiMv4t2A5+v1ywa1rij0TAywGP9TW6PGyt6PFXQ1KjYov 030Uiod4Z38mycvYsM+gwH9khJD3uis5jLoe2JBuYQc3vEyVuJHAGThUCZ5bKW/o24 5IJfg2Ut+8i75uH4exc7cWhkyoLhA93mTkgg4eALg62ezEVdEFEowc8/nSq4zC6Q6p c1cnO0D58K2bcWaGGQc3Cwi7NzW1e6+c2NvnQRKad0cWfR0HCQYYR9cyzCXBY3J77k ceWOp3UOMzPjQ== Date: Thu, 16 Jan 2025 17:01:03 +0100 From: Maxime Ripard To: Dmitry Baryshkov Cc: fnkl.kernel@gmail.com, Hector Martin , Sven Peter , Alyssa Rosenzweig , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jessica Zhang , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alyssa Ross , Janne Grunau Subject: Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver Message-ID: <20250116-vivacious-congenial-nightingale-cb2f6d@houat> References: <20250114-adpdrm-v4-0-e9b5260a39f1@gmail.com> <20250114-adpdrm-v4-2-e9b5260a39f1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="rgvkyocpvfnurspd" Content-Disposition: inline In-Reply-To: --rgvkyocpvfnurspd Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver MIME-Version: 1.0 Hi Dmitry, On Wed, Jan 15, 2025 at 12:21:39PM +0200, Dmitry Baryshkov wrote: > On Tue, Jan 14, 2025 at 10:38:53PM +0100, Sasha Finkelstein via B4 Relay = wrote: > > +static int adp_dsi_host_attach(struct mipi_dsi_host *host, > > + struct mipi_dsi_device *dev) > > +{ > > + struct adp_mipi_drv_private *adp =3D mipi_to_adp(host); > > + struct drm_bridge *next; > > + > > + next =3D devm_drm_of_get_bridge(adp->dsi.dev, adp->dsi.dev->of_node, = 1, 0); >=20 > select DRM_PANEL_BRIDGE for this API to be available. > Also there is an issue of lifetimes. The bridge will be destroyed only > when MIPI driver is unbound, however the panel can be attached and > detached several times. Can you expand on that one a bit more? AFAIK, it's always been unsafe and we don't have a good mitigation at the moment, so it's unclear to me what change you want here. Maxime --rgvkyocpvfnurspd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ4ktOAAKCRAnX84Zoj2+ diYEAX9X9nkT02sFf01ulFeGvCcG9S4zbIOBRhh3YUXpaH4JAbu+6x4S7Ioq+nx1 cybYy0ABf2QLNDKRv+5B3Kyk0nHtU/Qae+ucdanC6Nw7Qqf6R/77ktfolomf8Oc4 t/GdZdJufA== =siI1 -----END PGP SIGNATURE----- --rgvkyocpvfnurspd--