From: Shinas Rasheed <srasheed@marvell.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <hgani@marvell.com>, <sedara@marvell.com>, <vimleshk@marvell.com>,
<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
<konguyen@redhat.com>, <horms@kernel.org>,
<einstein.xue@synaxg.com>,
"Shinas Rasheed" <srasheed@marvell.com>
Subject: [PATCH net v8 0/4] Fix race conditions in ndo_get_stats64
Date: Thu, 16 Jan 2025 00:38:21 -0800 [thread overview]
Message-ID: <20250116083825.2581885-1-srasheed@marvell.com> (raw)
Fix race conditions in ndo_get_stats64 by storing tx/rx stats
locally and not availing per queue resources which could be torn
down during interface stop. Also remove stats fetch from
firmware which is currently unnecessary
Changes:
V8:
- Reordered patches
V7: https://lore.kernel.org/all/20250114125124.2570660-1-srasheed@marvell.com/
- Updated octep_get_stats64() to be reentrant
V6: https://lore.kernel.org/all/20250110122730.2551863-1-srasheed@marvell.com/
- Corrected patch 2/4 which was not applying properly
V5: https://lore.kernel.org/all/20250109103221.2544467-1-srasheed@marvell.com/
- Store tx/rx stats locally and avail use stats in ndo_get_stats64()
instead of availing per queue resources there.
V4: https://lore.kernel.org/all/20250102112246.2494230-1-srasheed@marvell.com/
- Check if netdev is running, as decision for accessing resources
rather than availing lock implementations, in ndo_get_stats64()
V3: https://lore.kernel.org/all/20241218115111.2407958-1-srasheed@marvell.com/
- Added warn log that happened due to rcu_read_lock in commit message
V2: https://lore.kernel.org/all/20241216075842.2394606-1-srasheed@marvell.com/
- Changed sync mechanism to fix race conditions from using an atomic
set_bit ops to a much simpler synchronize_net()
V1: https://lore.kernel.org/all/20241203072130.2316913-1-srasheed@marvell.com/
Shinas Rasheed (4):
octeon_ep: remove firmware stats fetch in ndo_get_stats64
octeon_ep: update tx/rx stats locally for persistence
octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64
octeon_ep_vf: update tx/rx stats locally for persistence
.../marvell/octeon_ep/octep_ethtool.c | 41 ++++++++-----------
.../ethernet/marvell/octeon_ep/octep_main.c | 29 ++++---------
.../ethernet/marvell/octeon_ep/octep_main.h | 11 +++++
.../net/ethernet/marvell/octeon_ep/octep_rx.c | 12 +++---
.../net/ethernet/marvell/octeon_ep/octep_rx.h | 4 +-
.../net/ethernet/marvell/octeon_ep/octep_tx.c | 7 ++--
.../net/ethernet/marvell/octeon_ep/octep_tx.h | 4 +-
.../marvell/octeon_ep_vf/octep_vf_ethtool.c | 29 +++++--------
.../marvell/octeon_ep_vf/octep_vf_main.c | 25 ++++-------
.../marvell/octeon_ep_vf/octep_vf_main.h | 11 +++++
.../marvell/octeon_ep_vf/octep_vf_rx.c | 10 +++--
.../marvell/octeon_ep_vf/octep_vf_rx.h | 2 +-
.../marvell/octeon_ep_vf/octep_vf_tx.c | 7 ++--
.../marvell/octeon_ep_vf/octep_vf_tx.h | 2 +-
14 files changed, 92 insertions(+), 102 deletions(-)
--
2.25.1
next reply other threads:[~2025-01-16 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 8:38 Shinas Rasheed [this message]
2025-01-16 8:38 ` [PATCH net v8 1/4] octeon_ep: remove firmware stats fetch " Shinas Rasheed
2025-01-16 15:44 ` Larysa Zaremba
2025-01-16 8:38 ` [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence Shinas Rasheed
2025-01-16 15:26 ` Larysa Zaremba
2025-01-17 0:27 ` Jakub Kicinski
2025-01-17 4:11 ` [EXTERNAL] " Shinas Rasheed
2025-01-17 5:49 ` Shinas Rasheed
2025-01-16 8:38 ` [PATCH net v8 3/4] octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64 Shinas Rasheed
2025-01-16 15:42 ` Larysa Zaremba
2025-01-16 8:38 ` [PATCH net v8 4/4] octeon_ep_vf: update tx/rx stats locally for persistence Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116083825.2581885-1-srasheed@marvell.com \
--to=srasheed@marvell.com \
--cc=einstein.xue@synaxg.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sedara@marvell.com \
--cc=thaller@redhat.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®