From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758045336E
	for <linux-kernel@vger.kernel.org>; Thu, 16 Jan 2025 15:10:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1737040220; cv=none; b=sBPGKh+jU8Jjc8NRutz4q9PRaCmNeyz1bPFTSV+B7r4vyqO4Ycim9+BSt6Nddi16sGoJqt3NB4ypEk1QROFJ0KfQOU9ef6KJIOL6fIUlnB1NUZ7nFNaAAgPm3qcadypg7RanUpld56sdz3vKslo+u2q//kXoVaYXNOVlMOngQZI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1737040220; c=relaxed/simple;
	bh=HgMYeRaYwxTZrUDJP2D4Go97N3aCYt9GFUvaNxccqeI=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=LZjhaIB5acusfN8oGeOQrwFA3OyBT9sUdkGjCxs7qgEbtlXhDXOvhk3eHoEDrmLF76o4f0sA0ztn2fBwFbDVuKVm0ltUBJKTp30Uq+FhhX2X9WBqX9WU7GCuCmI9XpN0bBPsJXVpHUaZCsyzS8ugs4bm5H+vRu77dMpesKPB2PY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EAE9C4CED6;
	Thu, 16 Jan 2025 15:10:19 +0000 (UTC)
Date: Thu, 16 Jan 2025 10:10:24 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Masami Hiramatsu
 <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathieu
 Desnoyers <mathieu.desnoyers@efficios.com>, Shrikanth Hegde
 <sshegde@linux.ibm.com>
Subject: Re: [GIT PULL] tracing: Fixes for v6.13-rc7
Message-ID: <20250116101024.2d8040d0@gandalf.local.home>
In-Reply-To: <20250116095333.5988c930@gandalf.local.home>
References: <20250116095333.5988c930@gandalf.local.home>
X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 16 Jan 2025 09:53:33 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

>   But the irqsoff and wakeup latency tracers, when the "display-graph"
>   option was set, would use the function graph tracer to calculate the
>   times of functions during the latency. The movement of the calltime
>   calculation made the value zero for these tracers, and the output
>   no longer showed the length of time of each tracer, but instead the
>   absolute timestamp of when the function returned (rettime - calltime
>   where calltime is now zero).

FYI,

I have a patch that removes the calltime and rettime fields from the
generic structure as they should not be used in the generic code. That is
how I found this bug. I noticed that the irqsoff and wakeup tracers used
that field as well, and when I tested those tracers with the display-graph
option enabled, that's when I noticed the regression.

But that change is a cleanup and not appropriate for an rc release. This
was more of a work around to fix the regression. The proper fix will come
in 6.14.

-- Steve