From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5096522D4C8 for ; Thu, 16 Jan 2025 15:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042906; cv=none; b=fz3WP3ErUsAugKSDEgFtMqCfUFMITY9Uj+P1dBGf1mjjditIS6Mrxy4wJTlmJwyKwcRsYLGKFiwhN/FgA96+nFuUS2GTBqpwu3uOP0WLytg2YBOT4o47/7oiI/j2Rr4m5jwkMCFy2JsTDAbRqC55v7aMv/AQ+FKatqXFRzx1qVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042906; c=relaxed/simple; bh=eCkFCjG44r2dEGvlDDWjG+svIkkq4nTzzCRqmnJS5ps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NNUGRicULEk41UFv/fF9wLLAYQ8Jm1N2KWPJK/RmEkJbF+JOm2MXwHUIqWTx00bagpAWOTWHfYHBdfMpVDsu5+Vhc1pYUxFsA8JyW0r7J05XB2AlaHVBDYioBidU183Z07B9D98q41ie09uYbb5Jq4Hxo36j3kdR8rxzdKTYvco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DOLVWTUN; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DOLVWTUN" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43690d4605dso7330465e9.0 for ; Thu, 16 Jan 2025 07:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737042902; x=1737647702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=go0LBPnlfpqosNhb/KeEQRE2AJw7BPzMUNlEkycpQJI=; b=DOLVWTUNQfANJqwteGNxEV1niQxRxLaD7sosZzD/mM7xpApEmD5icEj176XQuQMGa/ PveiUsyycwfEpYGwiFZ6a94COrXfWI52tjpLEvrG8V9ufU+BIMDFTgVG6rgKKgrjCZXz 8GNQJZxwzBFvxh4Ki/TlrGEYPVjhRkoW51alNOAzW3jtC5mlQ+i0H2xtPZpw4LXUbeC1 RgrUhjDY833u7ig5bTVAne+zG+IBNI60imwfMJ5AHlNXSTLAKXuVrvRwMJH4UC+GqVIU xIWCCPfIpNYA8hcNFmhtjuD0AzU1QDVuzaIlBEGl5CFDW2wX8p9G2cxVZN6/0kG9rBiF Ae7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737042902; x=1737647702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=go0LBPnlfpqosNhb/KeEQRE2AJw7BPzMUNlEkycpQJI=; b=NC34LxLSXJq1MotniBi8hVV0z320mNsWktk3yhdY6y8Q3pJ/mpK5ZPl00mHzsyXvOc Mhp0q+zLpEg3xY04ZCe5VaYeqpvWMxgM4IrglPqD4H5b7tcBHbktGfoYWJgVVNrkSoRu QS0lbjRRXuKiE/tHxTYHO4YG7rLqEXPdO3ftkQVXJ33oHyfMEGdN+1uQQB3l4LrdhUlt sapkuSCbbboviAMCzzWVyid1MO4+DjtUGsUiRiRBgzy23KBrJbFJEdNMKpwTpezIug5j AYDapkaUO1a1U/j1afhfmdeNEqb9WlKVEsopJ9ADEDl0JYLFItG8SsSj60wrpkFEf/Ed KuHA== X-Forwarded-Encrypted: i=1; AJvYcCV4rppSPIBp/XQ7N0X09g2AakQEEBRrESI9MAVrHxVVmWB6svK3aqlmzWWJBdjnnOgA/EQuc6k/hgjJFMo=@vger.kernel.org X-Gm-Message-State: AOJu0YzrawA4He9+iEMFb0GEkOsNfuiotrf5dfg9G2v/ezyT8pbRXlSg GQ7q4aSjAOP6umGd2MLEN77UD3TrgGZCjAg/xXz/JyiiWPXAmmt+ X-Gm-Gg: ASbGncvSYZJGisB9UPTchrhrD7ZA496NFL0ao3VsI9y/Bu66QNS2Q2krIKn6aUDBUcP 4W08yDb+EGj7F6zcf7P8pHM6KLI/nQ/MSUNeUfAvmWP5kcmioAcjzMvY1LTH3DByfbCp70aD1UO a8pwEMc5t/8xEJ7AjhERaLGoiklXTjOjW10rUq2kQB5YRXhRYNp5R9h9f4eOi/OQEUlk7uOJ3aE /3mTm5aejBr5o6CGUVdgwABTnJlEjEBRTBwib9y5wkznmGrkJkhOpjloA== X-Google-Smtp-Source: AGHT+IG4x0x+jpkzgsLRk2inzjjZnEaxEEdBjSLHzEIi633/jTZFWPwb0Y29bfsMYA251Rse8xB6gg== X-Received: by 2002:a05:600c:354e:b0:431:5aea:95f with SMTP id 5b1f17b1804b1-436e26a175cmr366834405e9.16.1737042902571; Thu, 16 Jan 2025 07:55:02 -0800 (PST) Received: from fedora.. ([94.73.34.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4389040854bsm3441185e9.7.2025.01.16.07.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:55:02 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: louis.chauvet@bootlin.com Cc: airlied@gmail.com, arthurgrillo@riseup.net, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, jeremie.dautheribes@bootlin.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mairacanal@riseup.net, mcanal@igalia.com, melissa.srw@gmail.com, miquel.raynal@bootlin.com, mripard@kernel.org, nicolejadeyee@google.com, rodrigosiqueiramelo@gmail.com, seanpaul@google.com, simona.vetter@ffwll.ch, simona@ffwll.ch, thomas.petazzoni@bootlin.com, tzimmermann@suse.de, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v8 2/8] drm/vkms: Switch to managed for encoder Date: Thu, 16 Jan 2025 16:54:59 +0100 Message-ID: <20250116155500.3476-1-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250114-google-vkms-managed-v8-2-da4254aa3dd5@bootlin.com> References: <20250114-google-vkms-managed-v8-2-da4254aa3dd5@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > The current VKMS driver uses non-managed function to create encoders. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Reviewed-by: Maxime Ripard > Reviewed-by: Maíra Canal > Reviewed-by: Thomas Zimmermann > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito Thanks! > --- > drivers/gpu/drm/vkms/vkms_output.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c > index 570823ecb28f589e6323036590ec05a2f633bc9b..ab9affa75b66ce9f00fe025052439405206144ec 100644 > --- a/drivers/gpu/drm/vkms/vkms_output.c > +++ b/drivers/gpu/drm/vkms/vkms_output.c > @@ -13,10 +13,6 @@ static const struct drm_connector_funcs vkms_connector_funcs = { > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > }; > > -static const struct drm_encoder_funcs vkms_encoder_funcs = { > - .destroy = drm_encoder_cleanup, > -}; > - > static int vkms_conn_get_modes(struct drm_connector *connector) > { > int count; > @@ -84,8 +80,8 @@ int vkms_output_init(struct vkms_device *vkmsdev) > > drm_connector_helper_add(connector, &vkms_conn_helper_funcs); > > - ret = drm_encoder_init(dev, encoder, &vkms_encoder_funcs, > - DRM_MODE_ENCODER_VIRTUAL, NULL); > + ret = drmm_encoder_init(dev, encoder, NULL, > + DRM_MODE_ENCODER_VIRTUAL, NULL); > if (ret) { > DRM_ERROR("Failed to init encoder\n"); > return ret; > @@ -95,7 +91,7 @@ int vkms_output_init(struct vkms_device *vkmsdev) > ret = drm_connector_attach_encoder(connector, encoder); > if (ret) { > DRM_ERROR("Failed to attach connector to encoder\n"); > - goto err_attach; > + return ret; > } > > if (vkmsdev->config->writeback) { > @@ -108,7 +104,5 @@ int vkms_output_init(struct vkms_device *vkmsdev) > > return 0; > > -err_attach: > - drm_encoder_cleanup(encoder); > return ret; > } >