From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 142EC22CA1C for ; Thu, 16 Jan 2025 15:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042913; cv=none; b=dhKPbRymkXpGdGRFw2XjFjIfyx31ozgRWyF3z/W0sCUABIqdlP5sESIotWGZzYqj18IPqGs88VMNPaC8sMt0JwPRjpaqqfUePLeHX3AmdQfBj0GpF74gSv7UwIv9xahG1aDO5Qzn9i9pofEsb4lgR2HvfacMXhhV6GUdhKhhYCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042913; c=relaxed/simple; bh=z/aFu3JBQ3VIKFnDx+xJZzY6fGFZskN8QEMqnFUmrhU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O2fFjxQ3yrUSgMq/j1snBBTRaYIIOaNSRhzYDdzUc2nZLV/qZHJ7A3/rZQ0/LAqMKDMpiA6ae7bRRCOqwh6N6WneW4h014qSptJb1xHvqN0nqepFf9yMtbk740gpM/MX+fzsijLVaB7whQzWMAhuZKF5WvPLjVVJW5pOQCESSyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mlJDN5VE; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mlJDN5VE" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4361b6f9faeso7275185e9.1 for ; Thu, 16 Jan 2025 07:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737042910; x=1737647710; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ipXXq8RDzGtjCL4rhS+FjInCIhtOTIGOxDGy8AYY1JY=; b=mlJDN5VEGCxmRZ2I5PWv5Cywj1ye1gBG+osL3TytFR71/uJGrc1Md/F/C2/F8hs05m Me7agKWGFDj/7u/E4T9RkPwKYmCLl9CXz5mEfZeMq/Z+9couhvgzlRScUK42MxPN9toH QWai0A3sxfFSG1iQdL+9kcE1FiknyVcjecWUkOACnzhNLI4RU53UD23gAG0yayKkudo6 aW1kcNtJII79MLQ1dAQPGerVDyXPldESrnGxUqZ+ClmETGmAKbJpJkakl3bfw7nRnUXZ d+jMOv5gb8qvJWSGifoo4HgZbNPhMJDRu2R0Dz22P0AxAvLi65pzP/U963wOgJUl+Ztd Svxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737042910; x=1737647710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ipXXq8RDzGtjCL4rhS+FjInCIhtOTIGOxDGy8AYY1JY=; b=uBmShrwjEkWwXDHzw530KOr+d0xEKphYOo4+Xban0eui49QKzGN19o54mBbvCnkewn ysx0/Irvo+H7kJVopY3A5h4TltTm5xq4xfe7H7+a72FfwplnvvS1oQhksBLsfE6uQ+iU 5egDC0e3rFRchpluUFF0783s52qcHHwwl70ARr97QjrEEA4hwXJueA869IMzgbbHhdpo 3JhAazcsNRnBmRuhGP4ICQJKU5swk9TN1BKRURig50fSNWTwRK4LXxhqc9PVXXti9kV5 hAR8jCqvajDXCb8hYjMjdCZmyA4ckGmcwKrMQici8NTQZJ3YQvvJCHS2soA456VvUq8+ kLrw== X-Forwarded-Encrypted: i=1; AJvYcCXsrkd7F6FxItNqicyDbujVAnlzV7u+QH/XL7nPBR2C64J34aoOfQE1ewVseaaxFfBfQ1Pm1oLgGwKFHEs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv+8I80Shec1SGuigdRrZAQ+Jrws2+x19eGUbu1p8EG/FYwWPd +lvTmfVK5TBzd5rDmMHrARPriItQ+yoe2vh7HKtLMA3jRqB7OsNb062qKHPe X-Gm-Gg: ASbGncsZR0rbzoj6qhJzmq431a7MC4mij9e+aGzxkBPusp5PGO6lEcIkrEfICNXbo4y vYxLNHDn7qkJs5McVNvYweVChNfHo+oPCUDbLIN7tIV+nCSxzVnRYzgNevvRqy1kEluUymZ0zXa 3c6uWtNqmYkQbEVb5y9uMDxOSvzgHsrgRJwKh1+pK8Wms8+jkdnbcRlHMa1y3w1LP8oSsI0qK9k e5Y5Z/ydUDTqvxZXs/PeIg9YQK1R1WK3RWMthZXHdbvNX/zP5x4+ScIQw== X-Google-Smtp-Source: AGHT+IEpRyrrW3YyEx6ouKaFnnsoiFIsOVnIEBjt4llBGWy91vd5zqqCb3uvNB53PtG0NhUma5kU2g== X-Received: by 2002:a05:600c:4f55:b0:434:ea1a:e30c with SMTP id 5b1f17b1804b1-437c6b468a7mr70363085e9.13.1737042910175; Thu, 16 Jan 2025 07:55:10 -0800 (PST) Received: from fedora.. ([94.73.34.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c73e7140sm64981505e9.0.2025.01.16.07.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:55:09 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: louis.chauvet@bootlin.com Cc: airlied@gmail.com, arthurgrillo@riseup.net, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, jeremie.dautheribes@bootlin.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mairacanal@riseup.net, melissa.srw@gmail.com, miquel.raynal@bootlin.com, mripard@kernel.org, nicolejadeyee@google.com, rodrigosiqueiramelo@gmail.com, seanpaul@google.com, simona.vetter@ffwll.ch, simona@ffwll.ch, thomas.petazzoni@bootlin.com, tzimmermann@suse.de, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v8 4/8] drm/vkms: Switch to managed for crtc Date: Thu, 16 Jan 2025 16:55:06 +0100 Message-ID: <20250116155507.3491-1-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250114-google-vkms-managed-v8-4-da4254aa3dd5@bootlin.com> References: <20250114-google-vkms-managed-v8-4-da4254aa3dd5@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > The current VKMS driver uses managed function to create crtc, but > don't use it to properly clean the crtc workqueue. It is not an > issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis Chauvet > Acked-by: Maxime Ripard Reviewed-by: José Expósito Thanks! > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 5 ++++- > drivers/gpu/drm/vkms/vkms_drv.c | 9 --------- > 2 files changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > index 28a57ae109fcc05af3fe74f94518c462c09119e3..434c35d5e9477d2961826262591db8ab43838e09 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -4,6 +4,7 @@ > > #include > #include > +#include > #include > #include > > @@ -296,7 +297,9 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > spin_lock_init(&vkms_out->lock); > spin_lock_init(&vkms_out->composer_lock); > > - vkms_out->composer_workq = alloc_ordered_workqueue("vkms_composer", 0); > + vkms_out->composer_workq = drmm_alloc_ordered_workqueue(dev, "vkms_composer", 0); > + if (IS_ERR(vkms_out->composer_workq)) > + return PTR_ERR(vkms_out->composer_workq); > if (!vkms_out->composer_workq) > return -ENOMEM; > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index e0409aba93496932b32a130ebb608ee53b1a9c59..7c142bfc3bd9de9556621db3e7f570dc0a4fab3a 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -53,14 +53,6 @@ MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay support"); > > DEFINE_DRM_GEM_FOPS(vkms_driver_fops); > > -static void vkms_release(struct drm_device *dev) > -{ > - struct vkms_device *vkms = drm_device_to_vkms_device(dev); > - > - if (vkms->output.composer_workq) > - destroy_workqueue(vkms->output.composer_workq); > -} > - > static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state) > { > struct drm_device *dev = old_state->dev; > @@ -108,7 +100,6 @@ static const struct drm_debugfs_info vkms_config_debugfs_list[] = { > > static const struct drm_driver vkms_driver = { > .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, > - .release = vkms_release, > .fops = &vkms_driver_fops, > DRM_GEM_SHMEM_DRIVER_OPS, > DRM_FBDEV_SHMEM_DRIVER_OPS, >