From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1569A19992C for ; Fri, 17 Jan 2025 11:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737113909; cv=none; b=OJAVb30G+5wqDE9u24iIFnZYO6QyPGM4lLBDxqESMDfgXfrjq+m3WLojNGonUyKailEBUOEiUEjDZGIyU3Euc2vendaqnIFNhFR/4VJawhK3xX1AH7lNmGjylvGynP9+62gjLdwRet83ItmOEgtJoHvHZ5glkElGa8gso4pjAAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737113909; c=relaxed/simple; bh=HGnhy8hXgCbHJORv08RcEldyyQj+CPt3GZo5LANeqfg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XIPF3qxMc4TjV0Rmuu1xo2rZfi25FJNL90O3b//e6WS6uLej5M9FWMNJUZ+Eqd2ytqTCoMYIRWJF80NEgbTgC9ttOtrme61/d/oxS3j4m1qSANf3Bsp1sOgEfC0VDTVwluSUsz+abpFDJYyCvEEq9fHI3FrlyrTZSQ9C88gVd0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=fBLpPIzk; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fBLpPIzk" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oFzeXtDodlXU1o5xj1QIzYFApIFeDEgOamEBBzAuy+I=; b=fBLpPIzkUs18PQGb17aUFmUJQ2 RqOODkLhb0HVtCc/mMSthGTPh2YAd3E2MSCQ8CIliaJzKe0MIPXqF0AATA42e6XS5zq7CIvGMlsoU pqzmfKxqOCabKQJhHglJtRUp9TrBXMazg4DM+Qk20uvWnFhr4wbRelrrTpPoXJhZm+TKFGabWjvax Rt6oGEQf/6MIQ9GlBeszKZq3aH8nqYbbU/zWWVYJHG1OJTLeTg77bqN4mZUlCvYCIa1Ae7nn0+xGD iHB0L2O4jwipFKtMXvJApGaWrEtwQXkJ+xzEduc/54VfjeM4R0K246nyoRkH83mlFNMoFpW6DPymS 0JBYSuhQ==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tYkg2-0000000CKK2-2O6B; Fri, 17 Jan 2025 11:38:14 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 53DBC30057A; Fri, 17 Jan 2025 12:38:13 +0100 (CET) Date: Fri, 17 Jan 2025 12:38:13 +0100 From: Peter Zijlstra To: Vincent Guittot Cc: zihan zhou <15645113830zzh@gmail.com>, mingo@redhat.com, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, zhouzihan30@jd.com, yaozhenguo , yaowenchao1 Subject: Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug Message-ID: <20250117113813.GA8603@noisy.programming.kicks-ass.net> References: <20250117022254.16521-1-15645113830zzh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 17, 2025 at 09:32:43AM +0100, Vincent Guittot wrote: > On Fri, 17 Jan 2025 at 03:23, zihan zhou <15645113830zzh@gmail.com> wrote: > > > > In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable > > tasks" table, but not all tasks in the table are runnable. > > It is inappropriate to refer to this table as "runnable tasks", so here it > > is changed to "Tasks on CPU %d", like: > > We have used replaced runnable by queued in fair scheduler Right, but also 'tasks on cpu' is equally wrong -- but really, if you're looking at sched/debug you have to know what you're doing anyway, so why bother with trivial stuff like this? > > Tasks on cpu 31: > > S task PID vruntime eligible deadline > > -------------------------------------------------------------------- > > S cpuhp/31 173 0.803286 E 2.153245 > > S migration/31 174 8.167468 E 11.167468 > > > > PS For the sake of clarity in reality, some table information has been > > omitted here. > > > > > > Signed-off-by: zihan zhou <15645113830zzh@gmail.com> > > Signed-off-by: yaozhenguo > > Signed-off-by: yaowenchao1 And that's a broken SoB chain.