From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795EE2B9A5 for ; Sun, 19 Jan 2025 05:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737265485; cv=none; b=WU3+jbwBt6WE7oekbkPm4JskrW29XiTBjKinzNFdmJ5qNfzjsNflNEyFgJ/gR2HYRkbDRSS4z09UyMs1OEXvWo9+/ajWVxJl6p4LVdcKLBu6v7RivL1PERDYUa3uEHED6LOc7FbJQOvRkX8T/YVOnjUSfK/bPkBxi6JOyhVfa/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737265485; c=relaxed/simple; bh=JuJ7naDmXlmy8qx6XInrCFlwYy8tADOGQikyIAf19kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ko5+zEZL3Siga/WJf8aLdDQmZuEiUBnzjL4WyXV4x9xBHGmgLwVFBqhT1pmPgDFg7qsmW83ysMo9oFFAwI7aetZnq0FBH163iXHn09si4DEvBZNFEBJQL/ZF00BQlend7+MiVD7stnx2PsEjrYcBl+ZyFz1LN+sgSgNofHzX9AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LTk6eKg9; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LTk6eKg9" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2f43d17b0e3so6301872a91.0 for ; Sat, 18 Jan 2025 21:44:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737265483; x=1737870283; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HBFYLkNa+YoNF9Pfhcn2ea51UZ/gLUJMdxLc+4EU3F4=; b=LTk6eKg9ntaUkQDbOSmftsGGOjpFejV6DpoaWFTZKNuCqSg6B4jQ4S4akio0i94GaP Zba9VYD9uFQ/x0jEXBXmtfoWiXHzIdsNj8yZBLqjTe3kEJjVB6l9SiyvmBJfnIrI7R66 XvR4kInK8fIayAkenGXSNetUJJZllZC9J5MWhNchCyneN6vbSBlhKV4xPTvLyF/PXb6o nVUMwApwUMw+ron4hFvq3aNn0f0QkVkbGBfYpEf+FuqiJd9aGLzl6QK0Mf4Bz8qil717 HB4ghXWGlyGUiMWzfYz6esxKB0qUDURdCiwZne8GyiUTpIPQ3lOYjH14QxUYKppo3PUQ G4cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737265483; x=1737870283; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HBFYLkNa+YoNF9Pfhcn2ea51UZ/gLUJMdxLc+4EU3F4=; b=dtdHZSKEOl9YpbE/cBgM+fd8gkPyJDJGt2l8kdYxv24Kcvao6TM6foh9aRn84Kw7Hn Mf8dqZwDhuyMK7nlyk7MGzy4OdVcfMOwNDVw9z093hg4yH7QkqRJQ7uzSUhXgpFa/NA9 eP1XsSqQ0JmDk0mVkafwyfKeEDagyK5cVeNZHoQ5wcevEYv4IgobnW9MKi0iy8qmTgFc JMx8r6TgouBSlBvhTdL4NQM35zPnetEnlkTrBnw1QP/9qNqL8+9BHvQ2CvH8UWWO6WYX 6N1fZy+b7oFK8EWoFHmlrVfcSHwLnEVHO4e/5levWZsU3ErTkW+73XI91z0C0voCJjj2 RMDw== X-Forwarded-Encrypted: i=1; AJvYcCUpHYJtxfIK0AO7h9KhYgw7+NTtNXuNP5AN/eeW9h64CHTB9c4ODm30ZhNIygLhZ6IW2Dk9l7XI+1hYkbs=@vger.kernel.org X-Gm-Message-State: AOJu0YwcT3wvLMJEIHadCrOg2E16AwMPry602StKCPtnil5t2Eva0gml NV48eYMl6tCaFBKMoZlojOf76DvITTg5EcY+OcQVyqGciSOktb1miA7kjk8DQw== X-Gm-Gg: ASbGncvqcz4zgwhWMvh9/334ksb9CqXK+jZ6LyUBvpgONNdJP3LU3Zrze1LvHYjj3jJ UPj7b60aBF+aw/zOh10Lot8tL2OocYeFbSZP5dprQ1jeVFXPW8IeyzBc0BeTJG7xVNi+dKp9puQ O8aKgP1yC14pEPjReinBg0SViv0zS2lyjd241QyYV9OohU2w+WrWEEdaB+lVjgTpxpusScSNqGp SRGEAAnrFt//nwhzmv3LZjKLyJL4K1lpRxd+V4R6eTOmz70uOjAL6yyqYvnpUHrJemKWfEMSjuC JWc3eA== X-Google-Smtp-Source: AGHT+IEF7AswBtc7k3jDGF5yI8YAhFNLZyMCW3Irr0/2fB+onQMhz9MjtOFTjpEA4IGlQdfg2j8nZA== X-Received: by 2002:a05:6a00:2184:b0:725:ef4b:de33 with SMTP id d2e1a72fcca58-72daf88b1b9mr13809008b3a.0.1737265482724; Sat, 18 Jan 2025 21:44:42 -0800 (PST) Received: from thinkpad ([120.60.143.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab81753fsm4835038b3a.60.2025.01.18.21.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 21:44:41 -0800 (PST) Date: Sun, 19 Jan 2025 11:14:38 +0530 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: Jingoo Han , Frank Li , Rob Herring , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH] PCI: dwc: Simplify config resource lookup Message-ID: <20250119054438.r64thnipdvmlxn3p@thinkpad> References: <20250117235119.712043-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250117235119.712043-1-helgaas@kernel.org> On Fri, Jan 17, 2025 at 05:51:19PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > If platform_get_resource_byname("config") fails, return error immediately > and unindent the normal path. No functional change intended. > > Signed-off-by: Bjorn Helgaas Reviewed-by: Manivannan Sadhasivam One nit below. > --- > .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index e42a74108f0f..3fca55751dca 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -436,18 +436,18 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) > return ret; > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config"); > - if (res) { > - pp->cfg0_size = resource_size(res); > - pp->cfg0_base = res->start; > - > - pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res); > - if (IS_ERR(pp->va_cfg0_base)) > - return PTR_ERR(pp->va_cfg0_base); > - } else { > + if (!res) { > dev_err(dev, "Missing *config* reg space\n"); nit: How about: "Missing \"config\" reg space"? - Mani -- மணிவண்ணன் சதாசிவம்