From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00544257D for ; Mon, 20 Jan 2025 07:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359373; cv=none; b=sqGuoRGOZ3hkatVxN1YwxE6bOWNA9867OkDIimcNRWtlyCDU297vdElnIh1v1mT1lTja4cp+c/EFl21Db4PW2K2cg6Dsaf4JgzChvvuLLZrOFopWEsHETg+7Ughl93ywsfAOOu9fkuXzfNjruZbJgGqk1quZxAwYYkSwJKZd/rA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359373; c=relaxed/simple; bh=t5LAzQX40LOf6wSSgplbgwcg6eGNSLmr/usnX4lDzu0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DlawjCwpTFcqipVuC5bNzR/0pOGQoet8v0Te23PkAoCipCYlN1tY64Z79ygBWepWtFfuM/6hnLjCd6GEUFA9563W97TDrRrl7B9Aq3seO4NWK05+GtVcImGqJVPK90JywvXOgVK/KXPud4eO7EgE+0XspnUrC91g0D34b+9ZkaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nhk8ylil; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nhk8ylil" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2164b662090so75388245ad.1 for ; Sun, 19 Jan 2025 23:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737359370; x=1737964170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HgwtsEt65TmlRd4toThck2uN2T0DV9r2daGe00v8VtA=; b=Nhk8ylilmkwmHTO2NtP+Vbbj4wAL5YqyviJSXL0sW1MyTn729GbOXEzZv2CbsxIyse h9HkRewtPcSRwxAoxP2L5WLMKqLnM9DvS5gpXT3AdH5MjFBqJ4h6oFGPXwwQXcPnk3/+ F3shV0909pVTZY1UJd/PMW22mYHaGVLbV7TTPXygtQibpHa+Wo4Vw5W7GjWzw6OC5dyZ pVboPJbOiyHv+hdc2G6mXs4CU8iYLJsiL7zdHvoQVj1Kb1sqfKx3pojGjTA3O43ejEaO RPQUAVfvJlomp5iUqqefLv0cLqbfAm9/7g1//fvg3JLirXyFPlWMYwrEhpfaCeNuwhDz p+ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737359370; x=1737964170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HgwtsEt65TmlRd4toThck2uN2T0DV9r2daGe00v8VtA=; b=Sz2Rbo7u3RDKbKLSGzmIAXUa2oi3ZoqrlQf3Ysmbj8d2qMYYa3kdP8SY1tPR+p2JWQ qD/zRWTG+LzOQ6H65G9dVyquufJeMDSZdxsaWxZRJGwraSNxjsYnJY/GFjx9R7SX8f8R oEXrQJsaZd2/BQsqYxzw3M9ibIxqsYMjw32FQLG/WqLb+J3jn15nutokA2w+/f5mj8k/ Txqry/1y3xRh0+XoBcIOd/JeZtjCoku1hkQ4RzXZhph8rDvUQTa6r0YnU4o5DqL2qbJ7 5OubP8L/il4LDOzq7g++UT2w1NaKypQoNrNNIkS46rRSw9C0p6WOJybzw5+P700RGSY4 kWVg== X-Forwarded-Encrypted: i=1; AJvYcCUOPQ+02yU87QP+jpMVL4wX0skTBo4CkU+OAki12Q/C9VZFQebqpIG964XMjCvDYrzZUPxTa/y9ucWC7A8=@vger.kernel.org X-Gm-Message-State: AOJu0YwvtZwiZfroXev+1Rr1KXQTGSjkLHECWFid6romj3WVLcn5l5TQ WfROTn7T9neh2kfHsCyie1Z0Qv8GV3XwFqloXBJvevFhyIbkHRvb X-Gm-Gg: ASbGncuYE0Sech6bZbwYSw0oCFSSd3C79UEB/I4MDyZy6+e7MlHYgSvTfBejmdXT44f Ck530RV9yGY/TjoZC56IrNmbFzeIWeppZEk0LBJJwNCmGcnIiZ5Fu/7+ON7ALfou+YCCvUlr3Hf Yqfa/lCNncgKk+m3WgPoZEVj7vUew4ITsDInEjYcAJ5CPWSGdnbmWHpmhKkzuJJ92Js3Y3cx6ON Fnfuy6kbNDdc1URdFpYUroyOd3KpVnsxDub1XpHs2WcO7wcgdD8x+qn6Jrd011Gxi5m2H16Mh/4 jrigAF0qrByzmQ== X-Google-Smtp-Source: AGHT+IHZZDGTGPneyhH+L+SKk+1LeVmpJlHQeL5tDQ24/KI7JbTtDGtDblC0GghqDD5No67tOXuBCw== X-Received: by 2002:a05:6a20:734e:b0:1e6:509c:1664 with SMTP id adf61e73a8af0-1eb215beb90mr16315259637.39.1737359370630; Sun, 19 Jan 2025 23:49:30 -0800 (PST) Received: from localhost.localdomain ([114.67.205.189]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab7f2db6sm6618581b3a.13.2025.01.19.23.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 23:49:30 -0800 (PST) From: zihan zhou <15645113830zzh@gmail.com> To: peterz@infradead.org Cc: 15645113830zzh@gmail.com, bsegall@google.com, dietmar.eggemann@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, rostedt@goodmis.org, vincent.guittot@linaro.org, vschneid@redhat.com, yaowenchao@jd.com, yaozhenguo@jd.com, zhouzihan30@jd.com Subject: Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug Date: Mon, 20 Jan 2025 15:49:02 +0800 Message-Id: <20250120074901.49708-1-15645113830zzh@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20250117113813.GA8603@noisy.programming.kicks-ass.net> References: <20250117113813.GA8603@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thanks for your reply. > > > > > > In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable > > > tasks" table, but not all tasks in the table are runnable. > > > It is inappropriate to refer to this table as "runnable tasks", so here it > > > is changed to "Tasks on CPU %d", like: > > > > We have used replaced runnable by queued in fair scheduler > > Right, but also 'tasks on cpu' is equally wrong -- but really, if you're > looking at sched/debug you have to know what you're doing anyway, so why > bother with trivial stuff like this? Sorry, I just wanted to participate more in the kernel community. While debugging the scheduler, I found this wording error. It doesn't really affect anything, it just looks a bit awkward. By the way, I am confused why 'tasks on cpu' is wrong. I think that the tasks in the table are on a certain CPU, maybe they are sleeping, but at least they were running on this CPU at the last moment. Looking forward to your answer. Of course, this matter doesn't seem important, and I will try to understand it myself in the future.