From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011B6C2FB
	for <linux-kernel@vger.kernel.org>; Mon, 20 Jan 2025 17:45:24 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1737395125; cv=none; b=jLcHRaGxKtjTWK6zEqgcK5Jhr7Iisx/tswCIhZTxi9oQLKt//Adw93I6HuUXp3qSAv5YAFYaoRHh6PH6nwG3a7b2PEjleD+O0fLS3TeM2GyQHKObg5gENFAI44779aBds9o4paCrRqKQ/GIBa3obbMMg/s3Xp2pTivfNIOseoEc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1737395125; c=relaxed/simple;
	bh=v3lIF3f5kq1A8zjPR936SIufKWJiYb4gBA1FZdSZtnw=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=UWkyWxO+DeJLhP2OeomvmEWuzd6z+T/WR/3ap+1IGaUAEj/cdiI1Xudl67mLatwIvIdJHEM/mKE03gY7XtmlHOSUzuhHswfPZIMP/LT7L4cyaRjaPT4xePV1mJOjlzm9p3BJnnMi00B8BHzd6EYIZU9Wa65wsR5/cm0B8KpB3Qk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7C13C4CEE6;
	Mon, 20 Jan 2025 17:45:23 +0000 (UTC)
Date: Mon, 20 Jan 2025 12:45:24 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Masami Hiramatsu
 <mhiramat@kernel.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Alice Ryhl <aliceryhl@google.com>
Subject: Re: [GIT PULL] tracing: Updates for v6.14
Message-ID: <20250120124524.2ed6fdf7@gandalf.local.home>
In-Reply-To: <20250119192902.576eda90@gandalf.local.home>
References: <20250119192902.576eda90@gandalf.local.home>
X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 19 Jan 2025 19:29:02 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> - Add :mod: command to enable events for current or future modules
> 
>   The function tracer already has a way to enable functions to be traced in
>   modules by writing ":mod:<module>" into set_ftrace_filter. That will
>   enable either all the functions for the module if it is loaded, or if it
>   is not, it will cache that command, and when the module is loaded that
>   matches <module>, its functions will be enabled. This also allows init
>   functions to be traced. But currently events do not have that feature.
> 
>   Add the command where if ':mod:<module>' is written into set_event, then
>   either all the modules events are enabled if it is loaded, or cache it so
>   that the module's events are enabled when it is loaded. This also works
>   from the kernel command line, where "trace_event=:mod:<module>", when the
>   module is loaded at boot up, its events will be enabled then.

This change added a "#if CONFIG_MODULES" when it should have been a
"#ifdef CONFIG_MODULES". The kernel robot reported this over a week ago and
I fixed it locally, but got distracted and never sent out the fix nor
tested nor applied it.

I'm doing that now, so you can hold off on this pull request.

Thanks,

-- Steve