From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADEED224F0 for ; Tue, 21 Jan 2025 01:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737421835; cv=none; b=ARdpm4eWMwFNqliGnR0oFPNm2YK5az3+3e/f5o9grBgI8EVxMn2fwpQ+NX4RZVD4YeKPA85hjgw+Jlc3Pw1NXZ9tPPg5Pkw/cpsadCpNOKAfWOaqDy8N01uTN7DtPBjTw7Bt4VfKIjuhxszFbCg3+UQ/vyFUm9+rGuFKn5IwozE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737421835; c=relaxed/simple; bh=nLrbJgIHwRGKe9+eWfWel7TK4Ps+ZtjQXfUs08yp3H8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i8loGXyRY05z9GJ2DssQFvIExjTtciuF4+J5SabQ2yTFsbGxZcOZk5x06CRIIPrE0viBtXVG0jOHaOcUSx9G+mxEwpJLjNpF53bmKbTqy/m6yo0gHl8BT5/pbP4+o6vIk/Hqnkp5GihwvkRLlRo47+KppqV5JF5ZSvNgi9iKtdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BM1hPsHJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BM1hPsHJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1997C4CEDD; Tue, 21 Jan 2025 01:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737421835; bh=nLrbJgIHwRGKe9+eWfWel7TK4Ps+ZtjQXfUs08yp3H8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BM1hPsHJQkSjZuoIYoojvG2xI98I8sMoqxp9FFty+EFgZqBojw0e1JHpWrVby06z9 5icD/TMlu0QC73CxalkEDktgwRbLqhbn/e0acdjBIafIOYavxT5bC2cMX/zZzwFDkQ NcimztfLNfRnaUJ2cP6S8iKQnZaz4hxK5dWMmwm0vykOFwhIWiKJMX6bwlJ2/EW1mo WvSDLrNTDIBnZrRkUcF14ARsZsGX41BIxR0IfaMOYGbEusE8IGuz0UUjueCNStFBhR a3F9v39YffwOgWCb0czVR8pjV144isVU0uAcFydXXf4pxCzrwNWoecswFdznrMniwb kM35E4v+heIQw== Date: Tue, 21 Jan 2025 01:10:31 +0000 From: Conor Dooley To: Chuanhong Guo Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] riscv: add Siflower RISC-V SoC family Kconfig support Message-ID: <20250121-panorama-scarring-6086eb97beaa@spud> References: <20250120022359.125952-1-gch981213@gmail.com> <20250120-skyrocket-fiftieth-5fd770df030f@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mwOCWWF6ATKsTNpG" Content-Disposition: inline In-Reply-To: --mwOCWWF6ATKsTNpG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 21, 2025 at 09:04:47AM +0800, Chuanhong Guo wrote: > Hello! >=20 > On Tue, Jan 21, 2025 at 2:48=E2=80=AFAM Conor Dooley w= rote: > > > > On Mon, Jan 20, 2025 at 10:23:58AM +0800, Chuanhong Guo wrote: > > > Siflower RISC-V SoCs, including SF21A6826, SF21H8898 and some other > > > upcomping chips, are RISC-V chips with T-Head C908 cores for home > > > routers and gateways. Add a Kconfig entry named ARCH_SIFLOWER for > > > them. > > > Notably these chips uses ARM PL011 for UART. ARM_AMBA is selected > > > for its driver. > > > > > > Signed-off-by: Chuanhong Guo > > > > This needs to be in a series with the user (your dts) >=20 > Could the user be a driver Kconfig instead? When submitting a GPIO driver= I > was suggested to not depend on architecture symbol and add soc-specific > ones to arch/ first. [0] >=20 > I still need to polish the clock/reset driver a bit before submitting the= m. > Without a clock driver I can't really submit a dts with meaningful conten= t. >=20 > [0] https://lore.kernel.org/linux-gpio/CACRpkdYi_+aQ5L-c4=3Dw9MK-6Uh0e9dX= 0nnU6LcZcHd90j97q7w@mail.gmail.com/T/#mf2352fb36ed2cb8c6574d9eb0d4c261d9346= bf10 Send it with the GPIO driver then please. --mwOCWWF6ATKsTNpG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ47z9QAKCRB4tDGHoIJi 0tR2APwIbdEKl+JyD2r2yT+oTxwxGlTcLXIApwnET9PgOizjZAD/eak1izeuwRAv woNopkS7fqurhCW2qvJKzFPJDSm+VQI= =67aU -----END PGP SIGNATURE----- --mwOCWWF6ATKsTNpG--