mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: libaokun@huaweicloud.com
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
	linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
	yangerkun@huawei.com, libaokun@huaweicloud.com,
	Baokun Li <libaokun1@huawei.com>
Subject: [PATCH v2 8/8] ext4: pack holes in ext4_inode_info
Date: Tue, 21 Jan 2025 15:10:50 +0800	[thread overview]
Message-ID: <20250121071050.3991249-9-libaokun@huaweicloud.com> (raw)
In-Reply-To: <20250121071050.3991249-1-libaokun@huaweicloud.com>

From: Baokun Li <libaokun1@huawei.com>

When CONFIG_DEBUG_SPINLOCK is not enabled (general case), there are four
4 bytes holes and one 2 bytes hole in struct ext4_inode_info. Move the
members to pack the four 4 bytes holes.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
---
 fs/ext4/ext4.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 6fd550fc0c5c..c1693ba836ee 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1062,6 +1062,8 @@ struct ext4_inode_info {
 	/* Number of ongoing updates on this inode */
 	atomic_t  i_fc_updates;
 
+	spinlock_t i_raw_lock;	/* protects updates to the raw inode */
+
 	/* Fast commit wait queue for this inode */
 	wait_queue_head_t i_fc_wait;
 
@@ -1099,8 +1101,6 @@ struct ext4_inode_info {
 	struct inode vfs_inode;
 	struct jbd2_inode *jinode;
 
-	spinlock_t i_raw_lock;	/* protects updates to the raw inode */
-
 	/*
 	 * File creation time. Its function is same as that of
 	 * struct timespec64 i_{a,c,m}time in the generic inode.
@@ -1143,6 +1143,7 @@ struct ext4_inode_info {
 	/* quota space reservation, managed internally by quota code */
 	qsize_t i_reserved_quota;
 #endif
+	spinlock_t i_block_reservation_lock;
 
 	/* Lock protecting lists below */
 	spinlock_t i_completed_io_lock;
@@ -1153,8 +1154,6 @@ struct ext4_inode_info {
 	struct list_head i_rsv_conversion_list;
 	struct work_struct i_rsv_conversion_work;
 
-	spinlock_t i_block_reservation_lock;
-
 	/*
 	 * Transactions that contain inode's metadata needed to complete
 	 * fsync and fdatasync, respectively.
-- 
2.39.2


      parent reply	other threads:[~2025-01-21  7:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  7:10 [PATCH v2 0/8] ext4: fix issues caused by data write-back failures libaokun
2025-01-21  7:10 ` [PATCH v2 1/8] ext4: replace opencoded ext4_end_io_end() in ext4_put_io_end() libaokun
2025-01-21  7:10 ` [PATCH v2 2/8] ext4: do not convert the unwritten extents if data writeback fails libaokun
2025-01-21  7:10 ` [PATCH v2 3/8] ext4: reject the 'data_err=abort' option in nojournal mode libaokun
2025-01-21 11:37   ` Jan Kara
2025-01-21 12:11     ` Baokun Li
2025-01-21  7:10 ` [PATCH v2 4/8] ext4: extract ext4_check_nojournal_options() from __ext4_fill_super() libaokun
2025-01-21 11:04   ` Jan Kara
2025-01-21 11:22     ` Baokun Li
2025-01-21  7:10 ` [PATCH v2 5/8] ext4: abort journal on data writeback failure if in data_err=abort mode libaokun
2025-01-21 11:13   ` Jan Kara
2025-01-21 11:43     ` Baokun Li
2025-01-21  7:10 ` [PATCH v2 6/8] ext4: update the descriptions of data_err=abort and data_err=ignore libaokun
2025-01-21 11:14   ` Jan Kara
2025-01-21  7:10 ` [PATCH v2 7/8] ext4: remove unused member 'i_unwritten' from 'ext4_inode_info' libaokun
2025-01-21  7:10 ` libaokun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121071050.3991249-9-libaokun@huaweicloud.com \
    --to=libaokun@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=libaokun1@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®