From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 477B0192B63 for ; Tue, 21 Jan 2025 08:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737449676; cv=none; b=MwMhSyCOxZBUeP4LDwKlRVg47JxRiDT76MmeeS5KncIXtgxyVXAoDwAsejuFP9qwzhThEEvm3RyqBAARWxyKSiyw+YWe6gAqxP4zQcUKJMg11RbToX0xkSJw07iAva2b0nOV356jRaRkq2NB+1A3DQR7LZV/2f5yxrBgqzMKi1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737449676; c=relaxed/simple; bh=Ji8EgcCcibQT3h+tgjcb0yX19I6k/8JfsGROrSoUSCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HxCjIa1jeuMHskUglUs86LNvMsI11Gc4E4HREezhQaHMriKSQ0stVcCVdzGpBmkMLMrn9pnwFh4WZgn4YENF6oYcNo51deaQDVjta7ugU7CxFWPtG2lEyedR8AIkEgZViETfrroekw6hWpBhSSERP+gkJbH2DrbKMe+MLPRHE3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=BuSWNcl9; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="BuSWNcl9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cYCq7VWlsf17HZjMd4BzuRbRgmVxe556YjNJKjyewvE=; b=BuSWNcl9sfm/7BIQIOrSWRzCRH OEfeu3nDjpheKH8YEqZNMsfeTdEow+ErBB5XrEJJaLKrEK/w/9NqM703+VEWh2+0jTq72Y2qb/nPD FNXU9vj0s/u/sSqZWZYxVtG+b9tAKM0CpRchcmYcHlsKpUfieUKRmhrQWaSNvQCY9AZ1ytT5bmMFo J32A6CmTKJCatvWyP3FuyeD8EgnhUtbA/ZZdoBAr81z8foH3etlHEsusDWgQ5SCh4fVRrb653I5YR 6yp2UJuJCij904X+t/Ir50deBh7arfT3arhPxJefDMQyBTtwN5V6u5gpTDHxRaoc8utjY58/i6Ckn DZ11gJsA==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1taA1Y-0000000DE4g-0e5U; Tue, 21 Jan 2025 08:54:16 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id B3F673006E6; Tue, 21 Jan 2025 09:54:15 +0100 (CET) Date: Tue, 21 Jan 2025 09:54:15 +0100 From: Peter Zijlstra To: David Hildenbrand Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call Message-ID: <20250121085415.GZ5388@noisy.programming.kicks-ass.net> References: <20250120024104.1924753-1-riel@surriel.com> <20250120024104.1924753-3-riel@surriel.com> <8de49f2c161085fdc63d8cc883cdebd3451df47f.camel@surriel.com> <543a134e-26ef-46c8-9f4e-c37e24dd7a25@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <543a134e-26ef-46c8-9f4e-c37e24dd7a25@redhat.com> On Tue, Jan 21, 2025 at 08:46:04AM +0100, David Hildenbrand wrote: > On 21.01.25 02:03, Rik van Riel wrote: > > On Mon, 2025-01-20 at 20:47 +0100, David Hildenbrand wrote: > > > On 20.01.25 03:40, Rik van Riel wrote: > > > > Every pv_ops.mmu.tlb_remove_table call ends up calling > > > > tlb_remove_table. > > > > > > > > > > Indeed, but the !CONFIG_PARAVIRT variant paravirt_tlb_remove_table() > > > however calls tlb_remove_page(). > > > > Patch 1/12 from this series removes that. > > > > After patch 1/12, we always call tlb_remove_table everywhere. > > This patch contains the hunk: > > -#ifndef CONFIG_PARAVIRT > -static inline > -void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) > -{ > - tlb_remove_page(tlb, table); > -} > -#endif > - > > That is the source of my confusion. Ah, that hunk should probably go to patch 1