From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE1F1AFB36 for ; Tue, 21 Jan 2025 08:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737447779; cv=none; b=Z+GHmNfEon/Cj4JHoyOR7zXtIEYv22IKelAYoKaaxfiPp+YmfivhtdutwlYBrvhd/rLHWA7ze+/rVOS4evnCxEsYVtbkW51I1rNmEX/JUGjr1GPCELv85437+LqHOdjyQvDJPHQPWsVQrJCvsIsOF1TIgLZNmi7JSDlKfy9qfNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737447779; c=relaxed/simple; bh=EnHEHoqfjpcybs3eQnlMVGMBOiuLHYPu/BHcIMvq5+o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FMfGeZpwmWjDnuLQfHhV1jUDQFjkebuN+nD1dcYqxy7y97lTPymd9CbtLUSzhTYXGgnADWEQKawOxw2Sv+WtWWL52K3oSwxKw2zioUwarTZh4S17jmTKAS9zCgbqzBzwSBKyZYE5yjxmQLm7C0oFfTHmeLQDqOQtcmyjmqjsgK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GSvpMHpF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GSvpMHpF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9545EC4CEDF; Tue, 21 Jan 2025 08:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1737447779; bh=EnHEHoqfjpcybs3eQnlMVGMBOiuLHYPu/BHcIMvq5+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GSvpMHpF0aovLhnJ4CZdrs5SjhFMFYRRxtGg0rEww2g0hXJH66/xTJuOSUrvqy4se Ftg/C1WqozOB7XVeg50wU9CJhd4JO/53GDk40L8RrBC08jIWxRrjQVEhPHvuSEAi2w nUlyVR2ZwJej4rdP3efMFrNEmis0UvIOPs2p+svw= Date: Tue, 21 Jan 2025 09:22:56 +0100 From: Greg Kroah-Hartman To: Petter Reinholdtsen Cc: lewart3@gmail.com, Alexander Usyskin , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: mei modalias files missing device name and newline Message-ID: <2025012120-dusk-remnant-da88@gregkh> References: <2025012125-document-osmosis-5f51@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 21, 2025 at 09:20:33AM +0100, Petter Reinholdtsen wrote: > [Greg Kroah-Hartman] > > There's no "requirement" that modalias sysfs files have to have a > > trailing newline, so why is this considered "missing"? > > This all started when it was discovered that after more than 8 years, > this one liner no longer worked as well as it used to: > > cat $(find /sys/devices -name modalias) | sort -u > > > Not all, most. If you want them all to, then we must sweep the whole > > tree and fix them up. And then deal with any fallout where that > > happens to break things :) > > >From my perspective, as the author of the isenkram package, it was the > introduction of entries without newlines that broke things, not the > other way around. So this file has always not had a newline on the end? Anyway, I'm not objecting to the change, but it needs to be submitted in a format we can apply it in, AND all other modalias files need to be fixed up as well to provide a \n on the end. The first one I found turned out not to have that, so out of a "random sample" that was either a lucky guess, or a sign that there is no consistancy here at all. thanks, greg k-h