From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC59A145A18 for ; Tue, 21 Jan 2025 08:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737446645; cv=none; b=tpk+r4uCU7se4EREo16sUCZRC8EfnKmC7ealw4tzQkfe0c/MsVG9AYjRopLmCh69wZUni7EDxehW6HYBK/0k4cydCZwlie5tSeUW1Vv29hMVPraDmV+tJijd/ZQLm0iunMv6vOJZaWscE7l2J0GiCzvt7h+3nMI6qUDo8+frXWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737446645; c=relaxed/simple; bh=0/4x5ZZ6b64dOt0vrxEGyGdfmA8ImEAzb2kyDDOB7AI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GowdaStSTvzfyxZ7wT8FeSHcU4RfwnChOoxUV/MY6qNYP4rVHCTRRIz04HN3FRYY5LfWERKhzKNbwmxjLt41IEpfrSvAXl8c65wPKunnY+Xa8mf8bSuawBKXpxP/Dlcy5NX4cQYMww+HxXIPo9D7gBvmbl6/4GFPjbyZrEaxFcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DhucpX4E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DhucpX4E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 055B6C4CEDF; Tue, 21 Jan 2025 08:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1737446644; bh=0/4x5ZZ6b64dOt0vrxEGyGdfmA8ImEAzb2kyDDOB7AI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DhucpX4Eq9dLuRy6N4GHiZQ860O7GqhIj96Pw93tazmN+F6xMsme0xTY83A4G3tcI FA1+6ZDDt/U9jjbBNV8M/EU5lM+htH6j7jVEQSw429h/ycWXA09+TWackDj5v8qmq7 IVTD8HrvRFqKEHlN1iJ2EPYWS9H1/LmAbWby/+5g= Date: Tue, 21 Jan 2025 09:04:01 +0100 From: Greg Kroah-Hartman To: lewart3@gmail.com Cc: Alexander Usyskin , Arnd Bergmann , linux-kernel@vger.kernel.org, Petter Reinholdtsen Subject: Re: mei modalias files missing device name and newline Message-ID: <2025012125-document-osmosis-5f51@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 20, 2025 at 05:30:04PM -0600, Daniel Lewart wrote: > mei modalias files are missing the following: > * device name (cldev->name) Where is the name required in the modalias file for mei? > * trailing newline There's no "requirement" that modalias sysfs files have to have a trailing newline, so why is this considered "missing"? > Original Debian bug: > #1091997 - isenkram: Documentation for locating all modalias strings is incorrect > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091997 > > I couldn't find any documentation that modalias files require a newline, > but all non-mei files do. Not all, most. If you want them all to, then we must sweep the whole tree and fix them up. And then deal with any fallout where that happens to break things :) > > $ lspci -s 00:16.0 -v > 00:16.0 Communication controller: Intel Corporation Alder Lake PCH HECI Controller (rev 01) > DeviceName: Onboard - Other > Subsystem: Micro-Star International Co., Ltd. [MSI] Alder Lake PCH HECI Controller > Flags: bus master, fast devsel, latency 0, IRQ 138, IOMMU group 8 > Memory at 6001145000 (64-bit, non-prefetchable) [size=4K] > Capabilities: > Kernel driver in use: mei_me > Kernel modules: mei_me > > $ find /sys/devices -name modalias -print0 | xargs -0 file | \ > sed -n 's/: *ASCII text, with no line terminators$//p' | \ > sort | xargs head > > ==> pci0000:00/0000:00:16.0/0000:00:16.0-082ee5a7-7c25-470a-9643-0c06f0466ea1/modalias <== > mei::082ee5a7-7c25-470a-9643-0c06f0466ea1:00: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-309dcde8-ccb1-4062-8f78-600115a34327/modalias <== > mei::309dcde8-ccb1-4062-8f78-600115a34327:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-3c4852d6-d47b-4f46-b05e-b5edc1aa440e/modalias <== > mei::3c4852d6-d47b-4f46-b05e-b5edc1aa440e:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-42b3ce2f-bd9f-485a-96ae-26406230b1ff/modalias <== > mei::42b3ce2f-bd9f-485a-96ae-26406230b1ff:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-55213584-9a29-4916-badf-0fb7ed682aeb/modalias <== > mei::55213584-9a29-4916-badf-0fb7ed682aeb:02: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-5565a099-7fe2-45c1-a22b-d7e9dfea9a2e/modalias <== > mei::5565a099-7fe2-45c1-a22b-d7e9dfea9a2e:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-6861ec7b-d07a-4673-856c-7f22b4d55769/modalias <== > mei::6861ec7b-d07a-4673-856c-7f22b4d55769:02: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-8c2f4425-77d6-4755-aca3-891fdbc66a58/modalias <== > mei::8c2f4425-77d6-4755-aca3-891fdbc66a58:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-8e6a6715-9abc-4043-88ef-9e39c6f63e0f/modalias <== > mei::8e6a6715-9abc-4043-88ef-9e39c6f63e0f:02: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04/modalias <== > mei::b638ab7e-94e2-4ea2-a552-d1c54b627f04:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-dba4d603-d7ed-4931-8823-17ad585705d5/modalias <== > mei::dba4d603-d7ed-4931-8823-17ad585705d5:01: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-dd17041c-09ea-4b17-a271-5b989867ec65/modalias <== > mei::dd17041c-09ea-4b17-a271-5b989867ec65:02: > ==> pci0000:00/0000:00:16.0/0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1/modalias <== > mei::fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1:01: > > Below is a patch for Linux kernel 6.13 which provides the missing newline. Can you look at the documentation for how to submit patches and fix it up to be in a format that we can apply it in? > I don't know how to provide the missing device name. Why do you feel it is missing and what requires it? And wouldn't that be breaking the user/kernel api if you add it? thanks, greg k-h