From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail115-80.sinamail.sina.com.cn (mail115-80.sinamail.sina.com.cn [218.30.115.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D1D381AF for ; Thu, 23 Jan 2025 11:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.80 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737631906; cv=none; b=GeyMO7tKX0u8awVcocmBYUwLvP7Ttpcq8RzD0J54FBrjWKSfHn4mEQHNEi2+9emHe9dMKLmh9kkPGG1NOwkjL2YU/aRSiE7lQcCZlEylkXf7Czs8EXkOEaQmgQLFJdA1AsRPX63/waPiqhxHYgRwwJlA/Uv+TdXSXyC5lA+qM8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737631906; c=relaxed/simple; bh=Uv8mnHxB99BDnN/jcK2oMGZVh92DP4bBmu6x2slmrfU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FvN1IosWCZxeA8Mkj9ZzlHDscogYL2P1LxbGV9Fdnh+TVD8X//OyCpVM6zAsapDW5jvI2cbYRHefSQn1d60OO1ijbdHDDF6cOYTt5gEVRMz1e0fQ1JaWG8zIOd/EBAVKLQy0T0bmxngfkNNfrMCXv/LPBD8BgzghfMYzNZU91rM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.88.51.154]) by sina.com (10.185.250.23) with ESMTP id 6792289200006DDE; Thu, 23 Jan 2025 19:31:32 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 6152398913369 X-SMAIL-UIID: 8980A4B6B4484B34B72C42FDD435C30C-20250123-193132-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [usb?] general protection fault in status_show Date: Thu, 23 Jan 2025 19:31:22 +0800 Message-ID: <20250123113123.1744-1-hdanton@sina.com> In-Reply-To: <6789f53f.050a0220.20d369.0054.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 16 Jan 2025 22:14:23 -0800 > syzbot found the following issue on: > > HEAD commit: be548645527a Merge tag 'for-linus' of git://git.kernel.org.. > git tree: upstream > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12d51cb0580000 #syz test --- x/drivers/usb/usbip/vhci_sysfs.c +++ y/drivers/usb/usbip/vhci_sysfs.c @@ -76,6 +76,8 @@ static ssize_t status_show_vhci(int pdev } hcd = platform_get_drvdata(pdev); + if (!usb_hcd_is_primary_hcd(hcd)) + return 0; vhci_hcd = hcd_to_vhci_hcd(hcd); vhci = vhci_hcd->vhci; --