From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dirk VanDerMerwe <dirk.vandermerwe@sophos.com>,
Vimal Agrawal <vimal.agrawal@sophos.com>,
kernel-dev@igalia.com,
Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Subject: [PATCH 3/4] char: misc: restrict the dynamic range to exclude reserved minors
Date: Thu, 23 Jan 2025 09:32:48 -0300 [thread overview]
Message-ID: <20250123123249.4081674-4-cascardo@igalia.com> (raw)
In-Reply-To: <20250123123249.4081674-1-cascardo@igalia.com>
When this was first reported [1], the possibility of having sufficient
number of dynamic misc devices was theoretical.
What we know from commit ab760791c0cf ("char: misc: Increase the maximum
number of dynamic misc devices to 1048448"), is that the miscdevice
interface has been used for allocating more than the single-shot devices it
was designed for.
On such systems, it is certain that the dynamic allocation will allocate
certain reserved minor numbers, leading to failures when a later driver
tries to claim its reserved number.
Fixing this is a simple matter of defining the IDA range to allocate from
to exclude minors up to and including 15.
[1] https://lore.kernel.org/all/1257813017-28598-3-git-send-email-cascardo@holoscopio.com/
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
drivers/char/misc.c | 4 +++-
include/linux/miscdevice.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 2cf595d2e10b..7a768775e558 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -68,8 +68,10 @@ static int misc_minor_alloc(int minor)
int ret = 0;
if (minor == MISC_DYNAMIC_MINOR) {
+ int max = DYNAMIC_MINORS - 1 - MISC_STATIC_MAX_MINOR - 1;
/* allocate free id */
- ret = ida_alloc_max(&misc_minors_ida, DYNAMIC_MINORS - 1, GFP_KERNEL);
+ /* Minors from 0 to 15 are reserved. */
+ ret = ida_alloc_max(&misc_minors_ida, max, GFP_KERNEL);
if (ret >= 0) {
ret = DYNAMIC_MINORS - ret - 1;
} else {
diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
index 69e110c2b86a..911a294d17b5 100644
--- a/include/linux/miscdevice.h
+++ b/include/linux/miscdevice.h
@@ -21,6 +21,7 @@
#define APOLLO_MOUSE_MINOR 7 /* unused */
#define PC110PAD_MINOR 9 /* unused */
/*#define ADB_MOUSE_MINOR 10 FIXME OBSOLETE */
+#define MISC_STATIC_MAX_MINOR 15 /* Top of first reserved range */
#define WATCHDOG_MINOR 130 /* Watchdog timer */
#define TEMP_MINOR 131 /* Temperature Sensor */
#define APM_MINOR_DEV 134
--
2.34.1
next prev parent reply other threads:[~2025-01-23 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 12:32 [PATCH 0/4] char: misc: improve test and dynamic allocation Thadeu Lima de Souza Cascardo
2025-01-23 12:32 ` [PATCH 1/4] char: misc: improve testing Kconfig description Thadeu Lima de Souza Cascardo
2025-01-23 12:32 ` [PATCH 2/4] char: misc: add test cases Thadeu Lima de Souza Cascardo
2025-02-20 14:32 ` Greg Kroah-Hartman
2025-01-23 12:32 ` Thadeu Lima de Souza Cascardo [this message]
2025-02-20 14:31 ` [PATCH 3/4] char: misc: restrict the dynamic range to exclude reserved minors Greg Kroah-Hartman
2025-02-20 14:52 ` Thadeu Lima de Souza Cascardo
2025-02-20 15:05 ` Greg Kroah-Hartman
2025-01-23 12:32 ` [PATCH 4/4] char: misc: deallocate static minor in error path Thadeu Lima de Souza Cascardo
2025-02-20 12:11 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250123123249.4081674-4-cascardo@igalia.com \
--to=cascardo@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dirk.vandermerwe@sophos.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vimal.agrawal@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®