From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E8E146593 for ; Thu, 23 Jan 2025 19:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737659009; cv=none; b=hvDVRbO2gfzsjWx+N1y/gwZZFd8ZYm8O/fwNK5dO3Uq+lgWuBwOHogP7oIy5RuLEDzzeIy+YbduE4EUMMh7XD9hi3Lut7vZ9j6yOZN4zV0WOv3EWL5f5V191xYpDwTzTAZyrIiow2MhUb68piaUYV1gGgjc+gKs90oBzKmW+7i8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737659009; c=relaxed/simple; bh=9xvr8n6UrzZbP3DepcR70iZSfVrRAMkFoC7Jinr6gLI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NecxG6MT4b5Fdn/6AKR73be0Ff6ik6OatnDsOBKZZ+YJhNH7DTm5Fs1PsDAzrGN5GmH/hGBbeADabRZn6tWuf0Ishsu5U7/YnRNRxB4SBFzwFGrcHRfmcicZXm+cIr+roE5Se23x8ALg4KJ6ZJZFcUkEh6qCMU3hAde1RRG5SbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=bVcZ0wWf; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="bVcZ0wWf" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7bcf33f698dso104720685a.2 for ; Thu, 23 Jan 2025 11:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1737659007; x=1738263807; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D+xv3aQ28zuD+yx3iUQYH9XPq3JQRzFl6Pk/+H7aPjI=; b=bVcZ0wWfdsmzDHy05u7p57fYbxRhT30wdeIpSEcuzU6lNoeVng+7tP31wHFEYvd+dO qAIvsMqHC42CCC9zsT2ahNAnthO8UfwmrgjHAyxhP0LCbjc07gUQ6TGNbbUx0+N+2SO5 Z6c3akWDLYNt0VQvEcF4p+yCxXem4sJ2LqrPq2TeovZrU008OAIR0aE54XSNdPtvkwvQ +dsqDvBc+M0W6LsRAh3OedAki2SxTFdGyA/EkrW5QY9S3A3wR7RmT7ACjyrBysvwMLCR YtUVtVzutCPwrDsiveud5efdvCJTqpv3zx5mC0H1xDsDaw5LTp7vZAfcofoojupGVJXF OcXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737659007; x=1738263807; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D+xv3aQ28zuD+yx3iUQYH9XPq3JQRzFl6Pk/+H7aPjI=; b=owYx5yHzYtpaQpAs9X4B7WLOfIALsSt+ZpejqptJ8qTONkz1XCt81sTu5xsGAY+m9C ZyewtupWX3xbwfRVzHVhMHDblLEhe69Mbt/QgPhT7BAWmC+kPruWoAYuInkF47VYxMSI utLh+hCp5ZnmUhImo2bFjwmg0pENemjP8bNqaUZOXuzAVOq1hULmkAs5nd+2KlWF1JP0 4kWKYy4wWXt7+w1bcFqJPm/u9aCblk9vPWwe2+h/CI4ZodU9gPwlXHipePaEhZt4+cVe Uk+hQsGEZh9o1kpOKyjnHzpXiHUpgX9x52aMLTq+mavyXtj1kyUvGGUa9vB7dmH2FA2W HKPA== X-Forwarded-Encrypted: i=1; AJvYcCWOJn5X8F7zNv+cW6yaTZ60lKlZ/onRl1JoAGzMgZ13Bf0fM1oPnfunrK7EGMurFaNibuB0+WMmrZF3V8U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyfa9U5BGeWC8bKgCDglYlXLgOaziihNNb89BrPhR8jzxfH70A1 h7SfJQaDflhVRREbLqTTsyloqvIo2uMJazxQnednGnFzkFWdTARDUMT5DtGCvGw= X-Gm-Gg: ASbGncv+wFarfkWCy8aJzWrJ0zMBYvM49if+DSyRCRKpImD13X/mpyIWqfpb+zPOUsK HSwsNUfVTbJJrJCQMmFREE4U3yvpfNibHWgwqrDd4+zposcQ8KN/i39ScR0ZSDWXofd2p6HM0jn KGFKCBvBFJ9Y80nS5v9uoE+k56RIGQCDjjdseOUYuatcH+4A8oJDjmH1aDH6LUxWqiwEQ0eatzF ElQlmSoyCE5+DDj0otpG53Pv+2VrxDt64V6SGP3GnELBQ88TDikD0Tz57CBzmsSmjjWnkMzKzjm Kq6hmUmWKpxVdIGw2hIufiv8jZrbwEH7K44TDhv3HysvOjWsHXuH7w== X-Google-Smtp-Source: AGHT+IFTRghqqIXFOqUm271sNPa/tDjd1nY5Cax8bJJRYW66zoKgdnjNpNKayefg6gHqaABR0AtkPA== X-Received: by 2002:a05:620a:370d:b0:7b6:fdb9:1be6 with SMTP id af79cd13be357-7be63249e21mr3577306585a.29.1737659006971; Thu, 23 Jan 2025 11:03:26 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be9aeedbadsm13482185a.71.2025.01.23.11.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2025 11:03:26 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tb2U9-00000004Quy-1OCe; Thu, 23 Jan 2025 15:03:25 -0400 Date: Thu, 23 Jan 2025 15:03:25 -0400 From: Jason Gunthorpe To: Long Li Cc: Konstantin Taranov , Konstantin Taranov , Shiraz Saleem , "pabeni@redhat.com" , Haiyang Zhang , KY Srinivasan , "edumazet@google.com" , "kuba@kernel.org" , "davem@davemloft.net" , Dexuan Cui , "wei.liu@kernel.org" , "sharmaajay@microsoft.com" , "leon@kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-hyperv@vger.kernel.org" Subject: Re: [PATCH rdma-next 09/13] RDMA/mana_ib: UD/GSI work requests Message-ID: <20250123190325.GX674319@ziepe.ca> References: <1737394039-28772-1-git-send-email-kotaranov@linux.microsoft.com> <1737394039-28772-10-git-send-email-kotaranov@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 23, 2025 at 06:20:34PM +0000, Long Li wrote: > > + shadow_wqe = shadow_queue_producer_entry(&qp->shadow_rq); > > + memset(shadow_wqe, 0, sizeof(*shadow_wqe)); > > I would avoid using memset since this is on data path. The compiler often does an amazing job with constant size small length memsets. Jason