From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400511ADC70 for ; Thu, 23 Jan 2025 20:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.245 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737662779; cv=none; b=CSa32e5PrFWTN7pduHerDdZwGIS1ux4oY29MBseO9kvBS1FBN1VzJy3hlVaJDGu2+MVR72v+RBdBHzDvdVOFXitvNRfbZ8bcfl6TfWc7+uFjiwQErRBEPEy4nbw1xcswKEry2/RgKh3VTat7pO6Cp3MtLCUKn2PEwPkQ5oPEktA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737662779; c=relaxed/simple; bh=p0/5wEBISBD1cBruGIo1VMCwzppJ9jF4fZ9NFPAO8+Y=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tIW59S9P/F39ox3bse12DlHBn5CydkgVyjJigOJimZfSbgEvPZpPImQ1Ca20rHST2us6tur75gS4a9G2I0raAzW+wq/wv1qfXD/IwXe6q6qA5qhK+Gezmz4S/V2ddi37oSyMlLcTMBFSI4aly4Mof/nVwm1LEIlrnUeyBDxje1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=NhI5IAWy; arc=none smtp.client-ip=198.47.19.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="NhI5IAWy" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 50NK69hY1231541 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jan 2025 14:06:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1737662769; bh=oYuwtqx4a6F9C+tImobQ3bGq2hD/7a9uKAeUF4MRwSM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=NhI5IAWyvNZVElOR2kIWtHz8ao/6zLnRnTygEfOIPMwhQcC9L/Kh1BUk3R/JUNJ0S lWiPICjNs5TxAPpx7/IGuxyYkltI+l1nYEUe1zbwe341tV5/0N1i0N5M1T4qMk/I4M V+Eg0lDlOoql+xezQc55McjXvDsP6F9Qh/DWQiVM= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 50NK69cl017887 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Jan 2025 14:06:09 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 23 Jan 2025 14:06:09 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 23 Jan 2025 14:06:09 -0600 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 50NK69i5024992; Thu, 23 Jan 2025 14:06:09 -0600 Date: Thu, 23 Jan 2025 14:06:09 -0600 From: Nishanth Menon To: Andrew Davis , Vinod Koul CC: Vignesh Raghavendra , Vinod Koul , Kishon Vijay Abraham I , , , "Rob Herring (Arm)" , Lee Jones Subject: Re: [PATCH] phy: ti: gmii-sel: Do not use syscon helper to build regmap Message-ID: <20250123200609.mjdts4opcrrvzy2s@stunning> References: <20250123182234.597665-1-afd@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250123182234.597665-1-afd@ti.com> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 12:22-20250123, Andrew Davis wrote: > The syscon helper device_node_to_regmap() is used to fetch a regmap > registered to a device node. It also currently creates this regmap > if the node did not already have a regmap associated with it. This > should only be used on "syscon" nodes. This driver is not such a > device and instead uses device_node_to_regmap() on its own node as > a hacky way to create a regmap for itself. > > This will not work going forward and so we should create our regmap > the normal way by defining our regmap_config, fetching our memory > resource, then using the normal regmap_init_mmio() function. > > Signed-off-by: Andrew Davis > --- Tested-by: Nishanth Menon Vinod, This is part of the fixes TI K3 platforms boot issues reported in https://lore.kernel.org/all/b2413460-ec8b-4c77-99b8-4c32b262439a@ti.com/ on the latest linus master v6.13-5001-gd0d106a2bd21 + linux next-20250123 Total set of patches tested with: https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/ https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com https://lore.kernel.org/r/20250123181913.597304-1-afd@ti.com https://lore.kernel.org/r/20250123182059.597491-1-afd@ti.com https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com Could we get this routed to master as fixes asap please to get a sane 6.14? Cc Rob and Lee > drivers/phy/ti/phy-gmii-sel.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c > index e0ca59ae31531..ff5d5e29629fa 100644 > --- a/drivers/phy/ti/phy-gmii-sel.c > +++ b/drivers/phy/ti/phy-gmii-sel.c > @@ -424,6 +424,12 @@ static int phy_gmii_sel_init_ports(struct phy_gmii_sel_priv *priv) > return 0; > } > > +static const struct regmap_config phy_gmii_sel_regmap_cfg = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > +}; > + > static int phy_gmii_sel_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -468,7 +474,14 @@ static int phy_gmii_sel_probe(struct platform_device *pdev) > > priv->regmap = syscon_node_to_regmap(node->parent); > if (IS_ERR(priv->regmap)) { > - priv->regmap = device_node_to_regmap(node); > + void __iomem *base; > + > + base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(base)) > + return dev_err_probe(dev, PTR_ERR(base), > + "failed to get base memory resource\n"); > + > + priv->regmap = regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg); > if (IS_ERR(priv->regmap)) > return dev_err_probe(dev, PTR_ERR(priv->regmap), > "Failed to get syscon\n"); > -- > 2.39.2 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D