From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662031CAA9F for ; Fri, 24 Jan 2025 11:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737717275; cv=none; b=n5nXFGMX1tgYz6SVeHf8H5LYGa/JOTOQ6gFhYUT3OjyhU+rJDbZfu+50FuZ6PckK2sKS5ktck1NJQm8zXspo8Jclh78Z15a26BVvnSCn+E+qIThUWUjqkT0teA5UvIioA0nboGcTsvOjfGRrid+wd50wosMV54R1GMreoecHtRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737717275; c=relaxed/simple; bh=OpiIQKhcNoT2pcXvUCeespOUMvgnpvQ7UQxxU9Ketjc=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=B5XNaz8JJ2KBiCiy7mqfQG/zRBCkcYFooSwiH9uymawy6XSYXEQiHNuz7zngKoAnkHt3zfY6PwFWkFE0dklOu4J45cJrvkMvU9V5gYrfFJB6xxZNZjLc7k2w1TvEVjrGYwjmjnZmaUfxOfLrQDefSxDNyvPGAqLqun4CaOpXeWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DTZpmYIu; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DTZpmYIu" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-305f529a987so14853861fa.2 for ; Fri, 24 Jan 2025 03:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737717271; x=1738322071; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=LyCh2co2HvzF8YB4tTCIA3m8yb9tduYDWXQJRjTUkgU=; b=DTZpmYIuI/XR4vrCkRhRnbb7Ma6ncmUtjMmPi5wHuZguXR/YA5UYMeh4lwr8DIitVz qwzUVsGTbVj+pqjQvnt4iWq3hkZW4KbNYqE3jLlhTEf2SkDHydLeFA7x1Hjl3X2qOXBB +MNcXniDrFK3JuaBW36lWGwA+a93GdaSrm7SEiCWUdWjVW/QtByftBSotjE6GQem6IwY jsiWCbtDbR5IjYsqup6+UidMczEaNo8+mi6tvG4m38W3OlWCS7RX/hiM4JCnam5l8n1K 0PDLgIt1ZPsVmmy7jEZ5gDA7hkj7kz8BTDHG9v4YHivBywdlt0YfahQLNNwWwfT2Osh4 EvVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737717271; x=1738322071; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LyCh2co2HvzF8YB4tTCIA3m8yb9tduYDWXQJRjTUkgU=; b=gYEc/teE5dnCwRmpd+5l87YAsG422hatd3szWDzbV6Z2GhaR4g65/1SeL5/mWyygKo FbjiVUSmXI/LS2ocoT6oe+Cs8UUv/Veu5wG8BIiHzW5x11jETaHtCK3K/fh4w3DhMm+0 nsmW0CRY4VBOsAdoANr6ZtUMtpuwl1HSe+lVQuTsfhhUKOz1fkC8466MT6bBKp+i/nhp D935eDXh2Uveh8Mf/rPJLmAjYpYulv1i/wYK1IXuh7Vm6dygpSwVSK+t7WfCoEOX/6ot 3IO51co+H4hCWVt1A2Qp0A0vR2PkiOLl26cCyjgaseTCeaPYQEmZ+B/fzwn6BClYApyZ ftKA== X-Forwarded-Encrypted: i=1; AJvYcCWI3exS+HbePaSv7GqRCJst+NC5Y/yKfuU1q5NCCnXRStYHHOaw3HT4c70/tBdYOFgsT7x/OBPcS5MR8gg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmzth+n7TBxQpkwgsayLmR4o/od4gvZvM9qsiQIykm4+XPNNxp R/ulpjcpVWdRJZ7hGM8ezazMDA2Hjqd0wRE/Gjimo4BR0Mtz9CSp0RhKCi514vY= X-Gm-Gg: ASbGncsdsIXxW5mxNeivvUQMp7GCHC0iT2f7p43eX7tdmQSf2H07sc4pSvYjirdp+cI XxFOSXzUwIJLrwpxdmjYowsQUrgUbBD3tgXE8U/R+nwGsWHYaRcQ4cIU3/ZXw9++i8/lOJ8CCDW x4w4NDgzz6zksS/2P3nHPgg5H9prHqOWs8Gd8z0uCady9PVabKqvX5wFzCYnIEmXRp+9OyjViV+ BWqZZ6DUNA7QSG/PIPs4noxrVpszxgyMFeHxBsteeW4hrcJqsgoQndtf/z3niTIftOqatLJHutH QOOYgkA4Qkoh X-Google-Smtp-Source: AGHT+IFoNbxUK/2G34MFyhMrdJfvS1tCcfDhoh+IuspqzwkrE0uCkVu1DBJS2Mcfjmd/yuee9uL1Uw== X-Received: by 2002:a05:651c:221f:b0:302:34da:ac30 with SMTP id 38308e7fff4ca-3072caa0b37mr132017841fa.18.1737717271258; Fri, 24 Jan 2025 03:14:31 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3076bacba5esm3289701fa.36.2025.01.24.03.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 03:14:30 -0800 (PST) From: Dmitry Baryshkov Subject: [PATCH 0/6] drm: introduce atomic_needs_modeset() callbacks Date: Fri, 24 Jan 2025 13:14:18 +0200 Message-Id: <20250124-atomic-needs-modeset-v1-0-b0c05c9eda0f@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAp2k2cC/02O0Q6CMAxFf2Xps4tQUHC/YngYW9E+jOk2CYbw7 06J0bee5vb0LhApMEVQYoFAE0f2Y4ZyJ8Bc9XghyTYzYIGHosRK6uQdGzkS2SidtxQpyXY46hb rSldDA/n0Fmjg+aM9dxsHuj+yPW1L6HUkabxznJSwwUnH0ey/Q9bPCf47KJEb1CUiynfIckjP3 /u2aE69xUbTUU0I3bq+AB/3PmvZAAAA X-Change-ID: 20250123-atomic-needs-modeset-8f6a8243a3f7 To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Airlie , Jocelyn Falempe , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Kalyan Thota Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Simona Vetter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2722; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=OpiIQKhcNoT2pcXvUCeespOUMvgnpvQ7UQxxU9Ketjc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnk3YUy/SptSSxfa7unzJaW4XkVKCxp42DKSXo+ H/zIR+fvTWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ5N2FAAKCRCLPIo+Aiko 1RqjB/9hik2csnpKagfc4l6vaAEGXHOlJSRo3+qbDo95PTdip6kPT1+hisOnFKBhiKB8i+qCewy mmSuvtgx3t8Wcw7R3U5uwZlKWYp0rUIK2oHhjvTUBHrzYry/qk6tcFv4lt+n/ELOIvVXCFFqC3w xaHRjujTQ72+JqlND6FYo5paMDxND6aEeLpr41RDRQbJOMhcPDszRAQlrG+cC4mxrZzALUZP/Lj ljU236y6HOi9DET+sDuBGKdgwwGR1SFp3uVv6EYg5PS6A808SbAMQ4EPfDL+JANnLjC31ZQp6AW 9MPA5C6mhlxxJCCQXI4Iu8szZb/Pkjf58pIZLVPm8GF+3aAg X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A There are several drivers which attempt to upgrading the commit to the full mode set from their per-object atomic_check() callbacks without calling the drm_atomic_helper_check_modeset() or drm_atomic_helper_check() again (as requested by those functions). As discussed on IRC, add separate atomic_needs_modeset() callbacks, whose only purpose is to allow the plane, connector, encoder or CRTC to specify that for whatever reasons corresponding CRTC should undergo a full modeset. The helpers will call these callbacks in a proper place, adding affected objects and calling required functions as required. The MSM patches depend on the msm-next tree and the series at [1]. The plan is to land core changes through drm-misc, then merge drm-misc-next into msm-next and merge remaining msm-specific patches through the msm-next tree. [1] https://lore.kernel.org/dri-devel/20250123-drm-dirty-modeset-v2-0-bbfd3a6cd1a4@linaro.org/ Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (6): drm/atomic-helper: add atomic_needs_modeset callbacks drm/mgag200: move format check to drm_plane_helper.atomic_needs_modeset drm/msm/dpu: stop upgrading commits by enabling allow_modeset drm/msm/dpu: move CTM check to drm_crtc_helper.atomic_needs_modeset drm/msm/dpu: use atomic_needs_modeset for CDM check drm/msm: drop msm_atomic_check wrapper drivers/gpu/drm/drm_atomic_helper.c | 59 ++++++++++++++++++ drivers/gpu/drm/mgag200/mgag200_drv.h | 2 + drivers/gpu/drm/mgag200/mgag200_mode.c | 27 ++++++--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 44 +++++++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 4 -- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 26 -------- drivers/gpu/drm/msm/msm_atomic.c | 29 --------- drivers/gpu/drm/msm/msm_drv.h | 1 - drivers/gpu/drm/msm/msm_kms.c | 2 +- drivers/gpu/drm/msm/msm_kms.h | 7 --- include/drm/drm_modeset_helper_vtables.h | 92 +++++++++++++++++++++++++++++ 12 files changed, 219 insertions(+), 89 deletions(-) --- base-commit: 0936f0e54426177b0f0263ddf806ed5e13487db6 change-id: 20250123-atomic-needs-modeset-8f6a8243a3f7 prerequisite-change-id: 20241222-drm-dirty-modeset-88079bd27ae6:v2 prerequisite-patch-id: 0c61aabfcd13651203f476985380cbf4d3c299e6 prerequisite-patch-id: c6026f08011c288fd301676e9fa6f46d0cc1dab7 prerequisite-patch-id: b0cb06d5c88791d6e4755d879ced0d5050aa3cbf prerequisite-patch-id: fd72ddde9dba0df053113bc505c213961a9760da Best regards, -- Dmitry Baryshkov