From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EAA023B0 for ; Fri, 24 Jan 2025 11:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737717439; cv=none; b=YH2UH9LhZlgIe4JN2Pwaa8TChFbzh2cQ1auZFfMnkPKbLtLwJ45xaSuLNx0n+6hzCZtcFUHA1C8zJ4TIqcrHynKaqKMa4VxEM2I2IRuyQb0n0ZjmdkfTIUrhM6AVW92RuPXmambPlCerY/E0gHGlMGejwto0OTV8Heh1hMlfBOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737717439; c=relaxed/simple; bh=9zptOK9BGQ3fQ4IWt6tQmxVxGeYtZVHhKTOywc7Kx3w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TQaJoq/vZ9wUh4YMycQDrr+GHDgpv1qg36WlSATCHF0hIrZMR/vJWfx1RranX2XyMKMjLxzz7ult3naIiMkMeMyyXo5cSDtY0m81EhDof2H8+juEWD1yQzEUEy2Sd14n/3Vt6UjOh3FnBdiZv3al87oOTsFea15vZc5yiB9xFA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=khgu4iRC; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="khgu4iRC" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-436249df846so13017665e9.3 for ; Fri, 24 Jan 2025 03:17:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1737717435; x=1738322235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cVXKrB+O1fh/6+48GtXPh7iohUuDCptQ4J19ggAdm2o=; b=khgu4iRC6CzJix4AQQDixAj6KirH+KEF0uBml61hq5gNwq93tCRyB3vbxGhuhwu3mW XiGoksaXzZac37UD8q71YRRdRWCAhxn6/yeHCTsxRJm/q3cZ80acg0x56o2tR7RIQvXc CvHwqokbX9VOaV9m+I9pDYGuxuSdvdrlefPWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737717435; x=1738322235; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cVXKrB+O1fh/6+48GtXPh7iohUuDCptQ4J19ggAdm2o=; b=IWlPlfmkCNERBL9BOX2AJICjStnL7k/OVRdaq9GMvtD/VnLS0SiorCKyOYU7CgXr7L 3NHLiJNpD3j8awzCz+/4oItvsY6tn/rEHVjgS3gY/HQE1NqYROoIZkZkuuKIx0S4p1d7 gpY3EYVh71UA7F54iy/F6jX2kEjZHuIwxe34DOaoEEjouT9pcwjZXiFO5lYb0bDxIG8x BXI8EeKKJHlSLLXQjZ4IYbQw0hB5KAh8wsB6BBGPJveQaoUUsYJ6plvcbrevftQM6ajc tbY9ENXRrYHnvbTn0lWShqP7YwxF3UThJwmqNjjKN8PVROEd75VBpoXNSXLj2+KgCSCU mbBQ== X-Gm-Message-State: AOJu0Yyo43uUAz7iZEnkbeXfE447IsxZaBv0ZLcP5V6CY4ZpeOCuJH6l OxfaN+pnjEu+nOxCaf5VeTEMnKj7S3iq8GCPKwvEKlMN1V3CdTHr+qTep41Tvu8onjOR1T+zwtJ N X-Gm-Gg: ASbGncuctpBftvZxI347qFdjZfiNhI5ZhlbDxbRYlv4scKXdSnKMKpnhlgjjml5DmzO 89d3WxL3bVg27eLQp7cD/9kipFwwCkWUUYYffZeJkUXqW3DVbt7mDMAAWX266qghk9/MMy3YKbj sJO5zYBQ1/L8apeXSJYnRU2VNB2Z8izEeaLBtI1ocFIANqzZiN5ZJq0gbumTzEHJEUCqEQLru4U F5SMXdfW/3TvM2fIm2HC2U3YZI6dlTkTtOyOsIbkhCCrfyxAnNe4p1VSpPoFRUJaSwiqwWSpYci O4WtHdof6aBFGXUCjDSOVjDtOAe6RjyS6XH+uJ+log== X-Google-Smtp-Source: AGHT+IF7P9coZufZpIyRLi78wcbOmVrALszhypBmaNuECTkf3A9PTixnF+7VqbmWI7lij1JXG+mT6Q== X-Received: by 2002:a05:6000:1a8c:b0:38a:888c:6786 with SMTP id ffacd0b85a97d-38bf57c063fmr27161921f8f.52.1737717435139; Fri, 24 Jan 2025 03:17:15 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:a445:7786:b555:5259]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188bf5sm2431547f8f.50.2025.01.24.03.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 03:17:14 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Dan Carpenter , Alexandre Torgue , Maxime Coquelin , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH] clk: stm32f4: fix an uninitialized variable Date: Fri, 24 Jan 2025 12:16:54 +0100 Message-ID: <20250124111711.1051436-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable s, used by pr_debug() to print the mnemonic of the modulation depth in use, was not initialized. Fix the output by addressing the correct mnemonic. Fixes: 65b3516dbe50 ("clk: stm32f4: support spread spectrum clock generation") Reported-by: Dan Carpenter Signed-off-by: Dario Binacchi --- drivers/clk/clk-stm32f4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index f476883bc93b..85e23961ec34 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -888,7 +888,6 @@ static int __init stm32f4_pll_ssc_parse_dt(struct device_node *np, struct stm32f4_pll_ssc *conf) { int ret; - const char *s; if (!conf) return -EINVAL; @@ -916,7 +915,8 @@ static int __init stm32f4_pll_ssc_parse_dt(struct device_node *np, conf->mod_type = ret; pr_debug("%pOF: SSCG settings: mod_freq: %d, mod_depth: %d mod_method: %s [%d]\n", - np, conf->mod_freq, conf->mod_depth, s, conf->mod_type); + np, conf->mod_freq, conf->mod_depth, + stm32f4_ssc_mod_methods[ret], conf->mod_type); return 0; } -- 2.43.0