From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E4363C0B for ; Fri, 24 Jan 2025 12:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737722846; cv=none; b=oFoo+T+8pLaMozSJ37opthwjRTc0dhO3GSzGJ3RZalzmKHI82qgt5g4TYjR3vLNdiCVgc+/AmjV33Lrk+wpq7Bz5MPmm3bCIMR5AYvAeFVwzMSJl1LJzpyPDgfqJgttnO01UFsccChxSfNH+vKPyNJXu7v96Fu9ctbGKAVaxPaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737722846; c=relaxed/simple; bh=DsS9Qhk1JgJvFvJVluXZgQGiSzbB01yBWsUHv+o53ts=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=upICq5h8GV5AucjbhLFuC7BELDaE04uXpyZw/G4MVzFKifJiDVroFGCM3nm1jhb6L/oWBnoYOzRrrh9/oVodiI7wcs3xVNG6UNN+6aLheO+5O/GKZ6l7gqcf6u1VXagMEL6EdHyrlqYeLnjy+NdIEBVOK5UACByA7Ii/Z5aVTlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iUirqGiQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iUirqGiQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737722842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sUFa3BHRM1lCZt1AxF1frfdVKD8rPIbxarCScvHGYqE=; b=iUirqGiQ4ffZWIms3xBWDCcG3xV9lwf8Z+X+0p0WKWwbtdzrSQZzp3mdcV0u1wi9n7jEaz pwSrqJiKuKyZpaBs2K481fCFQNmGhABYoUm+kvrMCLja4ZeAFjsNLEIJE1THcVbiENAzsY /cz4+xB+xQvO2/DjByRtA0b7FhJ1KfQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-EMTqmSZIMoGLHMM1xo7CUw-1; Fri, 24 Jan 2025 07:47:21 -0500 X-MC-Unique: EMTqmSZIMoGLHMM1xo7CUw-1 X-Mimecast-MFC-AGG-ID: EMTqmSZIMoGLHMM1xo7CUw Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385e2579507so935318f8f.1 for ; Fri, 24 Jan 2025 04:47:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737722840; x=1738327640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sUFa3BHRM1lCZt1AxF1frfdVKD8rPIbxarCScvHGYqE=; b=KrK7AFMWoAwXopccEWyDKPYCPM8/dAuiG9QSUnLpJ6PbsILN81DSfusf9NKBgRsxrP HMFtR6Q1VFcgTVSQB4K/HKKKDZuXZNHUj3n8rKmcufDM+H1w6h+5GA+uExnD+LwJFAAj r6LYlBYTjD0HjUsqAjpCt5RLr6vOx1ev8VvJi3sVcaea7SrUKjHagltgiRkRd3tm6QZ5 Wi9Hk6PBIOWjxTHUv5qVb9WHUFK2oceQv6NzGjFy0iWfC+bUHF3KzMHAeesazK1GxIfM vXzuMpl1aEBAz4vE8WxqRHCvn4qZyBNq+OaO6ugWYTXrS1TCCmEwL4Yh0xaPVc+9kyxj rAJA== X-Forwarded-Encrypted: i=1; AJvYcCWTOHBalh+1nRo8Xy8SSZFQfhNUmtBNlnAMfpLYHkGpAFPjP2caX6Y73Pd66T3l+FzH/Dj4lkV7ecEDHCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz12QFMMH3n34yxE3p8zxI9Q48U6a4RQkfDTKQoVGq7Wju5R5Gb fg668XL8uR2ZW/KB4zvqtvcYTFgCcA3AUJtKUfXsAUlj0/ZJVuqGhkts1PNYSfYkdHz75O3blzL KVkuBTyft3PARDLbkstzMF9V1Z6hw3yQGLYqNvqZPEq2WRD15zq/gQt37adDu5w== X-Gm-Gg: ASbGncvF+m7tPbkwnWp4kEQqc8nCo02k/I6I7olH0IFjWmDOXAWVIyt8hkOW9OFLJkW QsqFDxoWIsIjVDVwGr8esNHULIp8cJVJ+UAiS8Jik3uZ1ScFJwXqDgp2QnUupQafqsGEyYHE25O BRQCDiM65QRQ9Lvv4D2qclzcIKu6txHY+EtPiML8rlj88lLA3UPrumbJ8SU498CYm/qNOWguUvP 2mMjnRE+xX4t1/ZaYHdf/sczPl/oJ+Ar6+Da3W+6Ilho+H++kf5eAg/MROYVJ5BrNnrQOMdQjQ+ Bkr6mfMe2Zrgq3R+dXVkzcZE3K9txH63NzzdPgmiBw== X-Received: by 2002:a5d:64c9:0:b0:385:f220:f788 with SMTP id ffacd0b85a97d-38bf57bbfa5mr29250397f8f.48.1737722840118; Fri, 24 Jan 2025 04:47:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIa/qJYb53I8CRY29wjjcU5tWAwqCN40ac1gjQdm+m09Yx/dchLdoDyW0UVw2aF0l1aHWnfw== X-Received: by 2002:a5d:64c9:0:b0:385:f220:f788 with SMTP id ffacd0b85a97d-38bf57bbfa5mr29250366f8f.48.1737722839737; Fri, 24 Jan 2025 04:47:19 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1c402esm2610633f8f.97.2025.01.24.04.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 04:47:19 -0800 (PST) Date: Fri, 24 Jan 2025 13:47:18 +0100 From: Igor Mammedov To: Mauro Carvalho Chehab Cc: "Michael S . Tsirkin" , Jonathan Cameron , Shiju Jose , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Philippe =?UTF-8?B?TWF0aGll?= =?UTF-8?B?dS1EYXVkw6k=?= , Ani Sinha , Cleber Rosa , Dongjiu Geng , Eduardo Habkost , Eric Blake , John Snow , Marcel Apfelbaum , Markus Armbruster , Michael Roth , Paolo Bonzini , Peter Maydell , Shannon Zhao , Yanan Wang , Zhao Liu , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/11] Change ghes to use HEST-based offsets and add support for error inject Message-ID: <20250124134718.3e228b0b@imammedo.users.ipa.redhat.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 22 Jan 2025 16:46:17 +0100 Mauro Carvalho Chehab wrote: > Now that the ghes preparation patches were merged, let's add support > for error injection. > > I'm opting to fold two patch series into one here: > > 1. https://lore.kernel.org/qemu-devel/20250113130854.848688-1-mchehab+huawei@kernel.org/ > > It is the first 5 patches containing changes to the math used to calculate offsets at HEST > table and hardware_error firmware file, together with its migration code. Migration tested > with both latest QEMU released kernel and upstream, on both directions. > > There were no changes on this series since last submission, except for a conflict > resolution at the migration table, due to upstream changes. > > For more details, se the post of my previous submission. > > 2. It follows 6 patches from: > https://lore.kernel.org/qemu-devel/cover.1726293808.git.mchehab+huawei@kernel.org/ > containing the error injection code and script. > > They add a new QAPI to allow injecting GHESv2 errors, and a script using such QAPI > to inject ARM Processor Error records. > > PS.: If I'm counting well, this is the 18th version of this series rebase. the series is more or less in good shape, it requires a few fixups here and there, so I'd expect to to be ready on the next respin. I'm done with this round of review. PS: the moment you'd start changing ACPI tables you need, 1st whitelist affected tables and then update expected blobs with new content. see comment at the beginning of tests/qtest/bios-tables-test.c if you haven't done above 'make check-qtest' would fail, and if it didn't that likely means a missing test case (in that case please add one) > > Mauro Carvalho Chehab (11): > acpi/ghes: Prepare to support multiple sources on ghes > acpi/ghes: add a firmware file with HEST address > acpi/ghes: Use HEST table offsets when preparing GHES records > acpi/generic_event_device: Update GHES migration to cover hest addr > acpi/generic_event_device: add logic to detect if HEST addr is > available > acpi/ghes: add a notifier to notify when error data is ready > acpi/ghes: Cleanup the code which gets ghes ged state > acpi/generic_event_device: add an APEI error device > arm/virt: Wire up a GED error device for ACPI / GHES > qapi/acpi-hest: add an interface to do generic CPER error injection > scripts/ghes_inject: add a script to generate GHES error inject > > MAINTAINERS | 10 + > hw/acpi/Kconfig | 5 + > hw/acpi/aml-build.c | 10 + > hw/acpi/generic_event_device.c | 38 ++ > hw/acpi/ghes-stub.c | 4 +- > hw/acpi/ghes.c | 184 +++++-- > hw/acpi/ghes_cper.c | 32 ++ > hw/acpi/ghes_cper_stub.c | 19 + > hw/acpi/meson.build | 2 + > hw/arm/virt-acpi-build.c | 35 +- > hw/arm/virt.c | 19 +- > hw/core/machine.c | 2 + > include/hw/acpi/acpi_dev_interface.h | 1 + > include/hw/acpi/aml-build.h | 2 + > include/hw/acpi/generic_event_device.h | 1 + > include/hw/acpi/ghes.h | 36 +- > include/hw/arm/virt.h | 2 + > qapi/acpi-hest.json | 35 ++ > qapi/meson.build | 1 + > qapi/qapi-schema.json | 1 + > scripts/arm_processor_error.py | 377 +++++++++++++ > scripts/ghes_inject.py | 51 ++ > scripts/qmp_helper.py | 702 +++++++++++++++++++++++++ > target/arm/kvm.c | 2 +- > 24 files changed, 1517 insertions(+), 54 deletions(-) > create mode 100644 hw/acpi/ghes_cper.c > create mode 100644 hw/acpi/ghes_cper_stub.c > create mode 100644 qapi/acpi-hest.json > create mode 100644 scripts/arm_processor_error.py > create mode 100755 scripts/ghes_inject.py > create mode 100644 scripts/qmp_helper.py >