From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D085B224CC for ; Fri, 24 Jan 2025 22:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737756987; cv=none; b=Yf9M4SaLSktTFLunK3sTsAzAfXSnnHdTo84/nzrbFEuyROB6QglXiTUAxj39sGdvj4jOg/mOilaHXo3ODIFkx2kBs88q/Cd/JRuAE/EN5qD3yGpDKv25CpPG9+FRAXdtbj9tvgxcyNHMyyfsv/9xU9dZCKwlLaw94RCpcnVJ7OM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737756987; c=relaxed/simple; bh=3p8ak8c8yLzvaOsv0kCP4DBoh4FXKw5429NnzGBFgq8=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FiAtgmhQvkBUroc+PcutaMIHAzdx6RDB9L8Saf2xzgZQ37RXXd5FORcdFPSkj0VT9siPAsa7cvCpI/5p2l9z46cKOxnID05sOV2nYv07+uOORI/BPawhUlf6RAeoOkkjjf51JSo3Mkr5w+Z71qwDZT3EEz5GXrfZbXnoWATc5dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=BuI5hy73; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="BuI5hy73" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 50OMG4qM618990 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2025 16:16:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1737756964; bh=y530Fx9hFlNLGK6ZuwhkcmBLAGwUtuHYtXQQswA+O9Q=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=BuI5hy73ZBgczzJDFEoIU+kcjYnm1cEvNGysF0YE0YGaWhIQpIWO0mfKscUBBr2EQ Co19pv5FyqLoaTDBYnM+Bj0/wRXSpREikVJap6BR3/4U7W/8p82THVW+AK/jfY/vEB IM2j83HYfS72G4Ii1rdxN/1Kr4XwPfBWH4VATwxE= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 50OMG49r087809 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Jan 2025 16:16:04 -0600 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 24 Jan 2025 16:16:04 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 24 Jan 2025 16:16:04 -0600 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 50OMG4YR130838; Fri, 24 Jan 2025 16:16:04 -0600 Date: Fri, 24 Jan 2025 16:16:04 -0600 From: Nishanth Menon To: Greg Kroah-Hartman CC: Andrew Davis , Peter Rosin , Vignesh Raghavendra , , "Rob Herring (Arm)" , Lee Jones Subject: Re: [PATCH] mux: mmio: Do not use syscon helper to build regmap Message-ID: <20250124221604.dgzm72fstf625cik@dismount> References: <20250123182059.597491-1-afd@ti.com> <20250123200412.6zuhlbz4zorazdhq@deport> <2025012446-unturned-frugality-7a20@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2025012446-unturned-frugality-7a20@gregkh> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 06:26-20250124, Greg Kroah-Hartman wrote: > On Thu, Jan 23, 2025 at 02:04:12PM -0600, Nishanth Menon wrote: > > On 12:20-20250123, Andrew Davis wrote: > > > The syscon helper device_node_to_regmap() is used to fetch a regmap > > > registered to a device node. It also currently creates this regmap > > > if the node did not already have a regmap associated with it. This > > > should only be used on "syscon" nodes. This driver is not such a > > > device and instead uses device_node_to_regmap() on its own node as > > > a hacky way to create a regmap for itself. > > > > > > This will not work going forward and so we should create our regmap > > > the normal way by defining our regmap_config, fetching our memory > > > resource, then using the normal regmap_init_mmio() function. > > > > > > Signed-off-by: Andrew Davis > > > --- > > Tested-by: Nishanth Menon > > > > Greg, Peter, > > > > This is part of the fixes TI K3 platforms boot issues reported in > > https://lore.kernel.org/all/b2413460-ec8b-4c77-99b8-4c32b262439a@ti.com/ > > on the latest linus master v6.13-5001-gd0d106a2bd21 + linux > > next-20250123 > > > > Total set of patches tested with: > > https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/ > > https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com > > https://lore.kernel.org/r/20250123181913.597304-1-afd@ti.com > > https://lore.kernel.org/r/20250123182059.597491-1-afd@ti.com > > https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com > > > > Could we get this routed to master as fixes asap please to get a sane 6.14? > > Our trees are of course closed right now due to the merge window, you > know that :) > > So we can take things after -rc1 is out, and route bugfixes for > 6.14-final and new stuff for 6.15-rc1, like always. It's hard to see > that this is just a bugfix, but if it is, it needs a Fixes: tag at the > very least, right? Just following up after a bit of discussion on IRC.. (Thanks Rob) I think getting this patch in current window is less urgent for given Rob has posted a restoration of behavior[1]. This patch is still good to be merged based on [2], but probably queued as appropriate. [1] https://lore.kernel.org/all/20250124191644.2309790-1-robh@kernel.org/ [2] https://lore.kernel.org/all/CAL_JsqKVydDqmr-gyn1wt=1PO_p1NMze+1D+4qXWxGiGVLV9EA@mail.gmail.com/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D