From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C1E91D5CF2 for ; Fri, 24 Jan 2025 05:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737696380; cv=none; b=Ks9To5olbSceudu9bhhJgqrgU3BG0clyiq007Wgsch2GfiaUoOKRwCYwIqXYrQaUODUGmkRT2+POrSGHD7OXmRlPpotILQg6FTDLDsnYjvll41BSyDxZUXDGUoOLLfac2prLHGaMOstv3PDAC8PZvMuL++toBApGPRRelDJLdVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737696380; c=relaxed/simple; bh=WrIMNwN0/nR1jdQvAlof8BkzWo9LliDoWfuUAFTQyEg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HwKFNWFwXDk2qbmRBKUubMHvVJd2DXJZfF99qhIDIi2HDKNjdNaPf5hKmy4faHhvBWt2x3xqvokGZPX5TP0Cx18dY5nGBoe+PyPUUZaI4rP4hnOOocVZKNDbZkex4Ca6BWieU233LCK+d4g8w42+QiURmkJdUqiKCML4SoOiK6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BMCuHaeN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BMCuHaeN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47F8EC4CED2; Fri, 24 Jan 2025 05:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1737696379; bh=WrIMNwN0/nR1jdQvAlof8BkzWo9LliDoWfuUAFTQyEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BMCuHaeNNlSKGX395OcpBrfkOUNI6mNoQdzSY+2EES0zJaPwn866C96uRWpsFP4F9 2z/I0EOOcgLvJnSu/Of/2ESWlw6u0xOcZsRV3VZpXw2azptY64JbsDFzKaWCofA8Z3 8IX+QvFjOMXWhWUZn4KHsYA05R8mvNBmOQLkERpU= Date: Fri, 24 Jan 2025 06:26:16 +0100 From: Greg Kroah-Hartman To: Nishanth Menon Cc: Andrew Davis , Peter Rosin , Vignesh Raghavendra , linux-kernel@vger.kernel.org, "Rob Herring (Arm)" , Lee Jones Subject: Re: [PATCH] mux: mmio: Do not use syscon helper to build regmap Message-ID: <2025012446-unturned-frugality-7a20@gregkh> References: <20250123182059.597491-1-afd@ti.com> <20250123200412.6zuhlbz4zorazdhq@deport> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250123200412.6zuhlbz4zorazdhq@deport> On Thu, Jan 23, 2025 at 02:04:12PM -0600, Nishanth Menon wrote: > On 12:20-20250123, Andrew Davis wrote: > > The syscon helper device_node_to_regmap() is used to fetch a regmap > > registered to a device node. It also currently creates this regmap > > if the node did not already have a regmap associated with it. This > > should only be used on "syscon" nodes. This driver is not such a > > device and instead uses device_node_to_regmap() on its own node as > > a hacky way to create a regmap for itself. > > > > This will not work going forward and so we should create our regmap > > the normal way by defining our regmap_config, fetching our memory > > resource, then using the normal regmap_init_mmio() function. > > > > Signed-off-by: Andrew Davis > > --- > Tested-by: Nishanth Menon > > Greg, Peter, > > This is part of the fixes TI K3 platforms boot issues reported in > https://lore.kernel.org/all/b2413460-ec8b-4c77-99b8-4c32b262439a@ti.com/ > on the latest linus master v6.13-5001-gd0d106a2bd21 + linux > next-20250123 > > Total set of patches tested with: > https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/ > https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com > https://lore.kernel.org/r/20250123181913.597304-1-afd@ti.com > https://lore.kernel.org/r/20250123182059.597491-1-afd@ti.com > https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com > > Could we get this routed to master as fixes asap please to get a sane 6.14? Our trees are of course closed right now due to the merge window, you know that :) So we can take things after -rc1 is out, and route bugfixes for 6.14-final and new stuff for 6.15-rc1, like always. It's hard to see that this is just a bugfix, but if it is, it needs a Fixes: tag at the very least, right? thanks, greg k-h