From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFB13223323; Sun, 26 Jan 2025 15:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903841; cv=none; b=aWOcerQ9/NxtyowmzlsV3dqFLTlc6Kt74PShON7Z90A/o0DICHDblpL0sQ4pdAWNpk7myHe4pbJoy5OEny6Qkbks7iXlIRYJkHe2X60T+HO9RTVtjAd0LmW44KdpJjypDNL5hPcxr8AN6BgWdvkw4HCFF1P/iRkO0zNbK0xO1/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903841; c=relaxed/simple; bh=xqsFZDXcgWuh8R4sumD99NeBWg3g94r0BYjFARAj7Go=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=TtTqN9M8ReQ51znDptYTkT2Ho8NB4ah7Nbo7v3gRORTtE2DJWcEAkbmP3Bj8Shym3PuMA6s/rpsnlr82ky6cXOkCkKVPaqcVdezP1Uiw/36NSWhdKIXp9Bb3h06vdZwCoWDPh6/3wSnVEHaLeUUuMejRrOetp0+YlEcrsIVuCOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BottHjts; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BottHjts" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7180CC4CEE5; Sun, 26 Jan 2025 15:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737903840; bh=xqsFZDXcgWuh8R4sumD99NeBWg3g94r0BYjFARAj7Go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BottHjts5t+TI6RcZecCtna9S6AVVNxganZPt+2Ck4df/LhxTYPGeFifTloRfKsMm 5L+fBRHGebH2HI+b5pOLXAMt/Y0HfYtDzsAgKdufj8teO3yAxZ2k/+DwnG+2sDHoQf vrZo/h9+XINJigCxkrSAtPhuD167KRYrJ1Vibsbu6vN3Lxn7M1SeiX9sXL3tGGCr4c dV2D8VfZcQF8tJP178NzmW+Dg1Zmg1tpJCnbC9SvmF9LmZPbl4JwwbOsPeREnHnZZd QrzoTsKJGDkZu/ciBtuPUZX13drjfkxIF7WNL4+9YrTHhp8uU/q600xIuDoTaJEex5 UhXj8J0a9s8qQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiri Kosina , =?UTF-8?q?Ulrich=20M=C3=BCller?= , WangYuli , Sasha Levin , jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 03/17] Revert "HID: multitouch: Add support for lenovo Y9000P Touchpad" Date: Sun, 26 Jan 2025 10:03:39 -0500 Message-Id: <20250126150353.957794-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250126150353.957794-1-sashal@kernel.org> References: <20250126150353.957794-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.127 Content-Transfer-Encoding: 8bit From: Jiri Kosina [ Upstream commit 3d88ba86ba6f35a0467f25a88c38aa5639190d04 ] This reverts commit 251efae73bd46b097deec4f9986d926813aed744. Quoting Wang Yuli: "The 27C6:01E0 touchpad doesn't require the workaround and applying it would actually break functionality. The initial report came from a BBS forum, but we suspect the information provided by the forum user may be incorrect which could happen sometimes. [1] Further investigation showed that the Lenovo Y9000P 2024 doesn't even use a Goodix touchpad. [2] For the broader issue of 27c6:01e0 being unusable on some devices, it just need to address it with a libinput quirk. In conclusion, we should revert this commit, which is the best solution." Reported-by: Ulrich Müller Reported-by: WangYuli Link: https://lore.kernel.org/all/uikt4wwpw@gentoo.org/ Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-ids.h | 1 - drivers/hid/hid-multitouch.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 790966e5b6ec4..d8c5e24e7d44c 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -507,7 +507,6 @@ #define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 #define I2C_VENDOR_ID_GOODIX 0x27c6 -#define I2C_DEVICE_ID_GOODIX_01E0 0x01e0 #define I2C_DEVICE_ID_GOODIX_01E8 0x01e8 #define I2C_DEVICE_ID_GOODIX_01E9 0x01e9 #define I2C_DEVICE_ID_GOODIX_01F0 0x01f0 diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index bf9cad7112592..e62104e1a6038 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -1447,8 +1447,7 @@ static __u8 *mt_report_fixup(struct hid_device *hdev, __u8 *rdesc, { if (hdev->vendor == I2C_VENDOR_ID_GOODIX && (hdev->product == I2C_DEVICE_ID_GOODIX_01E8 || - hdev->product == I2C_DEVICE_ID_GOODIX_01E9 || - hdev->product == I2C_DEVICE_ID_GOODIX_01E0)) { + hdev->product == I2C_DEVICE_ID_GOODIX_01E9)) { if (rdesc[607] == 0x15) { rdesc[607] = 0x25; dev_info( @@ -2073,10 +2072,7 @@ static const struct hid_device_id mt_devices[] = { I2C_DEVICE_ID_GOODIX_01E8) }, { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU, HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX, - I2C_DEVICE_ID_GOODIX_01E9) }, - { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU, - HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX, - I2C_DEVICE_ID_GOODIX_01E0) }, + I2C_DEVICE_ID_GOODIX_01E8) }, /* GoodTouch panels */ { .driver_data = MT_CLS_NSMU, -- 2.39.5