From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
Cc: andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, bhelgaas@google.com,
konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: update interconnect cells for ipq5424
Date: Mon, 27 Jan 2025 08:27:06 +0100 [thread overview]
Message-ID: <20250127-amethyst-capybara-from-uranus-5e6bf4@krzk-bin> (raw)
In-Reply-To: <20250125035920.2651972-3-quic_mmanikan@quicinc.com>
On Sat, Jan 25, 2025 at 09:29:18AM +0530, Manikanta Mylavarapu wrote:
> Interconnect cells differ between the IPQ5332 and IPQ5424.
> Therefore, update the interconnect cells according to the SoC.
Why do they differ? Why they cannot be the same?
>
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
> .../devicetree/bindings/clock/qcom,ipq5332-gcc.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml
> index 1230183fc0a9..fac7922d2473 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml
> @@ -35,8 +35,6 @@ properties:
> - description: PCIE 2-lane PHY3 pipe clock source
>
> '#power-domain-cells': false
> - '#interconnect-cells':
> - const: 1
Properties are always defined top-level or in other schema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-27 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 3:59 [PATCH v3 0/4] Add PCIe support for IPQ5424 Manikanta Mylavarapu
2025-01-25 3:59 ` [PATCH v3 1/4] dt-bindings: PCI: qcom: add global interrupt for ipq5424 Manikanta Mylavarapu
2025-01-27 7:25 ` Krzysztof Kozlowski
2025-01-28 7:00 ` Manikanta Mylavarapu
2025-01-28 7:30 ` Krzysztof Kozlowski
2025-01-25 3:59 ` [PATCH v3 2/4] dt-bindings: clock: update interconnect cells " Manikanta Mylavarapu
2025-01-27 7:27 ` Krzysztof Kozlowski [this message]
2025-01-28 7:12 ` Manikanta Mylavarapu
2025-01-28 11:26 ` Konrad Dybcio
2025-01-30 6:56 ` Manikanta Mylavarapu
2025-01-25 3:59 ` [PATCH v3 3/4] arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller nodes Manikanta Mylavarapu
2025-01-28 11:38 ` Konrad Dybcio
2025-01-30 6:57 ` Manikanta Mylavarapu
2025-01-25 3:59 ` [PATCH v3 4/4] arm64: dts: qcom: ipq5424: Enable PCIe PHYs and controllers Manikanta Mylavarapu
2025-01-28 11:39 ` Konrad Dybcio
2025-01-29 10:11 ` Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127-amethyst-capybara-from-uranus-5e6bf4@krzk-bin \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®