From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57DF618FDBD for ; Mon, 27 Jan 2025 21:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738014412; cv=none; b=npnAXh5vvgvye5kmpp80d/Mt0FXuCZPeWnkmK3r3Sw76L8R2BDhg7uifJuTa/zKSFOlVGZKWXrj5Lz+1dubsEqvZic+6OJ+m0qx5mqGBP2LbKYYjMHbb23e08e+EfvFqSvkRkXRNgNHbhECoGrjyXNmYR//wo+ONVMQSU4wCLlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738014412; c=relaxed/simple; bh=eNnCmR3lXEfMc8BbmsJiVcn/h+s5YikaCgx0A1qAVlc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=OWUW3E55PiAZY18hkK1ixecs4pLfagY7xqlampA5tkj8MxJI37VuWkFqy04CILczbLeUT2vZfyfh9qC93Vb9CeyC+IlZsxa05cZSI+JaWpB1oQgOsQPmf1P7ZF/Nih0MtPGHiWWlDVUBLGX472mDLhNAAl7Oht2/B/pYS3GRFkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=T19kDRec; arc=none smtp.client-ip=209.85.208.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T19kDRec" Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-5d3f01eeef8so4123204a12.0 for ; Mon, 27 Jan 2025 13:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738014408; x=1738619208; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sg18kjAFZeqr6iErPKWsTCmY69Yia/6QwhH3blqcAPY=; b=T19kDRecKUPRIWn/W2QHL88V/SjjgqFspRHGw1sOUiBCmNIHmZLHB3cpRNSXhP5asa WNjAu9HlmZJOYO+9vm9TeubU3qtojs6dS3mqFf5nNflx6m5N7GslZgCc2++bsPiCE/78 1VYqCodA9yqaxB5WAc2dow2nmFQut2IZZRUK0UOswKtrCoN3xUcq1MLQ8sfG+cPkTj/v A1FFYTHSfJ3d7tA9tFXvlE+eD3JtrLSPGVO4yB0m9mgL8p+JIUNg0If3tWLvEH2FgbHw 29XGf6MtfN4sHXzhfVRX8okM9BA+VW1cXgeABDvUOr8Hfqy7G2B1kOZSesgndr9rhnS0 jWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738014408; x=1738619208; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sg18kjAFZeqr6iErPKWsTCmY69Yia/6QwhH3blqcAPY=; b=Q5zIwm/ZmRpCk7Y6BlLn/r7ahJa7Vo0hrOIyH6UrdW27w4kziWPl8DEuiFXWg/DRud MdmC3DQTUb3Y5CtkfKXADP31sLKjxp0swW23xH6q/+zRLXibYVeNA9HZgWaKuKZ2hP27 7Bhy3vSPbN6QOgB61qNA0VlUyzIU2cTG4qKwaFYgUYvvwLLS2cpvDPWhrzD8UUhacuz6 Rz9F1IIdc5i3TZlcAoTgJo22kX/S2b8sxvcIV7YKPyzBEGI86xHl4IJwlIkcExuVnU0v Cvp2OuRfTnODx57mc2Wvfid2XOdX4aXzx1oVQNwnPb3/SQz4XTfmRdbHViDPJG5XeY3n w84A== X-Forwarded-Encrypted: i=1; AJvYcCXlgUwaMrHAZ3lq0KCG+BIv+X/GJFTtNxVv3FaSyU2N0bFAFSWvu2Mly6yWwIZyx/x8DQwQ87y0Fp3OY9A=@vger.kernel.org X-Gm-Message-State: AOJu0YwUOvrToXqoatpf70WjsNBfVIa5wh98ytYkew4GgkUOmUwL/1Ou UrO5D8P+McFoq4GkY7+kpu8W7C6EGY3VApSPKengnpAVeqOKpO+syOoAcVfi95e4qqJDxqvMfk8 vNETETewRkTDxMUYNJw== X-Google-Smtp-Source: AGHT+IGaiRZr4EJB8fg1nV9+CzFnJep+BrzNkzXZQp0+QI20M+WZbOx8WndefkOa65xga+7THi3tCjTck34BBOyH X-Received: from ejeh21.prod.google.com ([2002:a17:906:3995:b0:ab6:945a:f185]) (user=mclapinski job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:1e8e:b0:5dc:1059:6b2 with SMTP id 4fb4d7f45d1cf-5dc105a5ec1mr41424107a12.7.1738014408681; Mon, 27 Jan 2025 13:46:48 -0800 (PST) Date: Mon, 27 Jan 2025 22:46:26 +0100 In-Reply-To: <20250127214627.4021412-1-mclapinski@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250127214627.4021412-1-mclapinski@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Message-ID: <20250127214627.4021412-2-mclapinski@google.com> Subject: [PATCH v2 1/2] mm/compaction: remove low watermark cap for proactive compaction From: Michal Clapinski To: Andrew Morton , Vlastimil Babka , Pasha Tatashin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Clapinski Content-Type: text/plain; charset="UTF-8" Previously a min cap of 5 has been set in the commit introducing proactive compaction. This was to make sure users don't hurt themselves by setting the proactiveness to 100 and making their system unresponsive. But the compaction mechanism has a backoff mechanism that will sleep for 30s if no progress is made, so I don't see a significant risk here. My system (20GB of memory) has been perfectly fine with proactiveness set to 100 and leeway set to 0. Signed-off-by: Michal Clapinski Change-Id: I007e3a02d126d3858ceecf5ce57a1c360177c37b --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index a2b16b08cbbff..29524242a16ef 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2253,7 +2253,7 @@ static unsigned int fragmentation_score_wmark(bool low) * activity in case a user sets the proactiveness tunable * close to 100 (maximum). */ - wmark_low = max(100U - sysctl_compaction_proactiveness, 5U); + wmark_low = 100U - sysctl_compaction_proactiveness; return low ? wmark_low : min(wmark_low + 10, 100U); } -- 2.48.1.262.g85cc9f2d1e-goog