From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400CB156669 for ; Tue, 28 Jan 2025 10:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738059183; cv=none; b=qV2K6F52SdnvdLTWrPJnSTp2e51ORnsl3xC/E2RQh0CUgQ8an1kDrXmZRI8w7C8i/cIcrklt10Rs8P149mDQs4qC2jSPUBDraJidGwMPcPWrqnlFddLywQ1JJ4HxxlcXkzNXGy1mVL1m2jjItvAdOgj0er9nW1KDY9qnAeH0BmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738059183; c=relaxed/simple; bh=q2tkXJnQuqRVsRPzbW4+BGtAR/MbKeqkStZKGVjjDhg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VsyDHKEL0kFiig2f6rbD4zM/znWmzGxtP1jdMi2ErECz0+WCXtBwBx1wOinb2I8nRmMtQesM4KYbjQvZZde3uH9XcF97P/6ELntnHHvFJC2/CXJ1ZkzTeVV3M9wPK39IDZxPi7Fni43a+YGJFzvcGMVtWeONbo2d9HvwKq1MEg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FZx6s1eU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FZx6s1eU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B47AC4CED3; Tue, 28 Jan 2025 10:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738059182; bh=q2tkXJnQuqRVsRPzbW4+BGtAR/MbKeqkStZKGVjjDhg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FZx6s1eUpPWZoplYHOrkhr/qzvpXtRJHTMEvibGRaE0I35+GfokYOCsT0x2PD4EmP 6GBEGzM3UWML6T60t+x/hivCNb0dFQ5v1D+Bjgw5H4usRPF+0/9LtwFD7apwSeyWhR tYcw0RY9HcHBS3JMeoboiyQuKa5nY2fNhEJCkjZhG0iAzlCxKbenZsC5Ael8dsyU/8 clAz7s7/zjU24aKkQpAe/dWFIpN1ygJ/CI63+ENnBPcsMIL+H4OI3emXrWdDTJbyV3 DNlf4WiH9vldzYWOvk4KVeHuwyrqURR3owwGhRbNjiumftrCI1zsV10PyyB+onqfdE 6mTNCTFsgZqQw== Date: Tue, 28 Jan 2025 11:12:57 +0100 From: Mauro Carvalho Chehab To: Igor Mammedov Cc: Jonathan Cameron , "Michael S . Tsirkin" , Shiju Jose , , , Ani Sinha , Dongjiu Geng , Subject: Re: [PATCH 02/11] acpi/ghes: add a firmware file with HEST address Message-ID: <20250128111257.74766c82@foz.lan> In-Reply-To: <20250123180135.4f86483f@imammedo.users.ipa.redhat.com> References: <20250123100217.00007373@huawei.com> <20250123180135.4f86483f@imammedo.users.ipa.redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Thu, 23 Jan 2025 18:01:35 +0100 Igor Mammedov escreveu: > On Thu, 23 Jan 2025 10:02:17 +0000 > Jonathan Cameron wrote: > > > On Wed, 22 Jan 2025 16:46:19 +0100 > > Mauro Carvalho Chehab wrote: > > > > > Store HEST table address at GPA, placing its content at > > > hest_addr_le variable. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > Reviewed-by: Jonathan Cameron > > > > > A few trivial things inline. > > > > Jonathan > > > > > --- > > > > > > Change from v8: > > > - hest_addr_lr is now pointing to the error source size and data. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > Bonus. I guess you really like this patch :) > > > --- > > > hw/acpi/ghes.c | 17 ++++++++++++++++- > > > include/hw/acpi/ghes.h | 1 + > > > 2 files changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > > > index 3f519ccab90d..34e3364d3fd8 100644 > > > --- a/hw/acpi/ghes.c > > > +++ b/hw/acpi/ghes.c > > > @@ -30,6 +30,7 @@ > > > > > > #define ACPI_HW_ERROR_FW_CFG_FILE "etc/hardware_errors" > > > #define ACPI_HW_ERROR_ADDR_FW_CFG_FILE "etc/hardware_errors_addr" > > > +#define ACPI_HEST_ADDR_FW_CFG_FILE "etc/acpi_table_hest_addr" > > > > > > /* The max size in bytes for one error block */ > > > #define ACPI_GHES_MAX_RAW_DATA_LENGTH (1 * KiB) > > > @@ -261,7 +262,7 @@ static void build_ghes_error_table(GArray *hardware_errors, BIOSLinker *linker, > > > } > > > > > > /* > > > - * tell firmware to write hardware_errors GPA into > > > + * Tell firmware to write hardware_errors GPA into > > > > Sneaky tidy up. No problem with it in general but adding noise here, so if there > > are others in the series maybe gather them up in a cleanup patch. > > +1 If Ok, I would prefer to keep this here, as there's no other cleanups anymore, and writing a patch just for this seems overkill. Besides, it replicates a comment with a similar content on this patch. So, instead, if OK to you, I would prefer to add a comment about it at the patch description. > > > > > * hardware_errors_addr fw_cfg, once the former has been initialized. > > > */ > > > bios_linker_loader_write_pointer(linker, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, 0, > > > @@ -355,6 +356,8 @@ void acpi_build_hest(GArray *table_data, GArray *hardware_errors, > > > > > > acpi_table_begin(&table, table_data); > > > > > > + int hest_offset = table_data->len; > should be unsigned, and better uint32_t > but we have a zoo wrt type here all over the place. Changed this one to uint32_t. > > Local style looks to be traditional C with definitions at top. Maybe define > > hest_offset up a few lines and just set it here? > > yep, it applies to whole QEMU (i.e. definitions only at the start of the block) Good to know. That's my personal style too. Yet, I guess I saw somewhere other places declaring variables in the middle of the code. > > > + > > > /* Error Source Count */ > > > build_append_int_noprefix(table_data, num_sources, 4); > > > for (i = 0; i < num_sources; i++) { > > > @@ -362,6 +365,15 @@ void acpi_build_hest(GArray *table_data, GArray *hardware_errors, > > > } > > > > > > acpi_table_end(linker, &table); > > > + > > > + /* > > > + * tell firmware to write into GPA the address of HEST via fw_cfg, > > > > Given the tidy up above, fix this one to have a capital T, or was this > > where you meant to change it? > > > > > + * once initialized. > > > + */ > > > + bios_linker_loader_write_pointer(linker, > > > + ACPI_HEST_ADDR_FW_CFG_FILE, 0, > > > > Could wrap less and stay under 80 chars as both lines above add up to 70 something > > > > > + sizeof(uint64_t), > > > + ACPI_BUILD_TABLE_FILE, hest_offset); > > > } > > > Thanks, Mauro