mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Isaac Scott <isaac.scott@ideasonboard.com>
To: michael.hennerich@analog.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
	linux-kernel@vger.kernel.org,
	Isaac Scott <isaac.scott@ideasonboard.com>
Subject: [PATCH v2 3/3] regulator: ad5398: Add device tree support
Date: Tue, 28 Jan 2025 17:31:43 +0000	[thread overview]
Message-ID: <20250128173143.959600-4-isaac.scott@ideasonboard.com> (raw)
In-Reply-To: <20250128173143.959600-1-isaac.scott@ideasonboard.com>

Previously, the ad5398 driver used only platform_data, which is
deprecated in favour of device tree. This caused the AD5398 to fail to
probe as it could not load its init_data. If the AD5398 has a device
tree node, pull the init_data from there using
of_get_regulator_init_data.

Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com>
---
 drivers/regulator/ad5398.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index 0c60ecd1f0f2..619c999946f3 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -14,6 +14,7 @@
 #include <linux/platform_device.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
+#include <linux/regulator/of_regulator.h>
 
 #define AD5398_SW_POWER_DOWN	BIT(16)
 
@@ -220,15 +221,20 @@ static int ad5398_probe(struct i2c_client *client)
 	const struct ad5398_current_data_format *df =
 			(struct ad5398_current_data_format *)id->driver_data;
 
-	if (!init_data)
-		return -EINVAL;
-
 	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
 	if (!chip)
 		return -ENOMEM;
 
 	config.dev = &client->dev;
+	if (client->dev.of_node)
+		init_data = of_get_regulator_init_data(&client->dev,
+						       client->dev.of_node,
+						       &ad5398_reg);
+	if (!init_data)
+		return -EINVAL;
+
 	config.init_data = init_data;
+	config.of_node = client->dev.of_node;
 	config.driver_data = chip;
 
 	chip->client = client;
-- 
2.43.0


  parent reply	other threads:[~2025-01-28 17:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-28 17:31 [PATCH v2 0/3] regulator: Add device tree support to AD5398 Isaac Scott
2025-01-28 17:31 ` [PATCH v2 1/3] regulator: ad5398: change enable bit name to improve readibility Isaac Scott
2025-01-29  8:31   ` Hennerich, Michael
2025-02-05 18:45   ` Guenter Roeck
2025-02-06  9:59     ` Isaac Scott
2025-02-06 11:30       ` Mark Brown
2025-01-28 17:31 ` [PATCH v2 2/3] RFC: regulator: ad5398: Change selector division calculation Isaac Scott
2025-01-29  8:34   ` Hennerich, Michael
2025-01-29 18:21     ` Isaac Scott
2025-02-06 13:38     ` Isaac Scott
2025-01-28 17:31 ` Isaac Scott [this message]
2025-01-29  8:32   ` [PATCH v2 3/3] regulator: ad5398: Add device tree support Hennerich, Michael
2025-02-03 19:57 ` (subset) [PATCH v2 0/3] regulator: Add device tree support to AD5398 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250128173143.959600-4-isaac.scott@ideasonboard.com \
    --to=isaac.scott@ideasonboard.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®