From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFCC367 for ; Wed, 29 Jan 2025 00:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738108990; cv=none; b=WDOp0m9hBE4nE+Ypk89Nx6n+BmfKF660WBYbvGTvdbMRu5j/qVsStCMF73PrzLQ+Lwl5fZ1ggNObmkEEpaI42im1QaR7q1gxEkbWeg8wEkiK65pmTnHqE/3wvu6h/MxqVR2ZvGHT8W3G2i3ons4ncpYoEIDpcCtAEWLierskqqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738108990; c=relaxed/simple; bh=cRD8awdVUvXJAbojDPKCR91Gs+p/lQ6C0avjBYQFF1o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ql8SZzSAnflfOIt5ZQbbfZet3BlF3Gld3lSK4Qgb8lVX+9qABGh2Ir51GYTrYDH9qeJO5MnCeaMpu3RbWzuj7FZ6lUnjuAulSPoTQwKB6EYX0og4XG6DVLRiu0++q/i5vgRztFCZtp2iVqVRdK5wnTCJwbKcabYClxUBBG7diuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7F2EC4CED3; Wed, 29 Jan 2025 00:03:07 +0000 (UTC) Date: Tue, 28 Jan 2025 19:03:28 -0500 From: Steven Rostedt To: Suren Baghdasaryan Cc: Vlastimil Babka , akpm@linux-foundation.org, Peter Zijlstra , kent.overstreet@linux.dev, yuzhao@google.com, minchan@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] alloc_tag: uninline code gated by mem_alloc_profiling_key in slab allocator Message-ID: <20250128190328.03a177d2@gandalf.local.home> In-Reply-To: References: <20250126070206.381302-1-surenb@google.com> <20250126070206.381302-2-surenb@google.com> <20250128143549.62f458a7@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Jan 2025 15:43:13 -0800 Suren Baghdasaryan wrote: > > How slow is it to always do the call instead of inlining? > > Let's see... The additional overhead if we always call is: > > Little core: 2.42% > Middle core: 1.23% > Big core: 0.66% > > Not a huge deal because the overhead of memory profiling when enabled > is much higher. So, maybe for simplicity I should indeed always call? That's what I was thinking, unless the other maintainers are OK with this special logic. -- Steve