From: "Adrián Larumbe" <adrian.larumbe@collabora.com>
To: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jonathan Corbet <corbet@lwn.net>,
Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>
Cc: kernel@collabora.com, "Tvrtko Ursulin" <tursulin@ursulin.net>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Adrián Larumbe" <adrian.larumbe@collabora.com>
Subject: [PATCH v10 0/5] drm/panthor: Display size of internal kernel BOs through fdinfo
Date: Thu, 30 Jan 2025 17:28:08 +0000 [thread overview]
Message-ID: <20250130172851.941597-1-adrian.larumbe@collabora.com> (raw)
This patch series enables display of the size of driver-owned shmem BO's that aren't
exposed to userspace through a DRM handle. Also fixes a use-after-free bug in the
existing fdinfo implementation for Panthor.
Discussion of previous revision can be found here [1].
Changelog:
v10:
- Simplified locking scheme in panthor_vm_heaps_sizes
- Fixed kernel test robot warning about documentation
- Added some R-b tags to patches
v9:
- Added proper locking around group pool xarray to prevent UAF errors.
- Added proper locking around vms pool xarray loop for the same reason
- Added new patch that fixes UAF error because no locking when accessing
fdinfo group stats.
- Some minor cosmetic and naming changes.
v8:
- Made print_size public and added prefix argument for drm_print_memory_stats
- Updated documentation commit to reflect new name tags
- Some minor polishing
v7:
- Added new commit: mentions the formation rules for driver-specific fdinfo keys
- Added new commit: adds a helper that lets driver print memory size key:value
pairs with their driver name as a prefix.
- Modified later commits to make use of the previous ones.
- Deleted mentions of now unnecessary memory keys in the old revision.
v6:
- Replace up_write witnh up_read, which was left out in the previous version
- Fixed some minor comment and documentation issues reported by the kernel test robot
v5:
- Replaced down_write semaphore with the read flavour
- Fixed typo and added explicit description for drm-shared-internal in
the fdinfo documentation file for Panthor.
v4:
- Remove unrelated formating fix
- Moved calculating overall size of a group's kernel BO's into
its own static helper.
- Renamed group kernel BO's size aggregation function to better
reflect its actual responsibility.
[1] https://lore.kernel.org/dri-devel/20250123225325.3271764-1-adrian.larumbe@collabora.com/
Adrián Larumbe (5):
Documentation/gpu: Clarify format of driver-specific fidnfo keys
drm/file: Add fdinfo helper for printing regions with prefix
drm/panthor: Expose size of driver internal BO's over fdinfo
Documentation/gpu: Add fdinfo meanings of panthor-*-memory tags
drm/panthor: Fix race condition when gathering fdinfo group samples
Documentation/gpu/drm-usage-stats.rst | 5 ++-
Documentation/gpu/panthor.rst | 10 +++++
drivers/gpu/drm/drm_file.c | 27 ++++++++----
drivers/gpu/drm/panthor/panthor_drv.c | 14 ++++++
drivers/gpu/drm/panthor/panthor_heap.c | 26 +++++++++++
drivers/gpu/drm/panthor/panthor_heap.h | 2 +
drivers/gpu/drm/panthor/panthor_mmu.c | 33 ++++++++++++++
drivers/gpu/drm/panthor/panthor_mmu.h | 3 ++
drivers/gpu/drm/panthor/panthor_sched.c | 58 ++++++++++++++++++++++++-
drivers/gpu/drm/panthor/panthor_sched.h | 3 ++
include/drm/drm_file.h | 5 +++
11 files changed, 176 insertions(+), 10 deletions(-)
--
2.47.1
next reply other threads:[~2025-01-30 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:28 Adrián Larumbe [this message]
2025-01-30 17:28 ` [PATCH v10 1/5] Documentation/gpu: Clarify format of driver-specific fidnfo keys Adrián Larumbe
2025-01-30 17:28 ` [PATCH v10 2/5] drm/file: Add fdinfo helper for printing regions with prefix Adrián Larumbe
2025-01-30 17:28 ` [PATCH v10 3/5] drm/panthor: Expose size of driver internal BO's over fdinfo Adrián Larumbe
2025-01-30 17:28 ` [PATCH v10 4/5] Documentation/gpu: Add fdinfo meanings of panthor-*-memory tags Adrián Larumbe
2025-01-30 17:28 ` [PATCH v10 5/5] drm/panthor: Fix race condition when gathering fdinfo group samples Adrián Larumbe
2025-02-07 16:29 ` [PATCH v10 0/5] drm/panthor: Display size of internal kernel BOs through fdinfo Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130172851.941597-1-adrian.larumbe@collabora.com \
--to=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tursulin@ursulin.net \
--cc=tvrtko.ursulin@igalia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®