mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Guillaume Ranquet <granquet@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nuno Sa <nuno.sa@analog.com>
Subject: Re: [PATCH v5 2/2] iio: adc: ad7173: add openwire detection support for single conversions
Date: Sat, 1 Feb 2025 12:38:15 +0000	[thread overview]
Message-ID: <20250201123815.3a48a6a0@jic23-huawei> (raw)
In-Reply-To: <20250127-ad4111_openwire-v5-2-ef2db05c384f@baylibre.com>

On Mon, 27 Jan 2025 14:59:33 +0100
Guillaume Ranquet <granquet@baylibre.com> wrote:

> Some chips of the ad7173 family supports open wire detection.
> 
> Generate a level fault event whenever an external source is disconnected
> from the system input on single conversions.
> 
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> ---

>  
> +/*
> + * Associative array of channel pairs for open wire detection
> + * The array is indexed by ain and gives the associated channel pair
> + * to perform the open wire detection with
> + * the channel pair [0] is for non differential and pair [1]
> + * is for differential inputs
> + */
> +static int openwire_ain_to_channel_pair[][2][2] = {
> +/*	AIN     Single    Differential */
> +	[0] = { {0, 15},  {1, 2}   },
> +	[1] = { {1, 2},   {2, 1}   },
> +	[2] = { {3, 4},   {5, 6}   },
> +	[3] = { {5, 6},   {6, 5}   },
> +	[4] = { {7, 8},   {9, 10}  },
> +	[5] = { {9, 10},  {10, 9}  },
> +	[6] = { {11, 12}, {13, 14} },
> +	[7] = { {13, 14}, {14, 13} },
Given I've been poking others this morning to add spaces after { and before }
(arbitrary choice but for IIO at least I'd prefer consistency!)
I've added those whilst applying.


Series applied to the togreg branch of iio.git.
I'll be rebasing that on rc1 once available, so for now just pushed out as
testing.

thanks,

Jonathan

  reply	other threads:[~2025-02-01 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 13:59 [PATCH v5 0/2] iio: adc: ad7173: add ad4111 openwire detection support Guillaume Ranquet
2025-01-27 13:59 ` [PATCH v5 1/2] iio: introduce the FAULT event type Guillaume Ranquet
2025-01-27 13:59 ` [PATCH v5 2/2] iio: adc: ad7173: add openwire detection support for single conversions Guillaume Ranquet
2025-02-01 12:38   ` Jonathan Cameron [this message]
2025-01-27 15:24 ` [PATCH v5 0/2] iio: adc: ad7173: add ad4111 openwire detection support David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250201123815.3a48a6a0@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=granquet@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®