From: Mohammad Rahimi <rahimi.mhmmd@gmail.com>
To: mika.westerberg@linux.intel.com
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mohammad Rahimi <rahimi.mhmmd@gmail.com>
Subject: [PATCH] thunderbolt: Remove the TBT3 Not Supported bit
Date: Mon, 3 Feb 2025 01:17:47 +0000 [thread overview]
Message-ID: <20250203011842.13305-1-rahimi.mhmmd@gmail.com> (raw)
Since USB4 v2 specification has removed the mandatory requirement to
support TBT3 on a USB4 Dock UFP, the TBT3 Not Supported bit is not
usable, as when it needs to be read there is no USB4 Link.
This change was introduced in a "USB4 2.0 ENGINEERING CHANGE NOTICE
FORM" published in September 2024, titled "TBT3 Support on USB4 Dock
UFP".
Signed-off-by: Mohammad Rahimi <rahimi.mhmmd@gmail.com>
---
drivers/thunderbolt/tb_regs.h | 1 -
drivers/thunderbolt/usb4.c | 7 ++-----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
index 4e43b47f9f11..7c5d27571b66 100644
--- a/drivers/thunderbolt/tb_regs.h
+++ b/drivers/thunderbolt/tb_regs.h
@@ -212,7 +212,6 @@ struct tb_regs_switch_header {
#define ROUTER_CS_5_CV BIT(31)
#define ROUTER_CS_6 0x06
#define ROUTER_CS_6_SLPR BIT(0)
-#define ROUTER_CS_6_TNS BIT(1)
#define ROUTER_CS_6_WOPS BIT(2)
#define ROUTER_CS_6_WOUS BIT(3)
#define ROUTER_CS_6_HCI BIT(18)
diff --git a/drivers/thunderbolt/usb4.c b/drivers/thunderbolt/usb4.c
index e51d01671d8e..e25a594649b2 100644
--- a/drivers/thunderbolt/usb4.c
+++ b/drivers/thunderbolt/usb4.c
@@ -241,8 +241,8 @@ int usb4_switch_setup(struct tb_switch *sw)
{
struct tb_switch *parent = tb_switch_parent(sw);
struct tb_port *down;
- bool tbt3, xhci;
u32 val = 0;
+ bool xhci;
int ret;
if (!tb_route(sw))
@@ -257,10 +257,7 @@ int usb4_switch_setup(struct tb_switch *sw)
tb_sw_dbg(sw, "link: %s\n", sw->link_usb4 ? "USB4" : "TBT");
xhci = val & ROUTER_CS_6_HCI;
- tbt3 = !(val & ROUTER_CS_6_TNS);
-
- tb_sw_dbg(sw, "TBT3 support: %s, xHCI: %s\n",
- tbt3 ? "yes" : "no", xhci ? "yes" : "no");
+ tb_sw_dbg(sw, "xHCI support: %s\n", xhci ? "yes" : "no");
ret = tb_sw_read(sw, &val, TB_CFG_SWITCH, ROUTER_CS_5, 1);
if (ret)
--
2.45.2
next reply other threads:[~2025-02-03 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 1:17 Mohammad Rahimi [this message]
2025-02-03 8:46 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203011842.13305-1-rahimi.mhmmd@gmail.com \
--to=rahimi.mhmmd@gmail.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®