Re: [PATCH] dt-bindings: mtd: physmap: Ensure all properties are defined

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On Mon, Feb 03, 2025 at 03:30:35PM -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add the missing 'ranges'
> property, and fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/mtd/mtd-physmap.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml
> index 18f6733408b4..1b375dee83b0 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml
> @@ -122,6 +122,8 @@ properties:
>    '#size-cells':
>      const: 1
>  
> +  ranges: true
> +
>    big-endian: true
>    little-endian: true
>  
> @@ -143,8 +145,7 @@ then:
>    required:
>      - syscon
>  
> -# FIXME: A parent bus may define timing properties
> -additionalProperties: true
> +unevaluatedProperties: false

I dunno what that comment has to do with anything? If a parent bus
defined properties, wouldn't they be in the parent bus?

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]