mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shyam Saini <shyamsaini@linux.microsoft.com>
To: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Cc: code@tyhicks.com, linux@rasmusvillemoes.dk, mcgrof@kernel.org,
	frkaya@linux.microsoft.com, vijayb@linux.microsoft.com,
	petr.pavlu@suse.com, linux@weissschuh.net,
	samitolvanen@google.com, da.gomez@samsung.com,
	gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org
Subject: [v1 0/3]  Properly handle module_kboject creation
Date: Mon,  3 Feb 2025 21:22:19 -0800	[thread overview]
Message-ID: <20250204052222.1611510-1-shyamsaini@linux.microsoft.com> (raw)

Hi Everyone,

This patch series fixes handling of module_kboject creation.
A driver expect module_kset list populated with its corresponding
module_kboject to create its /sys/module/<built-in-module>/drivers
directory.

Since,
[1] commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time")
Call to populate module_kset list is deffered to save init time so that
external watchdog doesn't fireup on some boards and Linux can take
responsibility of feeding watchdog before it spuriously resets the
system. However, [1] this fix caused another issue i.e, consumers
of module_kset can't get related module_kboject during driver
initialisation and hence can't create their
/sys/module/<built-in-module>/drivers directory.

Consequently, [1] breaks user-space applications for eg: DPDK, which
expects /sys/module/vfio_pci/drivers/pci:vfio-pci/new_id to be present.

The second issue was reported and the [2] revert of [1] was
proposed. However, [2] the Revert doesn't address original issue
reported in [1].

This patch series addresses both issues reported in [1] and [2].

Changes since initial RFC(Based on Rasmus's suggestions):
Patch 1: Renames locate_module_kobject() to lookup_or_create_module_kobject(),
         to accurately describe its operations.
Patch 2: Moves lookup_or_create_module_kobject() and to_module* macros to
         module.h, so that driver code can use these.
Patch 3: Handles module_kboject creation and population of module_kset list
         to fix [1] and [2] issues.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=96a1a2412acb
[2] https://lore.kernel.org/lkml/20250130225803.321004-1-shyamsaini@linux.microsoft.com/

Thanks,
Shyam

Shyam Saini (3):
  kernel: param: rename locate_module_kobject
  include: move lookup_or_create_module_kobject()/to_module* to module.h
  drivers: base: handle module_kboject creation

 drivers/base/module.c  | 13 +++++--------
 include/linux/module.h | 39 +++++++++++++++++++++++++++++++++++++
 kernel/params.c        | 44 ++----------------------------------------
 3 files changed, 46 insertions(+), 50 deletions(-)

-- 
2.34.1


             reply	other threads:[~2025-02-04  5:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  5:22 Shyam Saini [this message]
2025-02-04  5:22 ` [v1 1/3] kernel: param: rename locate_module_kobject Shyam Saini
2025-02-04  5:22 ` [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h Shyam Saini
2025-02-04  5:27   ` Christoph Hellwig
2025-02-04  9:28   ` Christophe Leroy
2025-02-05  8:43   ` Rasmus Villemoes
2025-02-07  5:43     ` Shyam Saini
2025-02-04  5:22 ` [v1 3/3] drivers: base: handle module_kboject creation Shyam Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204052222.1611510-1-shyamsaini@linux.microsoft.com \
    --to=shyamsaini@linux.microsoft.com \
    --cc=code@tyhicks.com \
    --cc=da.gomez@samsung.com \
    --cc=dakr@kernel.org \
    --cc=frkaya@linux.microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linux@weissschuh.net \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rafael@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=vijayb@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®