From: Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: treapking@chromium.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Pet.Weng@ite.com.tw,
Kenneth.Hung@ite.com.tw, Hermes Wu <Hermes.wu@ite.com.tw>
Subject: [PATCH v3 2/2] drm/bridge: it6505: add audio support to drm_bridge_funcs
Date: Wed, 05 Feb 2025 14:41:04 +0800 [thread overview]
Message-ID: <20250205-add-audio-codec-v3-2-26cfadb2d81f@ite.com.tw> (raw)
In-Reply-To: <20250205-add-audio-codec-v3-0-26cfadb2d81f@ite.com.tw>
From: Hermes Wu <Hermes.wu@ite.com.tw>
For supporting audio form I2S to DP audio data sub stream.
Add hdmi_audio callbacks to drm_bridge_funcs for the HDMI codec
framework.
Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw>
---
drivers/gpu/drm/bridge/ite-it6505.c | 46 +++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4c766854de14093b80949bdb410488f504b24db8..832c4e3ff4ada31367788faed9583da676e36cf8 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3342,6 +3342,46 @@ it6505_bridge_hdmi_tmds_char_rate_valid(const struct drm_bridge *bridge,
return MODE_OK;
}
+static int it6505_bridge_hdmi_audio_startup(struct drm_connector *connector,
+ struct drm_bridge *bridge)
+{
+ struct it6505 *it6505 = bridge_to_it6505(bridge);
+ struct device *dev = it6505->dev;
+
+ if (!it6505->powered || it6505->enable_drv_hold)
+ return -EIO;
+
+ DRM_DEV_DEBUG_DRIVER(dev, "Audio enable");
+ it6505_enable_audio(it6505);
+
+ return 0;
+}
+
+static int it6505_bridge_hdmi_audio_prepare(struct drm_connector *connector,
+ struct drm_bridge *bridge,
+ struct hdmi_codec_daifmt *fmt,
+ struct hdmi_codec_params *hparms)
+{
+ struct it6505 *it6505 = bridge_to_it6505(bridge);
+ int err;
+
+ err = it6505_audio_setup_hw_params(it6505, hparms);
+ if (err < 0)
+ return err;
+
+ return drm_atomic_helper_connector_hdmi_update_audio_infoframe(connector,
+ &hparms->cea);
+}
+
+static void it6505_bridge_hdmi_audio_shutdown(struct drm_connector *connector,
+ struct drm_bridge *bridge)
+{
+ struct it6505 *it6505 = bridge_to_it6505(bridge);
+
+ if (it6505->powered && !it6505->enable_drv_hold)
+ it6505_disable_audio(it6505);
+}
+
static const struct drm_bridge_funcs it6505_bridge_funcs = {
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
@@ -3358,6 +3398,9 @@ static const struct drm_bridge_funcs it6505_bridge_funcs = {
.hdmi_clear_infoframe = it6505_bridge_hdmi_clear_infoframe,
.hdmi_write_infoframe = it6505_bridge_hdmi_write_infoframe,
.hdmi_tmds_char_rate_valid = it6505_bridge_hdmi_tmds_char_rate_valid,
+ .hdmi_audio_startup = it6505_bridge_hdmi_audio_startup,
+ .hdmi_audio_prepare = it6505_bridge_hdmi_audio_prepare,
+ .hdmi_audio_shutdown = it6505_bridge_hdmi_audio_shutdown,
};
static __maybe_unused int it6505_bridge_resume(struct device *dev)
@@ -3746,6 +3789,9 @@ static int it6505_i2c_probe(struct i2c_client *client)
DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_HDMI;
it6505->bridge.vendor = "iTE";
it6505->bridge.product = "IT6505";
+ it6505->bridge.hdmi_audio_dev = dev;
+ it6505->bridge.hdmi_audio_max_i2s_playback_channels = 2;
+ it6505->bridge.hdmi_audio_dai_port = 1;
drm_bridge_add(&it6505->bridge);
return 0;
--
2.34.1
prev parent reply other threads:[~2025-02-05 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 6:41 [PATCH v3 0/2] drm/bridge: it6505: add audio support with DRM HDMI codec framework Hermes Wu via B4 Relay
2025-02-05 6:41 ` [PATCH v3 1/2] drm/bridge: it6505: add support DRM_BRIDGE_OP_HDMI to drm_bridge Hermes Wu via B4 Relay
2025-02-05 14:38 ` Dmitry Baryshkov
2025-02-05 6:41 ` Hermes Wu via B4 Relay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205-add-audio-codec-v3-2-26cfadb2d81f@ite.com.tw \
--to=devnull+hermes.wu.ite.com.tw@kernel.org \
--cc=Hermes.wu@ite.com.tw \
--cc=Kenneth.Hung@ite.com.tw \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Pet.Weng@ite.com.tw \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®