From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5022158525 for ; Wed, 5 Feb 2025 14:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738765773; cv=none; b=i8UDCtN7NL4c4kzy10omVoIBPAMLr59ziN3vIhPY4np7BVyksXbg2nKlLyw63Q/KGkztXI65z+mJmsm7CmmTm2AMz4eRHWnnAgns88w6ppsDQdF9+E9b668d961V2U+CAYotIDpPsSoXEI7qm+adUeA/XOOJGn9LUPR9ZJyHFrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738765773; c=relaxed/simple; bh=eVeaTdpnOirbpMyaydQmbB7gizEyGhZBFyWrLI0D9Wg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fsp9zx8G1aQm9GFueUNfZ6kLknDKPzGHpxHEp8rGe0/AXNV2Gjf1o+TqAkmpILydfaCv6UcvCsLwXnw7+uIT3AMflaGjD0DxpHH8Yyf1JhyKhnVvxGyz6atlQ0//sBMqAIm/xotLVigwQaOmPnmJySEUz88z479C9EXdUeSbFGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qntclzv0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qntclzv0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29396C4CEE2; Wed, 5 Feb 2025 14:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738765773; bh=eVeaTdpnOirbpMyaydQmbB7gizEyGhZBFyWrLI0D9Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qntclzv0y3WGko+YSgK+ZC/ug+5vv+FnO2rAfqFRrTVSJz6ClfXYfVGlXEvPjj+Wu ywkPWwWfXHFbGwlAnURWoJFY+5FFm7L9sbYG2TovDCJLuCfdnRffFGPSsXywPNSmYh tSd08naH68xs3YnePxibSsqawvNGTHl8agiW9SlRVD7vYa01Z7G9kCIpjwZivLwuFx 8i4kfPMBSpwZzRmaeO1Aakyek0Vc8wzBZyMalfrNCwQbhn2LRsTfo5f9fiWSogfqTM ftTlT2PjASsahCF3eppzefqMx7tH4c3JBNGvNDHhRz4+rMm9Kbksd7Oj2lakc397nS 4EYVemdO6zX2w== Date: Wed, 5 Feb 2025 15:29:31 +0100 From: Maxime Ripard To: Dmitry Baryshkov Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/10] drm/bridge: allow limiting I2S formats Message-ID: <20250205-eager-laughing-nightingale-de5cab@houat> References: <20250126-drm-hdmi-connector-cec-v3-0-5b5b2d4956da@linaro.org> <20250126-drm-hdmi-connector-cec-v3-9-5b5b2d4956da@linaro.org> <7nawswhaddasa4a2sytwspq62s4a2di3ukemfqsc3ueh2lftzl@kjq42eoq3ram> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="zl6wjwxauob5as6t" Content-Disposition: inline In-Reply-To: <7nawswhaddasa4a2sytwspq62s4a2di3ukemfqsc3ueh2lftzl@kjq42eoq3ram> --zl6wjwxauob5as6t Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 09/10] drm/bridge: allow limiting I2S formats MIME-Version: 1.0 On Wed, Jan 29, 2025 at 01:45:56AM +0200, Dmitry Baryshkov wrote: > On Tue, Jan 28, 2025 at 05:11:16PM +0100, Maxime Ripard wrote: > > On Sun, Jan 26, 2025 at 03:29:14PM +0200, Dmitry Baryshkov wrote: > > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > > > index b55e80a57758e8b652eac0cd01cb245a04e221f5..d16af5fe90cb48f6671e7= 98d9dee61a359c9233f 100644 > > > --- a/include/drm/drm_bridge.h > > > +++ b/include/drm/drm_bridge.h > > > @@ -920,6 +920,11 @@ struct drm_bridge { > > > */ > > > int hdmi_audio_max_i2s_playback_channels; > > > =20 > > > + /** > > > + * @hdmi_audio_i2s_formats: supported I2S formats, optional > > > + */ > > > + u64 hdmi_audio_i2s_formats; > > > + > >=20 > > We should document what the default value is if it's optional. >=20 > "The default is to allow all formats supported by the corresponding > I2S bus driver." Does that sound fine from your POV? Yep, sounds good. Maxime --zl6wjwxauob5as6t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ6N1ygAKCRAnX84Zoj2+ dlrgAX9aDNuZXzFPiM/bM/7BcO7J8XzlRwFVr+i1N/QsnMdSLGZj87Zx/r639FZ2 9xJiy4sBgJhgpOdA5fnB/hcAxS9dmow52Aqfbt7V+aCWL7aFCDnTWtgBAdQ7/Ook Ix+DjFHZKA== =pHPw -----END PGP SIGNATURE----- --zl6wjwxauob5as6t--