From: Shyam Saini <shyamsaini@linux.microsoft.com>
To: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Cc: code@tyhicks.com, linux@rasmusvillemoes.dk,
christophe.leroy@csgroup.eu, hch@infradead.org,
mcgrof@kernel.org, frkaya@linux.microsoft.com,
vijayb@linux.microsoft.com, petr.pavlu@suse.com,
linux@weissschuh.net, samitolvanen@google.com,
da.gomez@samsung.com, gregkh@linuxfoundation.org,
rafael@kernel.org, dakr@kernel.org
Subject: [v2 0/3] Properly handle module_kobject creation
Date: Thu, 6 Feb 2025 21:45:35 -0800 [thread overview]
Message-ID: <20250207054538.1110340-1-shyamsaini@linux.microsoft.com> (raw)
Hi Everyone,
This patch series fixes handling of module_kobject creation.
A driver expect module_kset list populated with its corresponding
module_kobject to create its /sys/module/<built-in-module>/drivers
directory.
Since,
[1] commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time")
Call to populate module_kset list is deferred to save init time so that
external watchdog doesn't fireup on some boards and Linux can take
responsibility of feeding watchdog before it spuriously resets the
system. However, [1] this fix caused another issue i.e, consumers
of module_kset can't get related module_kobject during driver
initialisation and hence can't create their
/sys/module/<built-in-module>/drivers directory.
Consequently, [1] breaks user-space applications for eg: DPDK, which
expects /sys/module/vfio_pci/drivers/pci:vfio-pci/new_id to be present.
The second issue was reported and the [2] revert of [1] was
proposed. However, [2] the Revert doesn't address original issue
reported in [1].
This patch series addresses both issues reported in [1] and [2].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=96a1a2412acb
[2] https://lore.kernel.org/lkml/20250130225803.321004-1-shyamsaini@linux.microsoft.com/
Thanks,
Shyam
---
Changes in v2:
- Undo moving of to_module* and lookup_or_create_module_kobject() to module.h
- Refactor and globalize lookup_or_create_module_kobject()
- move __modinit macro construct to module.h
- Fix commit message typos
Changes in v1:
- Rename locate_module_kobject() to lookup_or_create_module_kobject() to accurately
describe its operations.
- Moves lookup_or_create_module_kobject() and to_module* macros to module.h, so
that driver code can use these.
- Handle module_kobject creation and population of module_kset list to fix [1]
and [2] issues.
- Link: https://lore.kernel.org/lkml/20250204052222.1611510-1-shyamsaini@linux.microsoft.com/
Changes in RFC:
Reverts commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time")
---
Shyam Saini (3):
kernel: param: rename locate_module_kobject
kernel: refactor and globalize lookup_or_create_module_kobject()
drivers: base: handle module_kobject creation
drivers/base/module.c | 13 ++++-------
include/linux/module.h | 8 +++++++
kernel/params.c | 53 ++++++++++++++++++------------------------
3 files changed, 36 insertions(+), 38 deletions(-)
--
2.34.1
next reply other threads:[~2025-02-07 5:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 5:45 Shyam Saini [this message]
2025-02-07 5:45 ` [v2 1/3] kernel: param: rename locate_module_kobject Shyam Saini
2025-02-07 5:45 ` [v2 2/3] kernel: refactor and globalize lookup_or_create_module_kobject() Shyam Saini
2025-02-07 7:35 ` Thomas Weißschuh
2025-02-07 9:23 ` Rasmus Villemoes
2025-02-07 5:45 ` [v2 3/3] drivers: base: handle module_kobject creation Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207054538.1110340-1-shyamsaini@linux.microsoft.com \
--to=shyamsaini@linux.microsoft.com \
--cc=christophe.leroy@csgroup.eu \
--cc=code@tyhicks.com \
--cc=da.gomez@samsung.com \
--cc=dakr@kernel.org \
--cc=frkaya@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=samitolvanen@google.com \
--cc=vijayb@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®