mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3][next] tty: tty_buffer: Avoid hundreds of -Wflex-array-member-not-at-end warnings
Date: Fri, 7 Feb 2025 10:38:23 +0100	[thread overview]
Message-ID: <2025020741-shame-landline-c597@gregkh> (raw)
In-Reply-To: <7c396d56-a2ea-4cb5-8a10-a2b78cebfaeb@embeddedor.com>

On Fri, Feb 07, 2025 at 09:53:30AM +1030, Gustavo A. R. Silva wrote:
> 
> > >   	unsigned int used;
> > >   	unsigned int size;
> > >   	unsigned int commit;
> > > -	unsigned int lookahead;		/* Lazy update on recv, can become less than "read" */
> > > +	unsigned int lookahead; /* Lazy update on recv, can become less than "read" */
> > 
> > Coding style change?
> 
> (Whaa? for some reason your response didn't reach my inbox until today)

Sorry, my email was stuck on my system for a day, my fault.

> It seems I got a bit too proactive.
> 
> What do you think about the rest of the patch?

I agree with Jiri's comments, and overall I like it as a way forward.

thanks,

greg k-h

  reply	other threads:[~2025-02-07  9:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  3:39 Gustavo A. R. Silva
2025-02-06  4:40 ` Greg Kroah-Hartman
2025-02-06 23:23   ` Gustavo A. R. Silva
2025-02-07  9:38     ` Greg Kroah-Hartman [this message]
2025-02-06  9:12 ` Jiri Slaby
2025-02-06  9:23   ` Gustavo A. R. Silva
2025-02-11  7:02   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025020741-shame-landline-c597@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®